Cosmetic touch up

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

loocas
Junior Member
Junior Member
Posts: 18
Joined: 2008-07-30, 09:31 UTC
Location: Praha
Contact:

Cosmetic touch up

Post by *loocas »

Hi,

can you, please, unify the colors in the menu bar? This brighter bar is driving me crazy! :D

Image: http://www.duber.cz/dump/tcmd_hideous_bar.png

Thank you!
- loocas
User avatar
karlchen
Power Member
Power Member
Posts: 4601
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, loocas.

Can you please let us know
+ which Windows version you are using?
+ which Windows theme?

Here on Server 2008 R2 Classic Theme, Total Commander 8.0ß20 x64 does not display a white square area between the menu item "Start" and the menu item "Help". In fact, I do not see it on any of the Windows machines which I use more or less regularly.

Kind regards,
Karl
MX Linux 21.3 64-bit xfce, Total Commander 10.52 64-bit
The people of Alderaan keep on bravely fighting back the clone warriors sent out by the unscrupulous Sith Lord Palpatine.
The Prophet's Song
loocas
Junior Member
Junior Member
Posts: 18
Joined: 2008-07-30, 09:31 UTC
Location: Praha
Contact:

Post by *loocas »

Hi, Karl,

I'm on Windows 7 Professional x64 with Aero on and I tweaked a bit my windows colors (in the standard windows settings) to tune the bright theme down a bit.

Nothing fancy, no 3rd party plugins.
- loocas
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

2karlchen
It's definitely Aero (look at window borders). I can reproduce it if I disable XP theme background in TC and change default "3D Objects" color in Window Color and Appearance dialog.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
karlchen
Power Member
Power Member
Posts: 4601
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hi, loocas. Hi, umbra.

Thanks, umbra, for the "how to reproduce the effect" instruction.
Will doing so not cause the same effect to be noticeable in other Windows applications as well?

Karl
MX Linux 21.3 64-bit xfce, Total Commander 10.52 64-bit
The people of Alderaan keep on bravely fighting back the clone warriors sent out by the unscrupulous Sith Lord Palpatine.
The Prophet's Song
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

I don't think so.
In Aero and with XP theming enabled TC behaves just like other apps - obeys to "3D Objects" color setting and basically ignores "Menu" color. But if you disable that, TC starts to differ.

In Aero, buttons in menu bar obey the "3D Objects" setting, but then the almost white rectangle appears and you cannot change its color with any other setting (it keeps the default "3D Objects" color). Also TC still ignores "Menu" color. I have no other application that can disable XP menu theming in Aero, so I cannot compare.

In Classic theme, buttons in menu bar obey the "3D Objects" setting and "Menu" setting starts to work too (that is expected). However in TC it affects only the mentioned rectangle between menu buttons. Menu buttons themselves ignore it. In other apps, "Menu" setting affects the whole menu bar.

Notice that to see this problem, you have to disable XP menu theming in TC, otherwise everything works as expected (at least I haven't noticed any problems). And because TCx32 ignores that setting right now, you have to test it on TCx64.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I cannot reproduce this problem on Windows 7 pro x64 and Aero, with or without the theme background. What do I need to configure to get this effect?
Author of Total Commander
https://www.ghisler.com
loocas
Junior Member
Junior Member
Posts: 18
Joined: 2008-07-30, 09:31 UTC
Location: Praha
Contact:

Post by *loocas »

ghisler(Author) wrote:I cannot reproduce this problem on Windows 7 pro x64 and Aero, with or without the theme background. What do I need to configure to get this effect?
Hi, thanks for looking at this.

Try loading up my theme: http://www.duber.cz/dump/loocas_tcmd_theme.themepack

If even that doesn't work, then I have no idea what's wrong or where it's wrong exactly. :(
- loocas
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The theme wasn't the problem: It seems that Windows uses a different default background color: COLOR_MENUBAR instead of the normal 3d object color. I will use that too in the next beta.
Author of Total Commander
https://www.ghisler.com
loocas
Junior Member
Junior Member
Posts: 18
Joined: 2008-07-30, 09:31 UTC
Location: Praha
Contact:

Post by *loocas »

ghisler(Author) wrote:The theme wasn't the problem: It seems that Windows uses a different default background color: COLOR_MENUBAR instead of the normal 3d object color. I will use that too in the next beta.
You are awesome! Thank you. :)
- loocas
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

While doing that, please don't miss the info in the docs:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms724371%28v=vs.85%29.aspx wrote:COLOR_MENUBAR - The background color for the menu bar when menus appear as flat menus (see SystemParametersInfo).
If menus are not flat (classic Win9x style), the right color is still COLOR_MENU. As you already check for flat menus to choose correct highlight/selection style (3D frame or background color), it should be no problem.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, thanks for the hint!
Author of Total Commander
https://www.ghisler.com
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

NOT fixed in beta 21.
Menu buttons now ignore color changes completely. In beta 20 they reacted to changes of "3D Objects" color but not to "Menu" color, now they ignore both.
While this helped a bit in Aero (the whole menu bar has always the same color now), in Classic theme it didn't help at all.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

You should now get the same menu color in TC and lister - isn't that the case?
Author of Total Commander
https://www.ghisler.com
Sob
Power Member
Power Member
Posts: 941
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

I can confirm that something went wrong:

http://web.hisoftware.cz/sob/img/tc80x64-menu-color-bug.png

1) x64 beta 20: Menu items used COLOR_3DFACE, but it should be COLOR_MENU (classic) / COLOR_MENUBAR (themes).

2) x64 beta 21: Menu items use COLOR_MENUBAR, which fixed it for themes, but is wrong for Classic style. Did you skip the flat menus condition? It's especially bad, because COLOR_MENUBAR seems to be hardcoded and not user-configurable. I normally use much less agressive colors than green in the screenshots, but the difference is still quite visible.

(Btw, if you wonder about that red color in Aero screenshots, it seems to be some kind of unsupported scenario, it's possible to set it, but it's mostly ignored, except for that 1px line)
Post Reply