Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Cosmetic touch up
Goto page 1, 2  Next
 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
loocas
Junior Member
Junior Member


Joined: 30 Jul 2008
Posts: 18
Location: Praha

PostPosted: Sun Feb 19, 2012 5:20 pm    Post subject: Cosmetic touch up Reply with quote

Hi,

can you, please, unify the colors in the menu bar? This brighter bar is driving me crazy! Very Happy

Image: http://www.duber.cz/dump/tcmd_hideous_bar.png

Thank you!
_________________
- loocas
Back to top
View user's profile Send private message Visit poster's website
karlchen
Power Member
Power Member


Joined: 06 Feb 2003
Posts: 4255
Location: Germany

PostPosted: Mon Feb 20, 2012 5:29 am    Post subject: Reply with quote

Hello, loocas.

Can you please let us know
+ which Windows version you are using?
+ which Windows theme?

Here on Server 2008 R2 Classic Theme, Total Commander 8.0▀20 x64 does not display a white square area between the menu item "Start" and the menu item "Help". In fact, I do not see it on any of the Windows machines which I use more or less regularly.

Kind regards,
Karl
Back to top
View user's profile Send private message Send e-mail
loocas
Junior Member
Junior Member


Joined: 30 Jul 2008
Posts: 18
Location: Praha

PostPosted: Mon Feb 20, 2012 5:58 am    Post subject: Reply with quote

Hi, Karl,

I'm on Windows 7 Professional x64 with Aero on and I tweaked a bit my windows colors (in the standard windows settings) to tune the bright theme down a bit.

Nothing fancy, no 3rd party plugins.
_________________
- loocas
Back to top
View user's profile Send private message Visit poster's website
umbra
Power Member
Power Member


Joined: 14 Jan 2012
Posts: 705

PostPosted: Mon Feb 20, 2012 6:04 am    Post subject: Reply with quote

2karlchen
It's definitely Aero (look at window borders). I can reproduce it if I disable XP theme background in TC and change default "3D Objects" color in Window Color and Appearance dialog.
_________________
Windows 7 Pro x64, Windows 8 Pro x64
Back to top
View user's profile Send private message Send e-mail
karlchen
Power Member
Power Member


Joined: 06 Feb 2003
Posts: 4255
Location: Germany

PostPosted: Mon Feb 20, 2012 6:50 am    Post subject: Reply with quote

Hi, loocas. Hi, umbra.

Thanks, umbra, for the "how to reproduce the effect" instruction.
Will doing so not cause the same effect to be noticeable in other Windows applications as well?

Karl
Back to top
View user's profile Send private message Send e-mail
umbra
Power Member
Power Member


Joined: 14 Jan 2012
Posts: 705

PostPosted: Mon Feb 20, 2012 7:42 am    Post subject: Reply with quote

I don't think so.
In Aero and with XP theming enabled TC behaves just like other apps - obeys to "3D Objects" color setting and basically ignores "Menu" color. But if you disable that, TC starts to differ.

In Aero, buttons in menu bar obey the "3D Objects" setting, but then the almost white rectangle appears and you cannot change its color with any other setting (it keeps the default "3D Objects" color). Also TC still ignores "Menu" color. I have no other application that can disable XP menu theming in Aero, so I cannot compare.

In Classic theme, buttons in menu bar obey the "3D Objects" setting and "Menu" setting starts to work too (that is expected). However in TC it affects only the mentioned rectangle between menu buttons. Menu buttons themselves ignore it. In other apps, "Menu" setting affects the whole menu bar.

Notice that to see this problem, you have to disable XP menu theming in TC, otherwise everything works as expected (at least I haven't noticed any problems). And because TCx32 ignores that setting right now, you have to test it on TCx64.
_________________
Windows 7 Pro x64, Windows 8 Pro x64
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 28269
Location: Switzerland

PostPosted: Mon Feb 20, 2012 8:37 am    Post subject: Reply with quote

I cannot reproduce this problem on Windows 7 pro x64 and Aero, with or without the theme background. What do I need to configure to get this effect?
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
loocas
Junior Member
Junior Member


Joined: 30 Jul 2008
Posts: 18
Location: Praha

PostPosted: Mon Feb 20, 2012 10:40 am    Post subject: Reply with quote

ghisler(Author) wrote:
I cannot reproduce this problem on Windows 7 pro x64 and Aero, with or without the theme background. What do I need to configure to get this effect?


Hi, thanks for looking at this.

Try loading up my theme: http://www.duber.cz/dump/loocas_tcmd_theme.themepack

If even that doesn't work, then I have no idea what's wrong or where it's wrong exactly. Sad
_________________
- loocas
Back to top
View user's profile Send private message Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 28269
Location: Switzerland

PostPosted: Wed Feb 22, 2012 10:07 am    Post subject: Reply with quote

The theme wasn't the problem: It seems that Windows uses a different default background color: COLOR_MENUBAR instead of the normal 3d object color. I will use that too in the next beta.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
loocas
Junior Member
Junior Member


Joined: 30 Jul 2008
Posts: 18
Location: Praha

PostPosted: Wed Feb 22, 2012 12:08 pm    Post subject: Reply with quote

ghisler(Author) wrote:
The theme wasn't the problem: It seems that Windows uses a different default background color: COLOR_MENUBAR instead of the normal 3d object color. I will use that too in the next beta.


You are awesome! Thank you. Smile
_________________
- loocas
Back to top
View user's profile Send private message Visit poster's website
Sob
Power Member
Power Member


Joined: 19 Jan 2005
Posts: 748

PostPosted: Wed Feb 22, 2012 12:23 pm    Post subject: Reply with quote

While doing that, please don't miss the info in the docs:

http://msdn.microsoft.com/en-us/library/windows/desktop/ms724371%28v=vs.85%29.aspx wrote:
COLOR_MENUBAR - The background color for the menu bar when menus appear as flat menus (see SystemParametersInfo).

If menus are not flat (classic Win9x style), the right color is still COLOR_MENU. As you already check for flat menus to choose correct highlight/selection style (3D frame or background color), it should be no problem.
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 28269
Location: Switzerland

PostPosted: Wed Feb 22, 2012 2:30 pm    Post subject: Reply with quote

Yes, thanks for the hint!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
umbra
Power Member
Power Member


Joined: 14 Jan 2012
Posts: 705

PostPosted: Fri Feb 24, 2012 7:29 am    Post subject: Reply with quote

NOT fixed in beta 21.
Menu buttons now ignore color changes completely. In beta 20 they reacted to changes of "3D Objects" color but not to "Menu" color, now they ignore both.
While this helped a bit in Aero (the whole menu bar has always the same color now), in Classic theme it didn't help at all.
_________________
Windows 7 Pro x64, Windows 8 Pro x64
Back to top
View user's profile Send private message Send e-mail
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 28269
Location: Switzerland

PostPosted: Fri Feb 24, 2012 11:25 am    Post subject: Reply with quote

You should now get the same menu color in TC and lister - isn't that the case?
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Sob
Power Member
Power Member


Joined: 19 Jan 2005
Posts: 748

PostPosted: Fri Feb 24, 2012 3:10 pm    Post subject: Reply with quote

I can confirm that something went wrong:

http://web.hisoftware.cz/sob/img/tc80x64-menu-color-bug.png

1) x64 beta 20: Menu items used COLOR_3DFACE, but it should be COLOR_MENU (classic) / COLOR_MENUBAR (themes).

2) x64 beta 21: Menu items use COLOR_MENUBAR, which fixed it for themes, but is wrong for Classic style. Did you skip the flat menus condition? It's especially bad, because COLOR_MENUBAR seems to be hardcoded and not user-configurable. I normally use much less agressive colors than green in the screenshots, but the difference is still quite visible.

(Btw, if you wonder about that red color in Aero screenshots, it seems to be some kind of unsupported scenario, it's possible to set it, but it's mostly ignored, except for that 1px line)
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Impressum: This site is maintained by Ghisler Software GmbH

Using phpBB © 2001-2005 phpBB Group