Total Commander

loocas · Posted: Sun Feb 19, 2012 5:20 pm Post subject: Cosmetic touch up

Hi,

can you, please, unify the colors in the menu bar? This brighter bar is driving me crazy! Very Happy

Image: http://www.duber.cz/dump/tcmd_hideous_bar.png

Thank you!
_________________
- loocas

karlchen · Posted: Mon Feb 20, 2012 5:29 am Post subject:

Hello, loocas.

Can you please let us know
+ which Windows version you are using?
+ which Windows theme?

Here on Server 2008 R2 Classic Theme, Total Commander 8.0ß20 x64 does not display a white square area between the menu item "Start" and the menu item "Help". In fact, I do not see it on any of the Windows machines which I use more or less regularly.

Kind regards,
Karl
_________________
Enlightened by Lucid Lynx, enchanted by Maya Mint, productive on Precise Pangolin's Minty Sister.

loocas · Posted: Mon Feb 20, 2012 5:58 am Post subject:

Hi, Karl,

I'm on Windows 7 Professional x64 with Aero on and I tweaked a bit my windows colors (in the standard windows settings) to tune the bright theme down a bit.

Nothing fancy, no 3rd party plugins.
_________________
- loocas

umbra · Power Member Joined: 14 Jan 2012 Posts: 675

2karlchen
It's definitely Aero (look at window borders). I can reproduce it if I disable XP theme background in TC and change default "3D Objects" color in Window Color and Appearance dialog.
_________________
Windows 7 Pro x64, Windows 8 Pro x64

karlchen · Posted: Mon Feb 20, 2012 6:50 am Post subject:

Hi, loocas. Hi, umbra.

Thanks, umbra, for the "how to reproduce the effect" instruction.
Will doing so not cause the same effect to be noticeable in other Windows applications as well?

Karl
_________________
Enlightened by Lucid Lynx, enchanted by Maya Mint, productive on Precise Pangolin's Minty Sister.

umbra · Power Member Joined: 14 Jan 2012 Posts: 675

I don't think so.
In Aero and with XP theming enabled TC behaves just like other apps - obeys to "3D Objects" color setting and basically ignores "Menu" color. But if you disable that, TC starts to differ.

In Aero, buttons in menu bar obey the "3D Objects" setting, but then the almost white rectangle appears and you cannot change its color with any other setting (it keeps the default "3D Objects" color). Also TC still ignores "Menu" color. I have no other application that can disable XP menu theming in Aero, so I cannot compare.

In Classic theme, buttons in menu bar obey the "3D Objects" setting and "Menu" setting starts to work too (that is expected). However in TC it affects only the mentioned rectangle between menu buttons. Menu buttons themselves ignore it. In other apps, "Menu" setting affects the whole menu bar.

Notice that to see this problem, you have to disable XP menu theming in TC, otherwise everything works as expected (at least I haven't noticed any problems). And because TCx32 ignores that setting right now, you have to test it on TCx64.
_________________
Windows 7 Pro x64, Windows 8 Pro x64

ghisler(Author) · Posted: Mon Feb 20, 2012 8:37 am Post subject:

I cannot reproduce this problem on Windows 7 pro x64 and Aero, with or without the theme background. What do I need to configure to get this effect?
_________________
Author of Total Commander
http://www.ghisler.com

loocas · Posted: Mon Feb 20, 2012 10:40 am Post subject:

ghisler(Author) · Posted: Wed Feb 22, 2012 10:07 am Post subject:

The theme wasn't the problem: It seems that Windows uses a different default background color: COLOR_MENUBAR instead of the normal 3d object color. I will use that too in the next beta.
_________________
Author of Total Commander
http://www.ghisler.com

loocas · Posted: Wed Feb 22, 2012 12:08 pm Post subject:

Sob · Power Member Joined: 19 Jan 2005 Posts: 628

While doing that, please don't miss the info in the docs:

ghisler(Author) · Posted: Wed Feb 22, 2012 2:30 pm Post subject:

Yes, thanks for the hint!
_________________
Author of Total Commander
http://www.ghisler.com

umbra · Power Member Joined: 14 Jan 2012 Posts: 675

NOT fixed in beta 21.
Menu buttons now ignore color changes completely. In beta 20 they reacted to changes of "3D Objects" color but not to "Menu" color, now they ignore both.
While this helped a bit in Aero (the whole menu bar has always the same color now), in Classic theme it didn't help at all.
_________________
Windows 7 Pro x64, Windows 8 Pro x64

ghisler(Author) · Posted: Fri Feb 24, 2012 11:25 am Post subject:

You should now get the same menu color in TC and lister - isn't that the case?
_________________
Author of Total Commander
http://www.ghisler.com

Sob · Power Member Joined: 19 Jan 2005 Posts: 628

I can confirm that something went wrong:

http://web.hisoftware.cz/sob/img/tc80x64-menu-color-bug.png

1) x64 beta 20: Menu items used COLOR_3DFACE, but it should be COLOR_MENU (classic) / COLOR_MENUBAR (themes).

2) x64 beta 21: Menu items use COLOR_MENUBAR, which fixed it for themes, but is wrong for Classic style. Did you skip the flat menus condition? It's especially bad, because COLOR_MENUBAR seems to be hardcoded and not user-configurable. I normally use much less agressive colors than green in the screenshots, but the difference is still quite visible.

(Btw, if you wonder about that red color in Aero screenshots, it seems to be some kind of unsupported scenario, it's possible to set it, but it's mostly ignored, except for that 1px line)