[8.51a] Search for tab character alone breaks search history

[Valentino]

Hi

1. Search for tab character (copy/paste real tab character, not \t) in Find Files or Lister. Succeeds.
2. Open Find Files or Find in Lister again - text search history is empty.

Config file seems OK:
0=
1=text1
2=text2
...

Seems like value from config file is trimmed upon reading and history read process is stopped when value is empty.

Thanks!

[milo1012]

It's probably related to that issue.

TC stops reading remaining keys if one appears to be empty.
The main cause here seems: Ini files skip leading and trailing whitespace,
i.e. a thing like

Code: Select all

key=__value__

will read as "value", and a single tab char stored in the ini will therefore appear as an empty value.
(see for example here)


Probably also related:
Christian seems to correctly use quotes around whitespace for things like

Code: Select all

_abc_

-> stored as

Code: Select all

"_abc_"

in ini,
but doesn't store a key at all when I use a single space char as search.

[ghisler(Author)]

Yes, the Windows ini reading functions return empty data for just a tab. I can try to put it in double quotes.

[MVV]

Or you can add BOM to strings that look like empty ones: BOM sequence itself (mentioned in another thread), tab, space... so it won't be empty for INI API and you'll cut BOM then.

[milo1012]

BOM sequence itself (mentioned in another thread), tab, space... so it won't be empty for INI API.

You'd still need to put quotes around it, because otherwise trailing whitespace will still be removed by GetPrivateProfileString.

Fixing it would be nice, but I think the main problem here is: TC shouldn't skip remaining keys if it finds en empty one,
no matter why that key appears empty.

[MVV]

It is not your problem if you use WritePrivateProfileString to store strings and then GetPrivateProfileString to read them: first one quotes string when necessary (as I remember, if string starts or ends with whitespace and if string starts and ends with quotes) to ensure that second one will read exact string that was passed to first one.

[MVV]

Tab character doesn't break history in 8.52b1 but BOM still does that. Please fix it too, searching for BOMs is quite useful sometimes.

[ghisler(Author)]

Thanks for confirming the fix. The BOM problem was postponed to TC 9.