Alternate icon library wasn't select in configuration menu

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

spn13
Junior Member
Junior Member
Posts: 2
Joined: 2016-06-17, 08:30 UTC

Alternate icon library wasn't select in configuration menu

Post by *spn13 »

I made icon library, put it in the %COMMANDER_PATH% directory (flat_icons.dll, flat_icons.inc). But I can't choose it in the Configuration=Icons=Set defoult icon library.

In the dialogs I see:
1: wcnicons.dll
2: ------------ (combobox is empty, I can't choose anything else)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

To make TC see it, you need to rename it to wcmdicon*.dll and add a versioninfo resource with the description field set to something unique.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2ghisler(Author)

Could you provide such a .dll file - the one in https://plugins.ghisler.com/900/wcmicons9v3.zip doesn't seem to conform with this
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
a_flying_visit
Junior Member
Junior Member
Posts: 21
Joined: 2012-07-13, 19:27 UTC

Post by *a_flying_visit »

I've got the same problem as spn 13.
Sorry, but I didn't quite catch. What does it mean "add a versioninfo resource with the description field set to something unique."
Is this supposed to be another file like wcmicons.inc?
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I've just copied default WCMICONS.DLL to WCMICON2.DLL - TC shows it in list, but to WCMICON3.DLL - TC ignores it...
spn13
Junior Member
Junior Member
Posts: 2
Joined: 2016-06-17, 08:30 UTC

Post by *spn13 »

I add the version info in dll and TC shows it in list, but inc file is apply wcmicons.inc, not wcmicons_new.dll. I used custom menu and some icons is not apply.
Emalis.Reckah
Junior Member
Junior Member
Posts: 30
Joined: 2016-06-13, 21:03 UTC

Post by *Emalis.Reckah »

I dont get anyway way restrict the name at all?
cant i just write the lib I want in the ini file with ANY NAME I want?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I don't want to open every single dll in TC directory every time this dialog box is opened. With today's virus scanners this would be painfully slow.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Hmm, the only filename that seems to work is Wcmicon2.dll (as MVV wrote)

If I select Wcmicon2.dll and there also exists an wciconex.dll, then wciconex.dll is used for the menu and Wcmicon2.dll is only used for the button bar. Expected behaviour: use Wcmicon2.dll for everything if selected and disregard wciconex.dll.

If I add a Wcmicon2.inc with my own alterations it is not used when selecting Wcmicon2.dll - either Wcmicons.inc or wciconex.inc if present is always used. Expexted behaviour: use Wcmicon2.inc if provided, when Wcmicon2.dll is selected.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler(Author),
But what if only open WCMICON*.DLL files? Maybe even only ones that have corresponding WCMICON*.INC files?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

But what if only open WCMICON*.DLL files?
I'm already doing this, but I need to detect them even when the user renames them, so I know when I need to reload icons.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Why do you need to reload icons on renaming library? Buttonbar have always reloaded icons manually after applying changes...
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Imagine that I would replace the current library with a new one. TC would't notice, it would still show the button bars with the old icons until you manually reload them...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

In TC9b3 I still seem to only be able to use the file name Wcmicon2.dll other filenames like Wcmicon3.dll does not work
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Did you read my message about the versioninfo requirements? It needs the US-English resource with the comment field set to a userful name to distinguish the library.
Author of Total Commander
https://www.ghisler.com
Post Reply