[BUG] Empty directory is created in target partition...

English support forum

Moderators: white, Hacker, petermad, Stefan2

Post Reply
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

[BUG] Empty directory is created in target partition...

Post by *icfu »

...when trying to copy a directory that is too large to fit on target partition and aborting the operation with pressing "No".

Obviously TC creates the directory before checking available space.

Icfu
This account is for sale
User avatar
majkinetor !
Power Member
Power Member
Posts: 1580
Joined: 2006-01-18, 07:56 UTC
Contact:

Post by *majkinetor ! »

bad design... agree

tc should clean up this garbage
Habemus majkam!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

TC checks available space _per file_, not for the entire operation...
Author of Total Commander
https://www.ghisler.com
User avatar
Sam_Zen
Power Member
Power Member
Posts: 700
Joined: 2005-02-08, 22:59 UTC
Location: NL
Contact:

Post by *Sam_Zen »

One could call this a bug.
One could also call this a sloppy action by the user in the first place, by not checking first.
A hit on the spacebar on the dir is sufficient to avoid this.
0.618033988
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

TC checks available space _per file_, not for the entire operation...
I thought that CountMarked setting is used for calculating the second progress bar BEFORE the copy process has been started, is that wrong? If it is you should correct the help file and the configuration dialog as it is misleading:
Options-Operation wrote:Calculate space occupied by subdirectories
If it is right, the warning should be presented directly, not after the first file is encountered that eats up the last free space.
A hit on the spacebar on the dir is sufficient to avoid this.
It's not sufficient because spacebar counts absolute size, not real size which depends on file system, cluster size, compression, etc...
Besides that pressing SPACE on directories despite TC counting sizes ANYWAY with CountMarked=1 is just an annoying workaround that wastes time.

Icfu
This account is for sale
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I thought that CountMarked setting is used for calculating the second progress bar BEFORE the copy process has been started, is that wrong?
This is correct, but mainly done for the progress bar! Some users may want to copy as many files as possible to one USB stick, and the rest to a second stick, so such a warning would only be annoying...
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Makes sense, but still the creation of empty directories is annoying, also for USB stick users...
With two USB sticks you get redundant content then, one that contains an empty directory structure and one that contains the same directory filled with content.

If it's not possible to prevent creation of empty directories, maybe you find a way to "clean up that garbage" like majkinetor has pointed out. ;)

Icfu
This account is for sale
Post Reply