[8.0ß23] ''cm_UnloadPlugins'' kills TC while packing 7z

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

Heh, seems like nobody understood problem...
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Sir_SiLvA, plugin should cancel packing instead of causing TC to crash. There can't be another right behaviour. When you close some archiver that packs something (or any other program that does something long-standing), it abort packing and closes, but it doesn't cause any crash. Any DLL must stop all running tasks and free all its memory and resources on unloading.
User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

MVV wrote:Sir_SiLvA, plugin should cancel packing instead of causing TC to crash. There can't be another right behaviour. When you close some archiver that packs something (or any other program that does something long-standing), it abort packing and closes, but it doesn't cause any crash. Any DLL must stop all running tasks and free all its memory and resources on unloading.
Yeah, that's what I'm talking about.
The question is simlpe - who does crash - tc or plugin?
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3304
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

MVV wrote:Sir_SiLvA, plugin should cancel packing instead of causing TC to crash. There can't be another right behaviour. When you close some archiver that packs something (or any other program that does something long-standing), it abort packing and closes, but it doesn't cause any crash. Any DLL must stop all running tasks and free all its memory and resources on unloading.
And thats where I have another opinion :!:
In mine noone should execute cm_unload while tc is using a dll ofc,
so no I dont see max Problem see my branch alegory....
(And imho it doesnt matter if TC or Plugin crash - use brain.exe = no crash...)
Hoecker sie sind raus!
User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

2Sir_SiLvA
That, what you say can have some sense, but not in my case.
e.g.
If you make short circuit (accident, or not, has no matter!) - safety fuse must disconnect you device from broken power supply. Device must NOT burn!
Understand my opinion?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48173
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually it's Windows which crashes because the module which is active is suddenly unloaded.

I have no plans to wait for the plugin to end its background operation just for this debug command, sorry.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Christian, I'm sure it is a plugin bug because it really must stop all running background threads on DllMain with DLL_PROCESS_DETACH (this is sent by Windows to module on unloading), but it seems that it doesn't.
User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

TC 8.0 beta 25 + 7zip.wcx 0.7.6.5 -- the bug is still present.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

MaxX, it was discussed and no one tried to fix anything (subforum name should describe why). Also, as I understand, it is a plugin bug, so it should be fixed in plugin.
User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

MVV, where can I find plugin's author? Or he stopped developing it?
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I think you may ask here.
User avatar
MaxX
Power Member
Power Member
Posts: 1034
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

Ukrainian Total Commander Translator. Feedback and discuss.
Post Reply