File Deleting Bug in RAR unpacking

bwh · Post by *bwh » 2009-11-03, 18:30 UTC

Hello,

I need to report a reproducible bug that deletes files without a confirmation possibly causing serious data loss.

I have come across this bug while extracting some .rar files.

Steps to re-produce:
1- Create a multipart rar in target window
2- Switch to target window and extract the multipart archive
3- TC will ask whether to overwrite or not
4- Hitting Escape or clicking cancel will give the error in the screenshot and delete the file on the target window (hitting skip does not cause this)

The same does not happen when using a single rar.

I did the above several times to find the rar files that I've already extracted and whenever I saw "overwrite?" I knew this rar was eaerlier extracted, so safe to delete... Only to realize later that their earlier extracted counterparts got lost due to this bug.

Regards,

Screenshot:Screenshot:
http://img256.imageshack.us/i/bugd.png/

Post by *ghisler(Author) » 2009-11-04, 16:56 UTC

I will check that, thanks.

bwh · Post by *bwh » 2009-11-04, 17:15 UTC

Hi Christian,

I just realized I forgot to mention I have WinRAR as rar handler in packer settings (if its any help).

Thanks for your time and efforts

Post by *ghisler(Author) » 2009-11-06, 17:00 UTC

You mean unpacking via external packer?

bwh · Post by *bwh » 2009-11-06, 17:04 UTC

ghisler(Author) wrote:You mean unpacking via external packer?

I just hit Alt+F9 to unpack, but my settings in Configuration->Packer-> are as follows:
Rar Packer: (path to winrar.exe here)
and use internal un-RAR if possible is checked.

Post by *ghisler(Author) » 2009-11-06, 17:16 UTC

use internal un-RAR if possible is checked

But then the file should be unpacked by Total Commander internally (no "Background" button available), right?

bwh · Post by *bwh » 2009-11-06, 17:21 UTC

ghisler(Author) wrote:
use internal un-RAR if possible is checked
But then the file should be unpacked by Total Commander internally (no "Background" button available), right?

Yeah, you can check the screenshot above, there is only Pause and Cancel (I hope I'm not stupidly skipping something crucial and end up embarrasing myself for stealing your time

)

Post by *ghisler(Author) » 2009-11-09, 17:10 UTC

I have checked it now - it seems that the file is kept when you click "OK", and it's deleted when you click "Cancel". I will try to find a solution.

Post by *ghisler(Author) » 2010-04-06, 15:57 UTC

Can someone test this error with TC 7.55 beta, please?

bwh · Post by *bwh » 2010-04-06, 16:06 UTC

ghisler(Author) wrote:Can someone test this error with TC 7.55 beta, please?

Yay! seems to be fixed...Thanks!

Post by *ghisler(Author) » 2010-04-06, 16:07 UTC

Great, thanks very much!

bwh · Post by *bwh » 2010-04-06, 16:15 UTC

I don't mean to be a nuisance, but I can imagine a scenario where the following happens.

Let's assume, I have 5 different multi-part archives, each consisting of 3 parts for easiness' sake. I wildcard select with
NumPad+, input *.part1.rar as mask then hit Alt+F9.

Depending on target's existence, I'm given an "overwrite" window...I can either skip or skip all. Will a "skip this archive" button be beneficial? It would allow me to "skip all" that archive and will ask for each archive in the initial selected queue.

I don't know how clear I can draw the picture, and I'm not at all sure this is a necessary thing. Just a thought