Sometimes EXE icons are not shown in thumb view of FX plugin

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Sometimes EXE icons are not shown in thumb view of FX plugin

Post by *MVV »

I don't know exact reason, some plugins show icons in thumb view, but some - not.

In my Virtual Panel extracted icons are shown in brief/full mode (plugin extracts icons and return them to TC with FS_ICON_EXTRACTED_DESTROY value), but in thumb mode TC shows default icons for EXEs (but my plugin still returns extracted icons to TC! TC asks for icon, plugin returns FS_ICON_DELAYED, then TC asks for icon again with flag FS_ICONFLAG_BACKGROUND and plugin returns extracted icon).

What is really strange - if I switch TC brief mode icon size to 32x32 and then open VP folder in brief mode and then switch to thumb mode, TC will show extracted icons in thumb mode!

Sample FX plugin can't show icons in thumb view too (but it shows them in brief/full modes; also it shows icons in thumb view after switching to 32x32 icons in brief mode!). :!:

However, plugins TempPanel and FileRedirector are able to show icons in thumb view... :? But I don't have sources so can't find out why.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

What TC version? 32-bit or 64-bit?
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

32-bit. Sample plugin had been tested in debug version that included in archive.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Christian, can you reproduce this behaviour?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Not tested yet, it's on my to do list.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2MVV
I could indeed reproduce it! The problem was that TC was trying to extract small icons instead of large icons by mistake. Please test with beta 8, it should be fixed now.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Thanks, Christian, it works with TC 8 beta 8! :D

But it is still a bit interesting why some plugins was able to display large icons with previous versions. :)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48113
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

They probably didn't use the "delayed" option. That was the only part not working with large icons.
Author of Total Commander
https://www.ghisler.com
Post Reply