Cosmetic touch up

umbra · Post by *umbra » 2012-02-24, 21:54 UTC

Looks like Sob was faster than me

But if you want to see it in action, here it is: video

Post by *ghisler(Author) » 2012-02-24, 22:35 UTC

2) x64 beta 21: Menu items use COLOR_MENUBAR, which fixed it for themes, but is wrong for Classic style. Did you skip the flat menus condition? It's especially bad, because COLOR_MENUBAR seems to be hardcoded and not user-configurable. I normally use much less agressive colors than green in the screenshots, but the difference is still quite visible.

I'm not setting the menu bar background, that should be taken care of by Windows itself when using the classic theme. I do set the background for drawing the individual menu items. However, it seems that I'm currently using COLOR_MENUBAR everywhere. Don't all the systems since XP use the flat menus? The 64-bit version supports only XP and newer. Am I missing something?

Sob · Post by *Sob » 2012-02-24, 22:51 UTC

In fact the menu background visible in empty area was correct all the time, it was the background of items which was wrong. It was wrong in beta 20 and it's still wrong in beta 21 (only with classic theme, it's fixed for others), it's just "different wrong" compared to beta 20.

Don't all the systems since XP use the flat menus?

No. Classic theme = non-flat menus in any Windows version. Any other theme = flat menus.

An older comparison: http://web.hisoftware.cz/sob/img/windows-menu-style.png

Post by *ghisler(Author) » 2012-02-26, 16:39 UTC

You are right, sorry. I will fix it in the next beta.

MVV · Post by *MVV » 2012-03-02, 13:14 UTC

Menu looks good again in TCx64b22.

karlchen · Post by *karlchen » 2012-03-02, 16:43 UTC

Hello, Christian.

Could reproduce the display problem reported and illustrated by loocas here using
+ Server 2008 R2 classic Windows theme
+ Total Commander 8.0ß21 64-bit

Can no longer reproduce the problem using
+ Server 2008 R2 classic Windows theme
+ Total Commander 8.0ß22 64-bit

So the problem seems to have been solved.

Kind regards,
Karl

Post by *ghisler(Author) » 2012-03-02, 16:43 UTC

Thanks! Can anyone else confirm it, please?

umbra · Post by *umbra » 2012-03-02, 20:04 UTC

Yes, it's much better now. In the Classic theme I don't see any issues now.
However, in Aero, there is one more thing left. Submenus and items don't keep their default colors but use colors (text and background) set for menubar. Other apps ignore them.
Image: http://i1057.photobucket.com/albums/t399/uumbra8/TC/bugs/menuitems.jpg

Sob · Post by *Sob » 2012-03-02, 23:32 UTC

I can confirm the fix for Classic theme.

@umbra: The difference between TC and other applications is the way how menu is painted. TC does it by itself, while most other applications let the system do it. And the possibility to change menu color in control panel seems to be just some kind of leftover for themes other than Classic. I think the easiest solution is you simply not changing the menu color. :)
Even if TC got the proper color from current theme, the menus would still look wrong, at least because of selection style. The right solution is to use themed menus when user has themes enabled. I mean, really, who wants just these dropdown menus in main TC window look different than all other menus in whole system? And it's not just about different applications, even all other menus in TC are themed.

umbra · Post by *umbra » 2012-03-02, 23:46 UTC

2Sob
I know what you mean and personally I don't care if this will be changed or not - I don't use those color settings at all. I just wanted to point out the difference between TC and other apps. And yes, themed menus would look better.

Post by *ghisler(Author) » 2012-03-05, 14:39 UTC

Indeed TC does not use themed dropdown menus in the main program. Some popup menus use themes when drawn by the system (or Lazarus). Currently there are no plans to change this, sorry.

umbra · Post by *umbra » 2012-03-16, 12:28 UTC

I think this topic can be closed as fixed. The original bug has been resolved.

Post by *ghisler(Author) » 2012-03-16, 16:43 UTC

OK, thanks!

Duke · Post by *Duke » 2014-06-11, 06:19 UTC

ghisler(Author) wrote:Indeed TC does not use themed dropdown menus in the main program. Some popup menus use themes when drawn by the system (or Lazarus). Currently there are no plans to change this, sorry.

Why are the colors in the main menu different in TC 32Bit and 64bit?

In 32Bit is light blue (Windows 7 Standard)

In 64Bit is dark blue without transparency color??? I would prefer the light blue menu also...

Post by *ghisler(Author) » 2014-06-12, 12:12 UTC

Strange, I'm getting the eact same main menu look in TC 32-bit and 64-bit on Windows 7. I'm using the default Windows 7 theme. However, it's not light blue, it's light gray. So what theme do you really use?