+Verify after copying -file open error not reflected to user

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

MrCricket
Junior Member
Junior Member
Posts: 49
Joined: 2009-05-04, 15:30 UTC

+Verify after copying -file open error not reflected to user

Post by *MrCricket »

8.50b2 32b, clean INI

Tick "Verify after copying" in Configuration->Options->Copy/Delete

Now copying of each file consists of two parts(IMO):

1) copy file from src to dest (while caclulating src's hash sum)
2) read dest while calculating its sum

then: fail (display msgbox) if
  • reading of dest fails or
    sums are different
I've noticed that there is no error message when opening of dest file in step 2 fails, for example when file is opened with "unfriendly" ShareMode flag by another proc or just removed.

Thus, sums comparison is not done.

Is this behaviour designed?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48108
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is a known problem for which I haven't found a solution yet. The problem is that I can't just treat this like a normal verification error, because the two files are most probably the same. I'm currently just logging the error. Maybe someone has a better idea how to handle this.
Author of Total Commander
https://www.ghisler.com
MrCricket
Junior Member
Junior Member
Posts: 49
Joined: 2009-05-04, 15:30 UTC

Post by *MrCricket »

It can be "Cannot read.." dialog as here http://s17.postimg.org/ito2adcen/Untitled2.png

or/and CRC stats dialog at the copy end: http://s14.postimg.org/7mfs2l8dt/Untitled1.png
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48108
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This has been changed now! Please test it.
Author of Total Commander
https://www.ghisler.com
MrCricket
Junior Member
Junior Member
Posts: 49
Joined: 2009-05-04, 15:30 UTC

Post by *MrCricket »

I liked your solution to use same filehandle for copy/verify :)

Verified on TC 8.50b4 32b (2013-09-25)



But you probably should improve ErrorDialog (handle closed in the middle of verify): Image: http://s15.postimg.org/y4acjqkuz/Untitled.png
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48108
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for the info about the error dialog! I already fixed it before beta 4 for the CopyFileEx function, but not yet for the older copy function using ReadFile/WriteFile.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4630
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

MrCricket wrote:But you probably should improve ErrorDialog (handle closed in the middle of verify): Image: http://s15.postimg.org/y4acjqkuz/Untitled.png
The dialog shows a "Skip", "Skill all" and "Abort" button. It's not very clear to me what happens when you choose Skip. If it means the error is ignored then I suggest to name the buttons "Ignore" and "Ignore all".
pmshah
Junior Member
Junior Member
Posts: 10
Joined: 2007-04-12, 20:18 UTC

Copy verify

Post by *pmshah »

This would be a very good feature if works right. I have given up on "moving" files altogether. Too many errors - (read like "too many lost files" due to buggy (read absolutely unreliable) USB implementation on ALL Intel chipset based motherboards with frequent disconnections. My 8 and 6 years old via and Zotac (nVidia) itx work flawlessly. I went the "copy" and then "synch selected" route. Before that I used a special batch file in 4DOS / 4NT to first xcopy and then "FC" the files.

Will install the latest Beta and see if it is an improvement !

BTW intel motherboards have problems with reliably powering and connecting to even 2 USB powered drives consuming < 500ma, (USB 2.0, USB 3 or combo, doesn't matter) while the via and Zotac that I mentioned above have absolutely no problem with handling even 4 USB powered drives simultaneously. In fact I have one each of 750 gb and 1 TB drives drawing 550 ma. No problems with non Intel chipsets !
siealex
Senior Member
Senior Member
Posts: 278
Joined: 2009-03-22, 16:36 UTC

Post by *siealex »

Always use external power for USB drives, no matter how much they consume. At idle state the drive consumes about 500 mA, but at startup it can take 2..3 A (some models even up to 6..8 A). The consumption also increases (up to twice) during intensive track seeking.
PS. Also check your USB cable length. It must not exceed 50 cm including the wires between the motherboard and the USB plug on the PC case. Many drives connect very unreliably with longer cables.
We are not so S.M.A.R.T. as we imagine...
MrCricket
Junior Member
Junior Member
Posts: 49
Joined: 2009-05-04, 15:30 UTC

Post by *MrCricket »

TC 8.50b5 32b:

Now the mbox looks as follows: http://s9.postimg.org/jgzinyp2n/Untitled.png

There is no 'Retry' button - is it OK?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48108
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, "Retry" isn't supported so far. Would it make sense, I mean, is there a chance that the file becomes readable by itself?
Author of Total Commander
https://www.ghisler.com
MrCricket
Junior Member
Junior Member
Posts: 49
Joined: 2009-05-04, 15:30 UTC

Post by *MrCricket »

Would it make sense, I mean, is there a chance that the file becomes readable by itself?
- Not sure about the above, but the current solution is OK for me, thank you!
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

ghisler(Author) wrote:is there a chance that the file becomes readable by itself?
It's not very probable, but possible. For example with network drives (some packet lost) or USB HDD (some power instability).
User avatar
white
Power Member
Power Member
Posts: 4630
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

white wrote:
MrCricket wrote:But you probably should improve ErrorDialog (handle closed in the middle of verify): Image: http://s15.postimg.org/y4acjqkuz/Untitled.png
The dialog shows a "Skip", "Skill all" and "Abort" button. It's not very clear to me what happens when you choose Skip. If it means the error is ignored then I suggest to name the buttons "Ignore" and "Ignore all".
Tested TC8.50b5 32bit. Buttons are now called Ignore and Ignore all. Thanks!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48108
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I also thought that they should be better called "Ignore" and "Ignore all", otherwise people may think that TC would skip copying the files.
Author of Total Commander
https://www.ghisler.com
Post Reply