filtering with CD kept for each tab and not for all left/rig

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

User avatar
nsp
Power Member
Power Member
Posts: 1803
Joined: 2005-12-04, 08:39 UTC
Location: Lyon (FRANCE)
Contact:

Re: filtering with CD kept for each tab and not for all left/rig

Post by *nsp »

@Ghisler(Author)
MANY THANKS FOR IMPLEMENTATION
Somme comments :

Option is exposed as :
Configuration / Display / Folder Tabs / [] Save displayed file types separately for each tab
DirTabFilters=0/1

It is checked by default not sure if it is going to "trouble" un-aware user. Unless help is well documented.

SaveTabs LoadTabs work as expectded...

--edited

One point not expected: Directory hot list should reset current tab filter but it does not.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: filtering with CD kept for each tab and not for all left/rig

Post by *ghisler(Author) »

Test scenario:
- Button with command: em_Executable,cm_SrcViewModeList Background_GREEN
- If CTRL+U is now executed, the filter is applied but the View Mode (background colour) is unfortunately lost.
I will check it, thanks.
One point not expected: Directory hot list should reset current tab filter but it does not.
Should it? Filters are now stored by tab, not by directory. So
- click in directory hotlist just changes directory, filter is preserved
- Shift+ click in directory hotlist opens a new tab, with filter reset
- click in Alt+F1 drive list just changes drive, filter is preserved
- shift+click in Alt+F1 drive list opens a new tab with that drive, with filter reset

What do you other testers think?
Author of Total Commander
https://www.ghisler.com
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6450
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: filtering with CD kept for each tab and not for all left/rig

Post by *Horst.Epp »

ghisler(Author) wrote: 2021-04-30, 13:57 UTC
Test scenario:
- Button with command: em_Executable,cm_SrcViewModeList Background_GREEN
- If CTRL+U is now executed, the filter is applied but the View Mode (background colour) is unfortunately lost.
I will check it, thanks.
One point not expected: Directory hot list should reset current tab filter but it does not.
Should it? Filters are now stored by tab, not by directory. So
- click in directory hotlist just changes directory, filter is preserved
- Shift+ click in directory hotlist opens a new tab, with filter reset
- click in Alt+F1 drive list just changes drive, filter is preserved
- shift+click in Alt+F1 drive list opens a new tab with that drive, with filter reset

What do you other testers think?
I like the current behaviour.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3374)
TC 11.03 x64 / x86
Everything 1.5.0.1371a (x64), Everything Toolbar 1.3.2, Listary Pro 6.3.0.69
QAP 11.6.3.2 x64
User avatar
tuska
Power Member
Power Member
Posts: 3741
Joined: 2007-05-21, 12:17 UTC

Re: filtering with CD kept for each tab and not for all left/rig

Post by *tuska »

ghisler(Author) wrote: 2021-04-30, 13:57 UTC
One point not expected: Directory hot list should reset current tab filter but it does not.
Should it? Filters are now stored by tab, not by directory. So
- click in directory hotlist just changes directory, filter is preserved
- Shift+ click in directory hotlist opens a new tab, with filter reset
- click in Alt+F1 drive list just changes drive, filter is preserved
- shift+click in Alt+F1 drive list opens a new tab with that drive, with filter reset

What do you other testers think?
From my point of view, the current behaviour can be left as it is, for the following reasons:
  • Without having a shortcut that switches off a filter, I can't get by with this topic at the moment anyway,
    i.e. if necessary, I can switch off a filter myself at the touch of a key-press.
  • For frequently used directories in the Directory hotlist (Ctrl+D), you can create commands in the command field,
    that automatically switch off the filter. For example: em_PATH,cm_SrcViewMode0,cm_SrcAllFiles
=============
I would like to take this opportunity to address one more issue:
If someone has a lot of tabs with filters, then I don't think there is currently a way to remove all the filters [in both panels] at once.
Perhaps a new command would be desirable here.

For test purposes, I have solved this as follows:
  1. SAVETABS2L %COMMANDER_PATH%\TABs\STANDARD.tab
  2. Button - CloseAllTabs_display-currently-used-folders

    Code: Select all

    TOTALCMD#BAR#DATA
    OPENTABS %COMMANDER_PATH%\TABs\CloseAllTabs_display-currently-used-folders.tab
    
    wcmicons.dll,85
    OPENTABS %COMMANDER_PATH%\TABs\CloseAllTabs_display-currently-used-folders.tab|https://ghisler.ch/board/viewtopic.php?p=337785#p337785|https://ghisler.ch/board/viewtopic.php?p=333550#p333550|Tabs in beiden Fenstern schließen (auch "gesperrte") bis auf je -1-
    
    
    -1
    
    %COMMANDER_PATH%\TABs\CloseAllTabs_display-currently-used-folders.tab
    Reference: Close All Tabs, one click, both panels including locked ones

    Code: Select all

    [activetabs] 
    0_path=. 
    0_options=1|0|0|0|0|0|0 
    activetab=0 
    [inactivetabs] 
    0_path=. 
    0_options=1|0|0|0|0|0|0 
    activetab=0
    
    O R
    Button - CloseAllTabs_path-C

    Code: Select all

    TOTALCMD#BAR#DATA
    OPENTABS %COMMANDER_PATH%\TABs\CloseAllTabs_path-C.tab
    
    wcmicons.dll,85
    OPENTABS %COMMANDER_PATH%\TABs\CloseAllTabs_path-C.tab|https://ghisler.ch/board/viewtopic.php?t=42122|https://ghisler.ch/board/viewtopic.php?p=333550#p333550|Close all tabs in both panels, e.g. "Locked, but directory changes allowed"
    
    
    -1
    
    %COMMANDER_PATH%\TABs\CloseAllTabs_path-C.tab
    Reference: Close All Tabs, one click, both panels including locked ones

    Code: Select all

    [activetabs]
    0_path=C:\
    0_options=1|0|0|0|0|0|0
    activetab=0
    [inactivetabs]
    0_path=C:\
    0_options=1|0|0|0|0|0|0
    activetab=0
    
  3. OPENTABSL %COMMANDER_PATH%\TABs\STANDARD.tab
  4. Button - Show saved TABs - cd %COMMANDER_PATH%\TABs\

    Code: Select all

    TOTALCMD#BAR#DATA
    cd %COMMANDER_PATH%\TABs\
    
    %COMMANDER_PATH%\TOTALCMD.EXE,6
    cd %COMMANDER_PATH%\TABs\ || Show saved TABs|- ADDING tabs [active panel]: Double-click on .tab file|- REPLACEMENT of tabs [active panel]: Shift+double click on .tab file|wincmd.ini [Configuration] TabDir=%COMMANDER_PATH%\TABs\
    
    
    -1
    
Please check.
Thank you!
EDIT: 4. Button added
Last edited by tuska on 2021-05-02, 14:30 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: filtering with CD kept for each tab and not for all left/rig

Post by *ghisler(Author) »

Test scenario:
- Button with command: em_Executable,cm_SrcViewModeList Background_GREEN
- If CTRL+U is now executed, the filter is applied but the View Mode (background colour) is unfortunately lost.
I have tested it now:
1. When automatic view mode switching is OFF, the view mode stays on the side you applied it to when you press Ctrl+U
2. When automatic view mode switching is ON, an automatic mode will be applied after Ctrl+U on each side, so the manually added mode will be lost.

I think that this is expected behaviour, although some people may prefer to swap the view mode with Ctrl+U too...
Author of Total Commander
https://www.ghisler.com
User avatar
tuska
Power Member
Power Member
Posts: 3741
Joined: 2007-05-21, 12:17 UTC

Re: filtering with CD kept for each tab and not for all left/rig

Post by *tuska »

ghisler(Author) wrote: 2021-05-02, 09:00 UTC I think that this is expected behaviour, although some people may prefer to swap the view mode with Ctrl+U too...
Yes, I am one of them, because I have concerns about using several filters without a background colour,
because then it's much easier to miss a filter.

Thanks for the test and the information! :)
Post Reply