[Implemented] Help file: improvement on SELECTFILES command description

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

[Implemented] Help file: improvement on SELECTFILES command description

Post by *DrShark »

'Dialog box: Configuration - Change button bar' help page wrote:14. SELECTFILES [...] marks files [...]
Supported modifiers: [...], S=Reverts whether just files or files+folders are selected when Shift is pressed during execution. Add directly to the end of the command name [...]
The current descriprion of S modifier, which starts with "Reverts" word, and though it is mentioned above that [without S added] "SELECTFILES [...] marks files", there is no stress here that it means "files, but not folders", so user can think that SELECTFILESS reverts just files or files+folders selection to opposite of SELECTFILES behavior, while actually pure SELECTFILES doesn't select folders whether the Shift key is pressed or not.

So to make it more clear, my suggestion is to change the help text to something like this:
Suggested text wrote:14. SELECTFILES [...] marks files [...]
Supported modifiers: [...], S=When Shift is pressed during execution, marks also folders. Add directly to the end of the command name [...]
Or am I missing something and pure SELECTFILES actually should mark also folders (when Shift is NOT pressed), which currently doesn't work this way, and then there is a bug in TC?
Last edited by white on 2022-06-02, 10:53 UTC, edited 1 time in total.
Reason: Added [Implemented] to subject
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
funkymonk
Senior Member
Senior Member
Posts: 408
Joined: 2013-12-04, 09:56 UTC

Re: Help file: improvement on SELECTFILES command description

Post by *funkymonk »

I also found the description of the "S" modifier extremely difficult zu understand. "Revert" is probably not a suitable word in this sentence. Since I am still not 100% sure about the consequences of "S", I would highly appreciate an improved description by Mr. Ghisler.

BTW: Is there a way (e.g., a modifier) to suppress the error message if no matching file was found/selected? That would be very helpful... Thank you!

BR
funkymonk
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Help file: improvement on SELECTFILES command description

Post by *ghisler(Author) »

Example:
1. Button containing SELECTFILES *
User clicks button -> all files but no folders are selected
2. Button containing SELECTFILESS *
User clicks button -> all files but no folders are selected
User clicks button while holding shift -> both files and folders are selected
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4576
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Help file: improvement on SELECTFILES command description

Post by *white »

I agree with the others that the help text is not clear. Please change it as suggested.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48005
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Help file: improvement on SELECTFILES command description

Post by *ghisler(Author) »

OK, will change.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4576
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Help file: improvement on SELECTFILES command description

Post by *white »

Tested OK using TC10.50b8.

Moderator message from: white » 2022-06-02, 10:51 UTC

Added [Implemented] to subject.
Post Reply