[TC 10 b1a] Duplicate hotkeys in Player dialog

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

[TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

In the New Player tab in Lister configuration tyhere are duplicated hotkeys:
5833="&Recommended filters (LAV, ffdshow)"
5837="&Remove"

I suggest to chage the last one to:
5837="Re&move"

MY updated version of Dglrange.txt can be downloaded here: https://madsenworld.dk/tcmd/Dglrange.zip
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40927
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *ghisler(Author) »

Thanks for the correction. I also have one small correction to your dlgrange.txt.
Please add this range for the dialog shown in synchronize dirs when you click on [1x] button:
7202-7204
I have added it below the line 7001-7010 in my file.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

Hmm,
7202="Show:"
has to do with the Master password input dialog
and there are no 7203 and 7204 strings.

This string is the only one related to to the [1x] button that can have a hotkey:
7903="Hide files which match the criteria"
Last edited by petermad on 2021-03-12, 11:56 UTC, edited 2 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40927
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *ghisler(Author) »

Ah, sorry, you are right, it's about the master password dialog on Windows 10:

Here are the 3 strings:
7202="Sho&w:"
7203="&Request again for each new connection"
7204="&Use Windows Hello to keep password stored"
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

BTW the strings: 7901, 7902 and 7903 only works in 32bit TC not in 64bit

I also find the wording of thes strings peculiar:
7901="Search must match where:"
7902="on at least one side\non both sides (if present)\non the left if present, leave out files only on the right\non the left, if not present on the right\non the right if present, leave out files only on the left\non the right, if not present on the left"

I think this is better English (unless I misunderstood the meaning):
7901="Search must match:"
7902="on at least one side\non both sides (if present)\non the left side (if present), leave out files only present on the right side\non the left side, if not present on the right side\non the right side (if present), leave out files only present on the left side\non the right side, if not present on the left side"
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40927
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *ghisler(Author) »

Strings 7901: This was already reported in the German forum, so I didn't reply about it:
viewtopic.php?f=2&t=74006

I will consider your suggestions about 7901+2.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

Code: Select all

5837="&Remove"
changed to:

Code: Select all

5837="Re&move"
in TC 10 b2 :-)

_____________________________________

Code: Select all

7901="Search must match where:"
not changed in TC 10 b2 I still think it should be changed to:

Code: Select all

7901="Search must match:"
(you cannot have a sentence like "Search must match where on at least one side").

_____________________________________

Code: Select all

7902="on at least one side\non both sides (if present)\non the left if present, leave out files only on the right\non the left, if not present on the right\non the right if present, leave out files only on the left\non the right, if not present on the left"
changed to

Code: Select all

7902="on at least one side\non both sides (if present)\non the left (if present), leave out files only present on the right side\non the left side, if not present on the right side\non the right (if present), leave out files only present on the left side\non the right side, if not present on the left side"
I still think "side" should be added in two places
7902="on at least one side\non both sides (if present)\non the left side (if present), leave out files only present on the right side\non the left side, if not present on the right side\non the right side (if present), leave out files only present on the left side\non the right side, if not present on the left side"
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40927
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *ghisler(Author) »

I left out "side" because the string became too long to be fully visible...

About "Search must match:" - you are right, I only changed it in the 32-bit version by mistake.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

I left out "side" because the string became too long to be fully visible...
Hmm, not here - there is plenty of space - with standard font and DPI setting:

In Windows 7 w. Aero theme: https://madsenworld.dk/tcmd/searchmustmatchWin7.png
In Window 10 w. standard theme: https://madsenworld.dk/tcmd/searchmustmatchWin10.png
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

BTW, don forget to update this line (81) in Dglrange.txt:

Code: Select all

5854-5860,5870-5874
to:

Code: Select all

5854-5860,5870-5874,5878-5879
https://madsenworld.dk/tcmd/Dglrange.zip
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

2ghisler(Author)
I have added two new lines (for the context menu) to Dglrange.txt:

Code: Select all

1089,1734
1095,1718
https://madsenworld.dk/tcmd/Dglrange.zip

It is just for completeness sake - I know that other programs and Windows set their own hotkeys - but at least this way TC's are not duplicated.
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40927
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *ghisler(Author) »

Thanks, I will use it.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b1a] Duplicate hotkeys in Player dialog

Post by *petermad »

For TC 10 b6 I have expanded line 51 (now line 58) in dglrange.txt with the new string 5373:
from:

Code: Select all

5190-5192,5194,5316,5112
to

Code: Select all

5190-5192,5194,5316,5373,5112


I have also added string 1673 and 2018 to the line of multi-strings (line 133 (now line 140)):

Code: Select all

;4,5,13,15,1131,1181,1233,1254,1310,1315,1364,1380,1400,1604,1605,1606,1609,1610,1611,1673,1674,1678,1704,1707,1710,2018
And added these strings from the multi-strings to the list:

Code: Select all

1315
1400
1673
1674
1678
1710
2018

Can be downloaded at: https://madsenworld.dk/tcmd/Dglrange.zip
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 8] Duplicate hotkeys in Player dialog

Post by *petermad »

I have added the new string no. 5374 to Dglrange.txt

Can be downloaded at: https://madsenworld.dk/tcmd/Dglrange.zip
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 10413
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [TC 10 b9] Duplicate hotkeys in Player dialog

Post by *petermad »

I have added the new string no. 5798 to Dglrange.txt

Can be downloaded at: https://madsenworld.dk/tcmd/Dglrange.zip
License #524 (1994)
Danish Total Commander Translator
TC 10.00 b8 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (20H2) 64bit, 'Everything' 1.4.1.1005
TC 3.21b2 on Android 6 & 11
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply