New strings for TC 9.20 - anything missing?

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

browny
Senior Member
Senior Member
Posts: 287
Joined: 2007-09-10, 13:19 UTC

Post by *browny »

petermad wrote:2brownyCan you explain that a little further?
As in the previous message:
This string is used near the drive selection drop-down and as a tab title in beta 3.

Try Alt+F7, find anything, press Feed to listbox
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Try Alt+F7, find anything, press Feed to listbox
Aha - this IS string 656="Search result:" (not "String result:" as you wrote) - and it is not new at all - I can trace it back to TC 2.11
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Try to reproduce Test 2 described in this post: viewtopic.php?p=341408#341408

In step 8) you will see a message box having title <Error!>. Isn't it a missing string?

Regards
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Isn't it a missing string?
No - that is string 1402="<Error!>" being used.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Thanks for the explanation :)

So maybe it could be replaced with some nice-looking text? It looks a bit unusual and inconsistent with <>.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, TC should do this when the new strings are missing. However, in English it should use the new strings. I will fix it in beta 4.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, translators have been contacted, and some have already replied - thanks a lot!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

String 1397 isn't used until TC is restarted - it is not enoug to just change the language.
Confirmed fixed in TC 9.20b4 :-)

The string 1396="Invalid input!" is not used by the internal English dialog - it just shows <Error!>
Confirmed fixed in TC 9.20b4 :-)

There is no string shown for the new placeholder [f] in the MRT, Shift+F4 and F7 dialogs when you press th [±] button.
Confirmed fixed in TC 9.20b4 for the Multi-Rename tool, but not for the Shift+F4 and the F7 dialog - even though history.txt says:
15.05.18 Added: Multi-rename tool: New placeholder [f] for option "First of each word uppercase (English in Titles)", also support in F7 and Shift+F4, e.g. <[f][N] (32/64)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Confirmed fixed in TC 9.20b4 for the Multi-Rename tool, but not for the Shift+F4 and the F7 dialog
Thanks, I will add it to that menu too. The history only tells you that the placeholder works there.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

The history only tells you that the placeholder works there
Sure - I just meant, to say, that if it works there, it also ougth to be in the menu in those two places.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

ghisler(Author) wrote:Yes, TC should do this when the new strings are missing. However, in English it should use the new strings. I will fix it in beta 4.
If I understood correctly, the intention was to replace <Error!> message with some other string in this case: viewtopic.php?p=341713#341713

Currently - no changes of the behavior in Beta 4.

Regards
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Please explain what doesn't work for you. I get error "Search text too long! (L=1022>127) in Lister when I try to search with a very long string.

Note: If you use a language different than English and it hasn't received the new strings yet, you will still get <Error!>, but in your language. I prefer to show that instead of an English error.
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

The problem occurs even when English is set.

To avoid any ambiguities, I'll describe all the steps again:

1) create c:\test\test.zip - it should contain file1.txt and file2.txt (with any contents).
2) go to c:\test
3) press Alt+F7 and search for *.txt files, with "Search archives" option enabled
4) start search
5) press "Feed to listbox" button
6) select file1.txt, press F4 - TC asks if you want to unpack file to temp directory
7) choose Yes, edit the file and save changes
8) TC asks if repack changed file - choose Yes - file is repacked
9) select file2.txt, press F4 - TC says that the operation cannot be performed, because the archive has been modified - the message box has title <Error!>

Regards
User avatar
vdijken
Member
Member
Posts: 181
Joined: 2016-07-30, 14:07 UTC
Location: The Netherlands

Post by *vdijken »

I can confirm that it happens exactly as MArcinW describes. But when you don't put the files in a listbox but open the ZIP instead in TC you can edit all files without any problem. TC unpacks and packs the files without any problem.

But I saw another oddity: When you edit the first file in the listbox and then you remove in the other panel in ..\LOCAL\TEMP\_tc the .bak file and you return to the panel with the listbox, that listbox disappears and shows the contents of the ZIP file! When you do any other action in the other panel the panel with the listbox does not change.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

select file2.txt, press F4 - TC says that the operation cannot be performed, because the archive has been modified - the message box has title <Error!>
Why should TC show "Search text too long!" here? It makes no sense. In this dialog, it should still show <Error!>, and it does.
Author of Total Commander
https://www.ghisler.com
Post Reply