Wrong button color

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, Stefan2, white, sheep

Post Reply
Sob
Power Member
Power Member
Posts: 908
Joined: 2005-01-19, 17:33 UTC

Wrong button color

Post by *Sob » 2018-06-07, 17:33 UTC

In Windows 7 with Classic theme, buttons for "Directory hotlist" and "History" in main window have wrong color (white instead of standard system color) when tabs are visible:
Image: http://web.hisoftware.cz/sob/img/tc920b6-button-color.png
It happens only in x64 version.

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-08, 10:16 UTC

This is a known difference between TC 32-bit and 64-bit. You can see it also in the search dialog:

In TC 32-bit, Tabs have a body color like buttons. In TC 64-bit, tabs have a body colors like a window background. Since the "Directory hotlist" and "History" buttons are transparent, you get these background colors too on tabs.
Author of Total Commander
http://www.ghisler.com

Sob
Power Member
Power Member
Posts: 908
Joined: 2005-01-19, 17:33 UTC

Post by *Sob » 2018-06-08, 11:43 UTC

But it's a little bit too "shiny". The rest of interface has proper clBtnFace color and suddently these two buttons are bright white, and it changes depending on whether there are tabs or not.

It definitely wasn't well known difference in 9.12, the color was fine there. I checked previous betas and it first appeared in beta2 (beta1 was still ok). And looking at history.txt, it must be caused by this:
09.05.18 Fixed: Buttons for directory hotlist and history didn't have the right foreground color in high contrast mode with black background (64)
Btw, the difference in search dialog you mentioned, there's no such thing here, both x86 and x64 TC have same color tabs (clBtnFace).

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-11, 14:09 UTC

That's about the foreground color, not background color. I finally found a solution, but I had to modify the Lazarus compontent library to do it...
Author of Total Commander
http://www.ghisler.com

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW » 2018-06-11, 14:17 UTC

If you could paste old and modified Lazarus code here, I could submit a bug report to the Lazarus. They take care about compatibility with Delphi, so there is a chance that they'll fix the problem.

Regards

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-11, 14:23 UTC

It's not really a bug: What you see there is the actual tab background color shining through. All the other controls are covering the tab surface. TC does draw a buttonface background for the SpeedButtons in this case to give them the color we want.
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-13, 17:59 UTC

This should be fixed in TC 9.20 release candidate 1, please test it!
Author of Total Commander
http://www.ghisler.com

Sob
Power Member
Power Member
Posts: 908
Joined: 2005-01-19, 17:33 UTC

Post by *Sob » 2018-06-13, 22:23 UTC

Fixed, thank you.

Post Reply