IconHandler icons not restored after entering archive

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1307
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

IconHandler icons not restored after entering archive

Post by *DrShark » 2019-05-02, 21:21 UTC

ghisler(Author) wrote:
2019-04-29, 13:58 UTC
Yes, TC prefers the DefaultIcon over the IconHandler, because in the past some icon handlers were causing crashes. This way you can use the icon handler in Explorer and the DefaultIcon in TC.

You need to delete the DefaultIcon entry if you want to use the icon handler instead.
I had:

Code: Select all

[HKEY_CLASSES_ROOT\InternetShortcut\DefaultIcon]
@="C:\\Windows\\System32\\url.dll,5"
[HKEY_CLASSES_ROOT\InternetShortcut\ShellEx\IconHandler]
@="{FBF23B40-E3F0-101B-8488-00AA003E56F8}"
After I deleted DefaultIcon's default entry (@) now I have:

Code: Select all

[HKEY_CLASSES_ROOT\InternetShortcut\DefaultIcon]
[HKEY_CLASSES_ROOT\InternetShortcut\ShellEx\IconHandler]
@="{FBF23B40-E3F0-101B-8488-00AA003E56F8}"
And now TC is showing per-file url icons using icon handler until... I'll enter archive with packed url files.
In archive, TC shows white icons for all url files (which is expected because icon handler doesn't work in archive to avoid extracting all files just to get their icons), but after that TC is starting to show that white icons for all url files in all filesystem (where it should use icon handler.)
Refresh (Ctrl+R) doesn't help (TC still shows white icons for URL files,) and issue can only be solved by TC restart.

Reproduced using clean wincmd.ini using Total Commander 9.22a on Windows Vista 32-bit.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38017
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: IconHandler icons not restored after entering archive

Post by *ghisler(Author) » 2019-05-06, 08:16 UTC

This probably happens because there is no associated program - TC uses the exe icon on an associated program in archives when there is no IconHandler registry entry.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1307
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: IconHandler icons not restored after entering archive

Post by *DrShark » 2019-05-06, 11:10 UTC

In my case I have IconHandler (but not DefaultIcon, see first post) for *.url files in registry, and followin happens:
1. Open folder with *.url files: TC uses IconHandler to show per-file icons for *.url files;
2. Open archive with *.url inside: TC shows white icons for all *.url (probably that's what you described as "exe icon");
3. Leave archive or open any folder with *.url files outside archive in opposite panel: TC will still use white ("exe") icons (as in step 2) for *.url files in that dir instead of per-file (IconHandler) icons (as in step 1.)
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38017
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: IconHandler icons not restored after entering archive

Post by *ghisler(Author) » 2019-05-06, 19:24 UTC

What happens when you double click url files? do they open in a browser? Normally TC should show the icon of that browser inside archives.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1307
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: IconHandler icons not restored after entering archive

Post by *DrShark » 2019-05-07, 11:04 UTC

ghisler(Author) wrote:
2019-05-06, 19:24 UTC
What happens when you double click url files? do they open in a browser?
Yes, a double click opens a browser.
ghisler(Author) wrote:
2019-05-06, 19:24 UTC
Normally TC should show the icon of that browser inside archives.
Only icons are affected (they are white blank icons for all *.url inside archive). I described what icons for *.url icons TC shows in file system folders (if not to open archive with *.url inside in that TC session) in this post (in short: custom favicon if defined, if one not defined - depends on protocol which is used in a link to which url file points.)
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38017
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: IconHandler icons not restored after entering archive

Post by *ghisler(Author) » 2019-05-09, 10:27 UTC

How does the entire registry entry looks? In your post, there is no browser defined to open the file.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1307
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: IconHandler icons not restored after entering archive

Post by *DrShark » 2019-05-09, 12:16 UTC

ghisler(Author) wrote:
2019-05-09, 10:27 UTC
How does the entire registry entry looks? In your post, there is no browser defined to open the file.
I sent registry keys related to .url association in today email with subject:
White .url icons everywhere after entering archive with .url

As you can see, following command defined for Open action:

Code: Select all

[HKEY_CLASSES_ROOT\InternetShortcut\Shell\Open\Command]
@="\"C:\\Windows\\System32\\rundll32.exe\" \"C:\\Windows\\System32\\ieframe.dll\",OpenURL %l"
Actual app which will open particular url will probably depend on uri protocol defined in url file.
If you'll also need associations for protocols, please tell what registry keys to export.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1307
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: IconHandler icons not restored after entering archive

Post by *DrShark » 2019-10-19, 14:28 UTC

history950.txt wrote:15.05.19 Fixed: Per file icons (e.g. for .url files) could be lost when entering archive containing the same file type (32/64)
I can confirm that this issue as described in first post has been fixed in TC 9.50 beta 1.
Last edited by DrShark on 2019-10-23, 16:38 UTC, edited 1 time in total.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38017
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: IconHandler icons not restored after entering archive

Post by *ghisler(Author) » 2019-10-21, 15:14 UTC

Thanks! This caused me a lot of headaches...
Author of Total Commander
http://www.ghisler.com

Post Reply