Dark Mode: not themed buttons in standalone Lister's Search and Configuration dialogs

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Dark Mode: not themed buttons in standalone Lister's Search and Configuration dialogs

Post by *DrShark »

This issue is not mentioned in dark mode known issues topic, so I'm creating a bug report for it.

Reproduced with TC 9.50 beta 1 on Vista 32-bit:

0. Activate dark mode in TC.
1. Open text file with Lister avoiding plugins (Alt+Shift+F3).
1.1 Call Find text dialog:
it will be all dark, including OK, Cancel and Help buttons.
1.2 Search for a word that doesn't exist in a file, so you'll get Not found dialog:
---------------------------
Not found:
---------------------------
text to find
---------------------------
ОК
---------------------------
It will also be all dark, including OK button.
2. Switch to plugin view (I used uliser).
2.1 Call Find text dialog: OK, Cancel and Help won't be dark-themed.
2.2 Search for text to get "Not found" dialog: it won't be dark-themed at all.
3. Return from plugin view to Lister's text view (mode 1).
3.1 Call Find text dialog: OK, Cancel and Help won't be dark-themed.
3.2 Search for text to get "Not found" dialog: OK button in it won't be dark-themed.

I'll update this post when will re-check it on Windows 10 too.

Edit: modified topic title to make it more correct. Original one was too general: "Dark Mode, Lister, Search dialog and plugins"
Last edited by DrShark on 2019-11-06, 19:27 UTC, edited 1 time in total.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *ghisler(Author) »

I have checked it - this "Not found" dialog is a MessageBox created by the plugin, not part of Lister.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *DrShark »

ghisler(Author) wrote: 2019-10-21, 15:47 UTC I have checked it - this "Not found" dialog is a MessageBox created by the plugin, not part of Lister.
Understand about "Not found" dialog in ulister.
What about not themed buttons (see 2.1, 3.1, 3.2 in 1st post)? BTW, after loading a plugin the buttons aren't black-themed also in other Lister parts (like Options->Configure dialog). Mentioned buttons aren't also themed if to open a picture (I used JPEG one) in Explorer Preview mode and then to switch to text mode. This is reproduced in TC 9.50 beta with dark mode active on Vista 32-bit using classic theme.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *ghisler(Author) »

They are themed here. Are you perhaps using standalone Lister?
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *DrShark »

Today I sent screenshots to support email.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *ghisler(Author) »

Thanks, I have received them. Sadly I couldn't reproduce the problem so far.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *DrShark »

Please try to reproduce in Lister with custom settings for Dark Mode.
My settings from [Lister] and [ListerDark] sections:

Code: Select all

[Lister]
textwidth=81
binwidth=75
SearchGoBack=4
JpgStartup=1
BmpStartup=1
Multimedia=1
RTF=0
HTMLasText=1
LinkBraces=1
Maximized=0
x=88
y=116
dx=776
dy=538
Wrap=1
LeftMargin=200
RightMargin=200
TopMargin=200
BottomMargin=200
IView=1
IViewPath=e:\Programs\IrfanView\i_view32.exe
Caret=1
Font3=Verdana KOI8,-16,b,204
CenterBitmap=1
AutoRotate=1
PreviewHandlers=1
ThumbnailProviders=1
UserEncodings=Китайский упрощенный GB2312 (20936)
NoPluginFileTypes=*.reg
Codepage=0
[ListerDark]
FgColor=0
BgColor=12632256
BTW, color mode behavior of Lister and QuickView if opened while or after applying cm_SwitchDarkmode seems to be inconsistent: sometimes Lister / QuickView use dark colors on default TC theme, and default colors in Dark TC theme.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *ghisler(Author) »

Here I can only reproduce it when launching Lister as a standalone program via switch /S=L <filename> . Maybe you have redefined F3 to this?
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *DrShark »

ghisler(Author) wrote: 2019-11-01, 15:26 UTC Here I can only reproduce it when launching Lister as a standalone program via switch /S=L <filename> . Maybe you have redefined F3 to this?
I've checked it now, and yes, in this TC copy I have redefined F3 to external Lister (%COMMANDER_EXE% /O /S=L).
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark Mode, Lister, Search dialog and plugins

Post by *ghisler(Author) »

Nice, this will be fixed in the next beta.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Dark Mode: not themed buttons in standalone Lister's Search and Configuration dialogs

Post by *DrShark »

history950.txt wrote:01.11.19 Fixed: Dark mode: Lister buttons in search and settings were not themed when Lister was started as a separate process via Totalcmd.exe /S=L <filename> (32)
I can confirm the fix for buttons in Search text, Not found and Configuration dialogs in Lister started as a separate process.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Post Reply