Lister: hotkeys don't work in Explorer Preview for text files

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Lister: hotkeys don't work in Explorer Preview for text files

Post by *DrShark »

If to open a some file with text (like *.txt, *.htm, *.mht) in Lister and switch to Explorer preview mode, Lister's keyboard shortcuts don't work anymore, so there is no way to switch to other mode with keyboard or close it with Esc key.

This behavior is present in TC 9.50 beta 1 on Vista 32-bit.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9846
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *petermad »

Confirmed - but only for file types that Explorer knows. For example TC's .mnu files are shown in Listers mode 1 even if you choose mode 8.
Last edited by petermad on 2019-10-19, 21:15 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 887
Joined: 2011-03-11, 10:11 UTC

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *Usher »

In Windows XP Explorer preview doesn't work for text files listed above (Lister mode 1 is forced even for html files or Unicode text), and for pictures I can use hotkeys when switch to Explore preview.
Regards from Poland
Andrzej P. Wozniak
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *DrShark »

Usher wrote:
2019-10-19, 14:53 UTC
and for pictures I can use hotkeys when switch to Explore preview.
Yes, it's the same here. Maybe it's because pictures are handled by different handler/provider, which may define different TC behavior:
18.02.19 Added: Lister: Press '8' to use IPreviewHandler to show preview as the Explorer, or use IThumbnailProvider when there is no preview handler (shows as '4') (32/64)
(here on Vista 32-bit for *.jpg when I press '8', Lister shows Explorer Preview method as active in Options menu).
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *ghisler(Author) »

Unfortunately it depends on the preview handler - some work, some don't.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *DrShark »

ghisler(Author) wrote:
2019-10-21, 15:46 UTC
Unfortunately it depends on the preview handler - some work, some don't.
So can't catch Lister's keys if preview handler catches them? Since Explorer Preview mode is built-in now, maybe there is a need to describe the situation with keys in Help? E.g. that user should press Alt to activate Lister's File menu and use arrows to navigate there. Also, it seems currently in TC Help there is no description of possibility to switch between Lister modes with keys 1 ... 8, so if it will be added, you can also add a note that a switch from Explorer Preview mode and other actions with keyboard may not work because of used handler (the same may happen in Image/Multimedia mode if some plugins, like IEView, are used).
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *ghisler(Author) »

That's right, I get similar problems with some preview handlers in the Explorer too. I have tried to subclass the window, but this doesn't work when it uses multiple nested windows.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *DrShark »

history951.txt wrote:24.02.20 Fixed: ESC and TAB didn't work in Lister with Explorer preview, use tckeyhandler.dll/tckeyhandler64.dll for temporary WH_KEYBOARD hook. A global hook is used only when the preview is loaded in a separate process (32/64)
I can confirm in TC 9.51 RC3 Esc now closes Lister in Explorer Preview view (tested with *.txt, *.htm, *.mht on Windows 7 32-bit). But keys 1...7 to switch from Explorer Preview still don't work. Maybe it's worth to make all the the keys used by Lister to be cached by TC with hook in Explorer Preview by default, and to make the list of keys catched with hook configurable?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9846
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: Lister: hotkeys don't work in Explorer Preview for text files

Post by *petermad »

I can confirm the fix in TC 9.51 rc3 32/64 bit. :-) (testet with Windows 7 and 10 (1909))
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.988 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply