[9.50] Scroll margin in Brief mode scrolls too late

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3308
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

[9.50] Scroll margin in Brief mode scrolls too late

Post by *Flint »

Tested in 9.50β4 32- and 64-bit.

1. Set scroll margin to e.g. 6 (both top and bottom).
2. Switch to Brief mode in both file panels.
3. In the left panel open some directory with few files, so that there is no scrollbar.
4. In the right panel open some directory with many files with not very long names, so that a) there is a scrollbar, and b) there are at least 2 fully visible columns in the panel.
5. Use Up/Down arrows to scroll through the elements in the right panel, and notice when horizontal column scrolling happens.
6. For backward movement, it happens when there are exactly the specified amount of 6 elements from cursor to the top (excluding cursor itself), and you press Up.
7. For forward movement, it happens when there are fewer files after the cursor, than the specified 6 (in my experiments, it was sometimes fewer by 3, sometimes by 2).

I could reproduce it only under the described conditions (for example, if I switched panels, in the left panel it worked OK; if I had scrollbars in both panels, it worked OK; etc.).

Here is the INI file I could reproduce this with:

Code: Select all

[Configuration]
ScrollingTopMargin=6
ScrollingBottomMargin=6
FirstTime=0
FirstTimeIconLib=0
[right]
path=c:\
ShowAllDetails=0
show=1
sortorder=0
[1920x1200 (8x16)]
maximized=1
[left]
path=c:\windows\system32\drivers\
ShowAllDetails=0
show=1
sortorder=0
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39728
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *ghisler(Author) »

That's because the list may end with a partially visible line at the bottom, while it always ends at a complete line at the top.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3308
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *Flint »

In Brief mode there are no partially visible lines, they are wrapped into the next column. And even if there were, a single partial line should not cause 2 or 3 lines shift.

I guess, it has something to do with different height of file panels, since one has scrollbar at the bottom, and the other doesn't. So TC is probably calculating the amount of items in one column in the left panel, and then applies it to the right column, where this amount is in fact different.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39728
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *ghisler(Author) »

Well, there are partial lines at the end which contain no file name.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3308
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *Flint »

But since they are not visible to user, it would only be sensible to exclude them from the count.

In any case, that partially visible line alone would not explain why switching left panel to Brief mode with scrollbar suddenly makes the right panel work correctly; nor how it could translate into 2-3 extra lines in calculations, instead of 1.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39728
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *ghisler(Author) »

I have tried to reproduce it now, but failed:
1. When I go down the list in brief view and arrive in the last fully visible column, I see 4 lines below the cursor. The scroll margin is set to 4. When I now go down one more line (so only 3 are left), TC scrolls by 1 column to the side, exactly as it should be.
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3308
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *Flint »

2ghisler(Author)
Did you follow the steps exactly? It's important for reproducing, that a) the left panel does not have a scrollbar, b) the right panel does have it, and c) you are working in the right panel. I'll record a video, if necessary.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39728
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *ghisler(Author) »

Ah, I didn't try in the right panel, thanks!
Author of Total Commander
http://www.ghisler.com

User avatar
Flint
Power Member
Power Member
Posts: 3308
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50] Scroll margin in Brief mode scrolls too late

Post by *Flint »

Confirm fixed in 9.50β6.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64

Post Reply