[solved] TC 9.5b7 - USB labels in buttonbar clipped

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[solved] TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

history.txt:
26.11.19 Added: Show up to 3 connected USB devices without drive letter (e.g. phones, tablets) also in drive buttonbar (32/64)
When using non-flat drive buttons, the labels on USB devices without drive letter (u1, u2, u3) are clipped in the right side or very close to the right side of the button - see: https://madsenworld.dk/tcmd/usbinbuttonbar.png
Last edited by petermad on 2019-12-11, 22:59 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *ghisler(Author) »

Which font do you use for these buttons (main window font)?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

Which font do you use for these buttons
Is that something I can control separately? - I only see that it is following the font of the Main window.

I am using the old TC standard font setting (I really don't like Segoe and non-bold is not practical when coloring file names)

So my font settings are:

Code: Select all

FontSize=8
FontName=Microsoft Sans Serif
FontWeight=700
FontSizeWindow=8
FontNameWindow=Microsoft Sans Serif
FontWeightWindow=700
But even with non-bold setting for the Main windows the u2 label is pretty close to the edge of the right side of the drive button - see: https://madsenworld.dk/tcmd/usbinbuttonbarsnonbold.png (Windows 7, Aero theme, non-flat buttons, Microsoft Sans Serif, normal font)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *MaxX »

It looks like there's no enough space for two symbols.
Tahoma 8 pt. looks almost similarry in classic XP theme.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *ghisler(Author) »

There is enough space with Segoe UI, 9. I will try to make these buttons a bit larger.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

Can't you just move the text one charater to the left?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *ghisler(Author) »

No I can't - this would be possible if I kept the "eject" icon you get, but this is also as bug: The icon is wrong when you disable icons from Explorer. The real icon takes more space, so I can't move the character to the left. I have now made this button adaptable - it will be larger when needed. Only these USB icons will be made larger, the drive icons will keep their size.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

The icon is wrong when you disable icons from Explorer
I use OldDriveIcons=2, so that explains it.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *ghisler(Author) »

Please try with beta 8.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

Hmm - now I get the general icon for removable drives when using OldDriveIcons=2 - here under Windows 7: https://madsenworld.dk/tcmd/phonebutton.png and the "2" is still clipped a little (with bold font).
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *ghisler(Author) »

The button size calculation seems to be correct, but the theme seems to cut off a part of the text. :(
Any suggestions?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

Any suggestions?
Add 2 pixels to the calculation...
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14793
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b7 - USB labels in buttonbar clipped

Post by *petermad »

Looks OK in TC 9.5b9 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply