Dark More: Focus doesn't dissappear from command line

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Dark More: Focus doesn't dissappear from command line

Post by *DrShark »

I reported this by email, but Christian Ghisler couldn't reproduce this.

To reproduce:
1. Start TC, switch to dark mode.
2. Move mouse pointer over Total Commander's command line:
command line borders will become white.
3. Start moving the pointer to and from command line.
Eventually when mouse pointer will be out of command line, the command line will still have white borders.

Note: such white border disappears if to move mouse pointer again to and from command line, or if TC window size is changed, it is minimized/maximized, or the command line gets covered by other window (if other window covers only part of command line, white border will disappear only for that part after switching from that window to TC).

Reproduced in TC 9.50 beta 10 on Vista 32-bit with classic theme.
Last edited by DrShark on 2019-12-30, 12:21 UTC, edited 1 time in total.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39980
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark More: Focus doesn't dissappear from comman line

Post by *ghisler(Author) »

with classic theme
Thanks for the extra info, that was the problem - Classic theme doesn't know a hover effect in normal mode, so there is no WM_PAINT when the cursor leaves the control. I will have to use a timer to handle this.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark More: Focus doesn't dissappear from command line

Post by *DrShark »

history950.txt wrote:30.12.19 Fixed: Dark mode, classic theme: Moving mouse cursor away from combobox sometimes didn't change the border from focused to normal (32/64)
I can confirm the fix in TC 9.50 beta 11, checked on Vista 32-bit with classic theme.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark More: Focus doesn't dissappear from command line

Post by *DrShark »

The problem still exists on Windows XP:
* on classic theme moving mouse pointer over command line doesn't change its focus look at all.
* on default XP theme the behavior is the same as was on Vista before beta 11 fix: focused border sometimes does't disappear after moving the pointer away from command line.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39980
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark More: Focus doesn't dissappear from command line

Post by *ghisler(Author) »

Sorry, I will not invest any more time in this minor problem just for XP. It's extremely time consuming.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark More: Focus doesn't dissappear from command line

Post by *DrShark »

ghisler(Author) wrote:
2020-03-01, 07:50 UTC
Sorry, I will not invest any more time in this minor problem just for XP. It's extremely time consuming.
On Vista's classic theme you fixed the issue by using timer. Can you simply enable it also for XP's default theme to see what will happen (it's really strange that this timer doesn't work as it should on XP's classic theme, but maybe it at least will work on Luna)?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39980
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark More: Focus doesn't dissappear from command line

Post by *ghisler(Author) »

I'm already doing the same on Vista and XP, there is no version check (just a check whether classic theme is on or off). So something is different on XP, but it's very time consuming to find out what exactly is different. :(
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Dark More: Focus doesn't dissappear from command line

Post by *DrShark »

ghisler(Author) wrote:
2020-03-02, 11:40 UTC
there is no version check (just a check whether classic theme is on or off).
As far as I understand, XP's defalut Luna theme is not recognized by TC as classic, and since the behavior there is the same as on Vista's classic theme BEFORE adding a timer, I wonder how TC deals with mouse hovering the command line in this case...
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
Post Reply