[solved] TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[solved] TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *petermad »

TC 9.5b12 can no longer read subfolders in sqx archives (both solid and non solid) correctly.

To test - download this sqx archive with files from TC 9.5b2: https://madsenworld.dk/tcmd/tc950b2.sqx and try an go into the Language folder - only the *.inc files are shown - do the same with TC 9.5b11 - all language files are shown.

Probably has to do with one of these changes:
08.01.20 Added: Further improved speed of switching between directories within a large archive (32/64)
31.12.19 Added: Faster loading of large archives, and faster switching between directories within that archive (32/64)
or maybe this:
08.01.20 Fixed: Going back to a different directory within an archive via history was re-reading the entire archive (32/64)
Tested with TotalSQX plugin version 2.11 - https://totalcmd.net/plugring/totalsqx.html on Windows 7
Last edited by petermad on 2020-01-10, 13:54 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *ghisler(Author) »

Confirmed, thanks for the sample file - this will help me a lot finding the reason.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *ghisler(Author) »

The reason is the special structure of SQX archives: Files are not grouped by directory but by extension, to make solid archives smaller. The error occurs when a file in the archive root appears after a file in a subdirectory. It's easy to fix.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *petermad »

But this file is not packed with the solid option enabled...
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48077
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *ghisler(Author) »

That's not the point here: The problem is the SQX library used: It has a function "UnpackFiles(list of files)". However, TC calls "ProcessFile(extract)" for each individual file, which is incompatible with the SQX library. Therefore it unpacks like this: When TC calls ProcessFile, the SQX plugin just remembers what to unpack. The actual unpacking only occurs when CloseArchive is called. Unpacking or viewing single files works fine this way, but comparing (which occurs after each ProcessFile call) doesn't work because the file isn't there.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14795
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: TC 9.5b12 - Can no longer read subdirs in sqx archives correctly

Post by *petermad »

Confirmed fixed in TC 9.4b12a :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply