[9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

[9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *MVV »

I've just noticed this quite unpleasant TC bug. When I unpack an archive via Alt+F9 (tested with 7z archive on clean TC run so internal 7z plugin used), TC doesn't restore archived folder timestamps. When I unpack same archive via 7-Zip context menu command, folder timestamps are restored as expected.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *ghisler(Author) »

NOT confirmed. It may depend on the archive whether folders are explicitly stored inside or not.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *MVV »

I have a 7Z archive which is unpacked by 7-Zip normally and by TC properly. So I assume that folders are stored in it since 7-Zip is able to extract them properly.

I've created a small test archive:

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="ttt.7z"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="ttt.7z"

N3q8ryccAAQp/MV5sAAAAAAAAAAiAAAAAAAAAIK9CDEBAAV0eWh0Z3kAAACBMweuD85vVl76Dfok
g9wXd2LyF4XKhV4rwMxeEKybM1P69PjFXG2sY/biL2wjpQtCzpsewQu/FtoLZlhfxUpHhvtIMsv6
/gi0oK7aIrQvT2EqEaI8cAwTRQ4hLKbBknz197cm248l7DRMnYYx6KZQfzJlzAXx174BCPzMxLdG
L8clOu3S5qZoOms6SO+H9ljD8R5IbhVlF2MUvzTDLkVeW9NCABcGCgEJgKYABwsBAAEjAwEBBV0A
EAAADIDeCgFMlxgkAAA=
With this archive it is easy to check that different TC versions including the latest one have this bug:
1. Unpack by Alt+F9 - folder timestamps not restored.
2. Unpack by drag-and-drop a folder within TC - folder timestamps not restored.
3. Unpack by drag-and-drop a folder from 7-Zip to TC - folder timestamps not restored (though here TC may not know if it should copy folder timestamps).
4. Unpack to a subfolder using 7-Zip context menu - folder timestamps restored.
5. Unpack by drag-and-drop a folder from 7-Zip to Explorer - folder timestamps restored.

I've checked with TC 9.50b13 32/64, 9.50b1 32/64, 9.22a 32/64, 9.50rc1 32/64.
Last edited by MVV on 2020-01-24, 14:22 UTC, edited 1 time in total.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *MVV »

Since Total7zip also doesn't preserve folder timestamps during extracting, perhaps it is a common problem for packer plugins, or for WFX interface. As I know, restoring folder timestamps is an operation that should be done in a second pass, when all files are extracted so no files will be added to unpacked folders.
MartinK
Junior Member
Junior Member
Posts: 53
Joined: 2010-11-19, 20:21 UTC
Location: Brno, Czech Republic

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *MartinK »

Confirmed ONLY with clean TC.

With plugin Total7zip_0856 (I recommend) or 7zip-0.5.8 works fine. (Must be set CopyDirTimeStamp=1).

It works the same on 9.22a
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *MVV »

Well, CopyDirTimeStamp=1 fixes behaviour in cases 1-3 for Total7zip case, you're right, but not for internal 7Z unpacker.
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *petermad »

Just try with this archive: https://madsenworld.dk/tcmd/test7zinternal.7zint

The extension is set to 7zint - in that way it is not opened with a plugin when pressing Enter on it (unless you just happen to have 7zint registered as an extension for your plugins)

If I press Enter on this archive and F5 on the folder testdir it is unpacked with current date.
If I press Ctrl+PgDn on the archive and F5 on the folder testdir it is unpacked with original date (by one of my plugins).

Of course you can also test with a clean ini - then it doesn't matter if I open the archive with Enter or Ctrl+PgDn - the testdir is always unpacked with current date.

If I don't enter the archive but use Alt+F9 to unpack it, the date of testdir is always preserved indicating the unpacking is done by plugin.
If I don't enter the archive but use Alt+F9 to unpack it with a clean ini file (no plugin), testdir is unpacked with current date.

CopyDirTimeStamp=1 when testing.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *ghisler(Author) »

You are right, in my tests it was using the 7zip plugin. I will fix it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14808
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [9.50b13] Unpacking on Alt+F9 doesn't preserve dir timestamps

Post by *petermad »

Confirmed fixed in 9.5rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply