Dark Mode, F5-F2 queue copy: hang on abort after clicking queue window with mouse

[DrShark]

To reproduce:
1. Start TC with following wincmd.ini:

Spoiler

Code: Select all

[Configuration]
QuickSearchAllowNoMatch=1
EditWaitTime=4
InactiveFocus=2000000
HistoryCut=0
ForceDarkModeOptions=1
WantDebugInfo=0
DebugThreads=0
1hourdif=1
AdminShares=1
AltSearch=2
Aligned extension=1
autotreechange=0
CountSpace=1
CountMarked=1
CopyStreams=1
CopyComments=14
CopyDirTimeStamp=1
CompareCaseSensitive=0
CompareVertical=0
CmtOemFont=0
DirTabOptions=1978
DirTabLimit=32
DriveisCD=EFI
firstmnu=1349
FirstTimeZIP=0
FirstTime=0
FileTipWindows=1
FirstTimeUnpack=0
fTips=3
InstallDir=C:\backup_d\tcmd32
IconsInMenus=17
IconsOnNet=1
PanelsVertical=0
MarkDirectories=1
NewStyleProgress=2
OldStyleTree=0
onlyonce=0
RenameSelOnlyName=0
StartupScreen=0
SortUpper=3
ShellExtIcons=1
ShowParentDirInRoot=1
Showicons=2
ShowEXEandLNKicons=2
ShowCentury=1
SortDirsByName=0
SyncFlags=53
SyncButtons=63
Savepath=1
Savepanels=1
SizeStyle=0
SizeFooter=0
SaveCommands=1
ShowHiddenSystem=1
Small83Names=0
SoundDelay=-10
SpaceMovesDown=1
test=63
Tips=3
TrayIcon=1
ToolTipDelay=100
UseLongNames=1
Win32TipWindows=1
WmfAllowed=3
UseRightButton=1
UseTrash=1
UnicodeListWarn=0
Viewertype=0
WantXPLook=1
IconOverlays=1
ThumbsLocation=%$LOCAL_APPDATA%\GHISLER
ThumbsCopyDel=1
ThumbsCustomFieldsEnabled=1
ThumbOptions=15
ThumbExplTypes=*.* | *.htm *.html *.wmf
ThumbPlgTypes=*.*
ThumbIrfXnTypes=*.* |*.wmf
ThumbTxtTypes=*.txt *.ini *.inf *.htm* *.php
ThumbWidthNoCache=64
ThumbHeightNoCache=64
lastmd5=0
ExplorerForCopy=0
Win95Delete=0
pluginbasedir=c:\totalcmd\Plugins
SeparateTree=0
DirBrackets=2
CompareIgnoreRepSpace=1
CompareIgnoreRepeatedLines=1
IconsSpecialFolders=3
AlwaysToRoot=0
SingleClickStart=0
SaveHistory=1
WatchDirs=3
QuickSearchExactMatch=0
QuickSearchMatchBeginning=0
LogOptions=7263
LogRotateLimit=0
LogKeepCount=30
IgnoreListFileEnabled=1
CustomFieldsInDlg=1
IgnoreListFile=tcignore.txt
ttciniwritable=2979
CopyHugeBlockSize=10240
CopyHugeBlockSizeOther=64
ThumbsInDlg=0
FirstFTPSync=0
WatchDirsExclude=ABCDEFGHIJKLMNOPQ
SpeedLimit=5.0
SeparateTreeWidth=160
QuickSearchAutoFilter=1
CopyDefaultMethod=0
UseNewDefFont=0
LastSearchOptions=480
CommentPreferredFormat=4
IconClickSelection=1
UseRubberBandSelection=1
BreadcrumbDelayButton=-250
CheckUsbHdd=1
SetEncoding=дц.do.not.remove
FirstTimeIconLib=0
OldListIcons=0
OldDriveIcons=0
AutoComplete=3
CrcSeparateFiles=1
CrcSeparateFolders=0
LogFile=%TEMP%\totalcmd.log
DarkMode=2
EverythingForSize=0
UseEverything=0
SamePartitions=CE,D
HistoryThinning=0
AssociationMultiVerbs=1
HintMultiFilters=1
CompareBytesPerLine=8
Mainmenu=
CrcForceUtf8=0
CrcForwardSlashes=0
CrcAppendExt=1

2. Start copying some big file(s) with F5-F2.
3. Minimize main Total Commander window.
4. In Background Transfer Manager queue window, click [x] button, don't move mouse pointer:
at first, message box

Code: Select all

---------------------------
Total Commander
---------------------------
User abort!
---------------------------
OK   Cancel   
---------------------------

will appear,
then tooltip "Close" will appear over [x] BTM window button,
and now both BTM window and User Abort msgbox (+its parent - TC main window) will hang.

Actually in step 4 you can move mouse pointer, TC will hang even if "Close" tooltip will appear not exactly over [x] button.

Hang stack trace by WhatIsHang tool:

Code: Select all

Execute Address:
77315DD4  ntdll.dll!KiFastSystemCallRet

Call Stack:
045A4444  75EAF99F  user32.dll!SendMessageA+0x49
045A4464  004DA516  TOTALCMD.EXE+0xda516
045A44A4  0078C106  TOTALCMD.EXE+0x38c106
045A4CCC  0070F191  TOTALCMD.EXE+0x30f191
045A8054  00572A30  TOTALCMD.EXE+0x172a30
045AFF58  0041184C  TOTALCMD.EXE+0x1184c
045AFF60  0041185F  TOTALCMD.EXE+0x1185f
045AFF74  00403672  TOTALCMD.EXE+0x3672
045AFF88  75E0D4D1  kernel32.dll!BaseThreadInitThunk+0x12
045AFF94  772F1593  ntdll.dll!RtlInitializeExceptionChain+0x63
045AFFD4  772F1566  ntdll.dll!RtlInitializeExceptionChain+0x36

Trying to close TC's task via Task Manager usually goes as closing of normal not-hang app: without a warning that app doesn't respond, but once I got such warning so Windows also created a minidump of hang event.

Reproduced using TC 9.50 RC1, Vista 32-bit with classic theme.

If this error won't be reproduced by others, I can send that dump and full WhatIshang report to support email.

While testing this, I also found that sometimes after using F5-F2 if target file exists, user confirms Overwrite and then aborts queue copy, main TC window sometimes gets its "Active" window property disabled, so it's possible to swith to it with e.g. Alt+Tab or Task Manager, but it's not possible to do anything there. Solution is either to enable "Active" property of TC window with 3rd party software that can change properties of windows, or to kill TC with Task Manager. I got this both in Dark and Normal TC modes on same Windows, and will make a separate bug report for it as soon as will find step by step way to reproduce it. UPD: found 2 ways to reproduce it, both should work with above custom and default wincmd.ini, now I reported it here: viewtopic.php?f=32&t=57216

[ghisler(Author)]

Sorry, cannot reproduce, I tried multiple times in Vista with classic theme.
The only "freeze" I see is when I click on the background transfer manager while the confirmation dialog is up.
But this is expected because the transfer manager has its own thread, and this thread hangs while the dialog is displayed by the foreground thread.

[DrShark]

Sorry, cannot reproduce, I tried multiple times in Vista with classic theme.

OK, I sent full WhatIshang report and the dump of hang by email. I will try some more tests to rule out possible 3rd party cause of that hang.

On second issue from start post, in separate email I also sent a link to the dump of TC process at the moment its window lost enabled "active" property (because so far I didn't find step by step reproduce way).

[DrShark]

It seems my custom wincmd.ini is required to reproduce it.
I updated reproduce steps in and posted my [Configuration] section of my wincmd.ini in start post.

[ghisler(Author)]

I will try with your custom ini, thanks!

Is anyone else able to reproduce the hang? Doesn't have to be on Vista...

[DrShark]

As I wrote in email (with attached full wincmd.ini, not just [Configuration]), which sent half an hour ago, I reproduced it on Windows 7 32-bit on first try.
Started copying video file with F5-F2,
minimized TC (it went to tray),
pressed [x] in BTM,
User abort OK/Cancel appeared,
mouse pointer were still over BTM's [x],
few seconds after (when "Close" tooltip appeared over [x]) User abort OK/Cancel became inaccessible for actions (trying to move, clicks/keypresses).

[DrShark]

02.02.20 Fixed: Dark mode, background transfer manager: Aborting operation by clicking on close button could freeze the main program when minimized to system tray (32/64)

I can confirm this fix. Actually in addition to a hang caused by minimize to tray, there was a freeze (which actuallly made User OK/Cancel inaccessible, and actual hang happened on try to call TC window or tray context menu) caused by CopyDefaultMethod=0, which is an additional uncredited bugfix I can also confirm. Tested in TC 9.50 final on Vista 32-bit with classic theme.

[ghisler(Author)]

Great, thanks for all your help in the beta test!