CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unlocked

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *petermad »

Well confirmed fixed in TC 9.51 RC2 64bit under Windows 7 :-)
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39980
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *ghisler(Author) »

Thanks - I'm moving this to fixed bugs since I'm using the same code for 32-bit, it was just not included in the release.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *DrShark »

I can confirm the 32-bit version of TC 9.51 RC3 now also doesn't lock CHM help files, tested on 32-bit Windows Vista and 7.
Also, in this version the history reflects the limitation of the fix: even with new function there is still a lock on Windows XP:
history951.txt wrote:Fixed: Help file would get locked when opened with a page other than the main index (e.g. Keyboard shortcuts) -> use HH_DISPLAY_TOPIC instead of HH_HELP_CONTEXT (only works on Windows Vista and newer) (32/64)
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Flint »

Confirm the fix in 32-bit version in 9.51.rc3.
DrShark wrote:
2020-02-26, 21:51 UTC
Also, in this version the history reflects the limitation of the fix: even with new function there is still a lock on Windows XP:
I'm not sure about that. I've tested in Windows 2000, and the CHM file is successfuly freed as soon as I close the help. And I've re-checked rc2, CHM remained locked there.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *DrShark »

Flint wrote:
2020-02-26, 22:36 UTC
I'm not sure about that. I've tested in Windows 2000, and the CHM file is successfuly freed as soon as I close the help. And I've re-checked rc2, CHM remained locked there.
Well, I still have a lock problem on 32-bit XP. I cannot test on anything older, and I doubt Christian Ghisler tried to test this with OS older than XP too (at least he didn't mention such tries, but he wrote that in his test on XP even opening index help page gets it locked there)...
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *petermad »

I can confirm that there is no longer a lock of totalcmd.chm in 32bit TC 9.51 rc3 under Windows XP, 7, 8.1 and 10 (1909) :-)

2DrShark
Well, I still have a lock problem on 32-bit XP
I don't.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Flint »

DrShark wrote:
2020-02-26, 22:42 UTC
Well, I still have a lock problem on 32-bit XP.
OK, I've tested specifically in XP 32-bit, and no CHM lock there for me.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
User avatar
Usher
Power Member
Power Member
Posts: 888
Joined: 2011-03-11, 10:11 UTC

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Usher »

@DrShark, was 2Flint
What is the name of your language files? TC doesn't want to load WCMD_LNG_*.CHM where LNG is the language code followed by the second underscore in name. For example WCMD_POL_8.chm won't load but WCMD_POL8.chm or WCMD_POL.8.chm will be loaded with no problem.
Last edited by Usher on 2020-02-27, 01:13 UTC, edited 1 time in total.
Regards from Poland
Andrzej P. Wozniak
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Flint »

2Usher
Our Russian help file is named WCMD_RUS.CHM. It is loaded, when the language file has name either WCMD_RUS.LNG (as in the distribution) or WCMD_EXT_RUS.LNG (as in our full Russification package). In both cases, there is no lock of CHM in the latest TC version.

However, I have not checked the Russian help in Win2000 or WinXP, only in Win7. XP and 2000 I tested with the default English help.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
User avatar
Usher
Power Member
Power Member
Posts: 888
Joined: 2011-03-11, 10:11 UTC

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Usher »

2Flint
Sorry, my message was addressed to DrShark, fixed now.
Regards from Poland
Andrzej P. Wozniak
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *DrShark »

Here's what I tried on Windows XP Pro 32-bit with built English set as a language for TC 9.51 RC3:
1. Open help in main TC window or from dialog with F1, or "Keyboard" from Help menu.
2. Close Help window with Esc.
3. Try to replace TOTALCMD.CHM in %COMMANDER_PATH% with another TOTALCMD.CHM file:
after pressing Overwrite, Access denied dialog will appear.

There is also a separate issue with not opening CHM help at all if TC is launched on XP from a shortcut with "Run with different credentials" property and "Protect my computer and data from unauthorized progrem activity" option set, reported here.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *petermad »

DrShark wrote:
2020-02-06, 06:38 UTC
To reproduce:
1. Open Pack Files dialog.
2. Press F1 there: CHM help will be opened.
3. Close help, then close pack dialog.
4. Try to replace %commander_path%\TOTALCMD.CHM with other TOTALCMD.CHM file:
If I do the above with TC 9.51 rc3 under Windows XP (Danish) 32bit, service pack 3, I can replace and overwrite totalcmd.chm - if I try the same with TC 9.51rc2 the totalcmd.chm file is blocked.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1625
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *DrShark »

What can I say, here on Russian 32-bit Windows XP Pro SP3 with hh.exe v. 5.2.3790.2453 and hhctrl.ocx v.5.2.3790.4110 for this case I also get Access denied error on overwrite attempt...
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
Usher
Power Member
Power Member
Posts: 888
Joined: 2011-03-11, 10:11 UTC

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Usher »

2DrShark
No problems here with replacing using copy and move for internal and external English. Windows XP SP3 Polish, the same versions of hh.exe and hhctrl.ocx. Maybe it's your antivirus…
Regards from Poland
Andrzej P. Wozniak
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: CHM Help opened with F1 from some dialogs, after closing then not released by TC, and not re opened with F1 if unloc

Post by *Flint »

2DrShark
Just in case, try checking which process blocks the file (for example, in Process Explorer).
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
Post Reply