[9.50 x32] Applying changed language -> icon in dialog title disappears

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

[9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *Flint »

1. Start 32-bit version of TC, with language set to anything non-English (e.g., German). If you have English, change the language and restart TC.
2. Go to Settings -> Language; notice that the Settings dialog has the TC icon in the titlebar. Select built-in English, click Apply.
3. The Settings dialog disappears shortly, then reapprears with changed interface language. However, the TC icon in the dialog title is no longer there.
3a. Also, when the Settings dialog reappears, its position on the screen is different (lower).

Both issues are not reproduced in the 64-bit version. Also, reinitialization of the dialog takes much longer in 32-bit, than in 64-bit. In 32-bit version, it takes about 2 seconds to show the dialog again, after I clicked Apply. The 64-version shows it almost immediately on the same system under same conditions.

Tested with 9.50 final, Win7 x64, Aero theme.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *petermad »

Confirmed for 32bit version.

Until tc90b5 the configuration dialog did not have an icon, and since tc90b5 the bug exists.
12.07.16 Fixed: Configuration dialog didn't have an icon in the title bar (32)
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 888
Joined: 2011-03-11, 10:11 UTC

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *Usher »

Flint wrote:
2020-02-06, 14:02 UTC
Also, reinitialization of the dialog takes much longer in 32-bit, than in 64-bit. In 32-bit version, it takes about 2 seconds to show the dialog again, after I clicked Apply.
When switching to internal English 32-bit TC redraws whole window with all the elements. In other cases TC redraws only changed text elements.
Regards from Poland
Andrzej P. Wozniak
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39985
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *ghisler(Author) »

I can confirm the disappearing icon. It happens because the English strings are stored within the dialog box template, so to switch to English, I have to completely close and re-open the dialog. The icons are only added when initially creating the dialog, not when recreating it. I will change it.
Also, when the Settings dialog reappears, its position on the screen is different (lower).
This seems to happen because I didn't set the same parent. I will change it too.
Also, reinitialization of the dialog takes much longer in 32-bit, than in 64-bit.
I cannot reproduce this. Does it also take longer to open the dialog via menu Configuration - Options?
Author of Total Commander
http://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *Flint »

ghisler(Author) wrote:
2020-02-07, 08:31 UTC
I cannot reproduce this. Does it also take longer to open the dialog via menu Configuration - Options?
Actually, yes, it does; I wasn't paying attention to that. On 64-bit, the dialog appears almost instantly (there is only a slight delay, about 0.1-0.2 seconds). On 32-bit, it's not less than 1-2 seconds.
I've tried it on two different machines now (both on Win7), the result is the same.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39985
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *ghisler(Author) »

Strange, it takes about 1-2 seconds here for both the 32-bit and 64-bit versions.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *petermad »

If I try om my slow Windows 10 labtop I can definitely detect that the config dialog takes longer to open in the 32bit version of TC.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 888
Joined: 2011-03-11, 10:11 UTC

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *Usher »

ghisler(Author) wrote:
2020-02-07, 10:45 UTC
Strange, it takes about 1-2 seconds here for both the 32-bit and 64-bit versions.
Look how long 32-bit TC switches languages:
- Select any external language and click "Apply" - text change is fast.
- Select another external language and click "Apply" - text change is also fast.
- Now select internal English and click "Apply" - it's slow. I can see scrollbars and toolbars redrawing after the text change.

I think it's the difference other people mean.
Regards from Poland
Andrzej P. Wozniak
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *petermad »

2Usher
I see that too, AND it is much more pronounced for the 32bit version of TC.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *StatusQuo »

ghisler(Author) wrote:
2020-02-07, 08:31 UTC
Also, reinitialization of the dialog takes much longer in 32-bit, than in 64-bit.
I cannot reproduce this. Does it also take longer to open the dialog via menu Configuration - Options?
Both confirmed, 32bit takes longer than 64bit version (about +1 second in current versions),
both for opening and for changing language to internal english.

Some test results:

TC 64bit <= 0,5 seconds (all versions),
TC 32bit:
About 1,5 seconds in TC 9.50 final, 9.22a and older,
about 1,0 second in TC 8.00 32bit and 7.5x (only slightly faster, I may be wrong here),
about 0,5 seconds in TC 7.04a and 6.51 (clearly faster than latest versions).

Win7 x64, classic theme, i7-2640M @2,8 GHz
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *petermad »

Interestinly enough - if I use this button:

Code: Select all

TOTALCMD#BAR#DATA
OPENLANGUAGEFILE

%COMMANDER_EXE%,27
English

0
-1
the shift to internal English is immediate - so it has to do with the Config dialog, not the loading of the internal language.
Last edited by petermad on 2020-02-09, 16:39 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39985
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *ghisler(Author) »

It's really strange: On Windows 10 1803, both are equally slow. On Windows 10 1809, the 64-bit version is much faster, but the 32-bit version is as slow as on Windows 10 1803. I couldn't find any logical reason for this difference.
Author of Total Commander
http://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 9848
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *petermad »

I have 3 older laptops with comparable processors with Windows XP, 7, 8.1 and 10 1909, and I see the same - Windows 8 and 10 may use 2 seconds to change to English via the Config dialog - Windows 7 maybe ½ a second and Windows XP less than that. Windows XP and 7 are on the same PC.

It is always the 32bit version that is slow.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.10 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39985
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *ghisler(Author) »

This should be fixed in 9.50a TC1, please test!
Author of Total Commander
http://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3311
Joined: 2003-10-27, 09:25 UTC
Location: Moscow, Russia
Contact:

Re: [9.50 x32] Applying changed language -> icon in dialog title disappears

Post by *Flint »

Confirm fixed both the icon and the dialog displacement in 9.50a rc1.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 9.51 / Win7 x64 SP1, Win10 x64
Post Reply