Crash when opening a second folder tab

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

Post Reply
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Crash when opening a second folder tab

Post by *Holyhead »

TC 9.5 crashes when showing folder tabs.

I can reproduce this when starting TC with /i=pathtonew.ini, closing the configuration dialogs with OK. When opening a new folder tab, the application always crashes on my PC with Windows 10, 1809.

Call stack:
comctl32.dll!Tab_OnGetItemRect(struct TC *,int,struct tagRECT *) Unknown
comctl32.dll!Tab_WndProc() Unknown
user32.dll!UserCallWinProcCheckWow() Unknown
user32.dll!CallWindowProcW() Unknown
TOTALCMD64.EXE!00000000008aa7e8() Unknown
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

I forgot: the 32 bit version works fine, only the 64 bit version crashes.

It's definitely related to my Windows installation as it runs fine on another Win 10 installations (check here with Win 10 LTSB 1607).
However folder tabs work fine with TC 9.22a 64x.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Crash when opening a second folder tab

Post by *ghisler(Author) »

NOT confirmed. Here are the tests I made:
1. Boot Windows 10 1809
2. Start Total Commander 9.50 final with the following command:
c:\totalcmd\totalcmd64.exe /i=c:\totalcmd\totalcmdnew.ini
3. Confirm main configuration dialog with OK
4. Confirm main icon library dialog with OK
5. Press Ctrl+T
-> Tab opens normally, no crash

Maybe your Windows 10 installation is damaged? Try repairing it as follows:
1. In the start menu, search for: cmd
2. Right click on the found command processor and run it as administrator
3. Run the following command in it:
DISM /Online /Cleanup-Image /CheckHealth
Author of Total Commander
http://www.ghisler.com
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

The DISM check did find any problem on my PC:
No component store corruption detected.
The operation completed successfully.
So far I did not observe any strange behavior for any other program running on this machine.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Crash when opening a second folder tab

Post by *ghisler(Author) »

I think this caused by the same reason why the menu failed in dark mode - TC is being started above 4GB in memory. I will fix it.
Author of Total Commander
http://www.ghisler.com
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

I just tested TC 9.51x64 RC2, fresh install, clean .ini: folder tabs still crash on my PC.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Crash when opening a second folder tab

Post by *ghisler(Author) »

Unfortunately I have no other ideas what could be wrong with your PC.

Just one thing you could check: Do you have the following enabled in Windows Defender:
Exploit protection - force random order for images (ASLR)? Sorry, I don't know the exact name in English.

Another thing: Do you have the option "Tabs on multiple lines" enabled or disabled in Configuration - Options - Folder tabs?
If it's disabled, please try enabling it and check if you still get the crash.
Author of Total Commander
http://www.ghisler.com
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

These are the Exploit protection System settings of my PC - the settings are enforced by IT and I cannot change them on this machine:
* Control flow guard (CFG): On by default
* Data Execution Prevention (DEP): On by default
* Force randomization for images (Mandatory ASLR): Use default (Off)
* Randomize memory allocations (Bottom-up ASLR): On by default
* High-entropy ASLR: On by default
* Validate exception chauns (SEHOP): On by default
* Validate heap integrity: On by default

VMMap from Sysinternal lists TOTALCMD64.exe as Type image, but all Windows .dll with type "Image (ASLR)"

The crash happens with "Tabs on multiple lines" on as well as off.


Just by chance: do you know https://docs.microsoft.com/en-us/security-risk-detection/concepts/application-verifier ?
I tried to start TC with Application Verifier "Basics" options set and TC crashed on startup (9.51RC2x64 as well as 9.22ax64). If Basics/Handles ("ensures your application doesn't attempt to use invalid handles") is unchecked in Application Verifier, TC starts fine.
I do not mean my note as a complaint that TC does not work inside a stress test environment like Application Verifier! From my experience, this tool is not so well known, but it helped me at least once in tracking down a problem in my application.
(No non-trivial software is bug or crash free.)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Crash when opening a second folder tab

Post by *ghisler(Author) »

What about this question:
Another thing: Do you have the option "Tabs on multiple lines" enabled or disabled in Configuration - Options - Folder tabs?
Could you try enabling "Tabs on multiple lines", and then add tabs in dark mode until there is more than one line of tabs? Do you still get crashes in this case?
Author of Total Commander
http://www.ghisler.com
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

- I cannot add any tab, neither in light mode nor in dark mode. The folder tab crash is not related to dark/light mode: Start TC with fresh .ini (confirm dialogs with OK), press Ctrl-T -> crash. The crash also happens if I enable dark mode before pressing Ctrl-T.
- As stated in my previous post, the crash happens with "Tabs on multiple lines" enabled as well as disabled.
- I started TC with default .ini settings, no tab visible (but folder tabs enabled). If I enable "Show tab headers also when there ins only one tab" and then press Apply in the dialog, TC also crashes. It does not appear as it's related to multiline/tab scroll icons.

To summarize: the folder tab control always crashes in the x64 version of TC95x on my PC.
Holyhead
Junior Member
Junior Member
Posts: 13
Joined: 2006-03-03, 20:06 UTC

Re: Crash when opening a second folder tab

Post by *Holyhead »

Update: TC 9.51 RC3 (x64) no longer shows this problem.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39969
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Crash when opening a second folder tab

Post by *ghisler(Author) »

Thanks for helping me resolve these problems!
Author of Total Commander
http://www.ghisler.com
Post Reply