(Solved) [9.51] RAR/7Z archive operations are not logged

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

(Solved) [9.51] RAR/7Z archive operations are not logged

Post by *Flint »

1. Start TC with clean INI (no packer plugins). Configure it to log file operation, make sure "Pack/Unpack/Test archives" option is turned on.
2. Unpack or test some ZIP archive, to see that logging does work.
3. Now try to unpack or test a RAR or 7Z archive.
4. No messages about unpacking or testing are added to the log file.

Tested in 9.51 x32/x64, Win7 x64.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
gdpr deleted 6
Power Member
Power Member
Posts: 872
Joined: 2013-09-04, 14:07 UTC

Re: [9.51] RAR/7Z archive operations are not logged

Post by *gdpr deleted 6 »

I can confirm with TC 9.51 x64 and x86, also on Win7 x64. (I tested with Zip, Rar, 7z archives)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *ghisler(Author) »

I will check it, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *Flint »

07.06.20 Fixed: Unpack specific files (Alt+F9): Unpacking of RAR and 7Z archives with internal unpacker wasn't logged (32/64)
10.00b1a: I confirm the fix for: unpack and test for RAR, and unpack for 7z. However, testing for 7z is still not logged.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *ghisler(Author) »

Are you using a 7z plugin?
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *Flint »

No, I tried on a clean INI, without plugins.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
gdpr deleted 6
Power Member
Power Member
Posts: 872
Joined: 2013-09-04, 14:07 UTC

Re: [9.51] RAR/7Z archive operations are not logged

Post by *gdpr deleted 6 »

I can confirm the issue. No logging for testing of 7z archives, neither with 32-bit nor 64-bit TC 10.00b1a (fresh INI used).
(Unpacking is being logged, though.)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *ghisler(Author) »

Ah, I see, I must have missed the testing part. I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [9.51] RAR/7Z archive operations are not logged

Post by *Flint »

Confirm fixed in b2.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
gdpr deleted 6
Power Member
Power Member
Posts: 872
Joined: 2013-09-04, 14:07 UTC

Re: (Solved) [9.51] RAR/7Z archive operations are not logged

Post by *gdpr deleted 6 »

I can also confirm it 7z testing now being logged in TC 10.00b2 (x86 and x64).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: (Solved) [9.51] RAR/7Z archive operations are not logged

Post by *ghisler(Author) »

Great, thanks! I also fixed a bug where it didn't log errors when unpacking, just which files it unpacked (successfully or without success).
Author of Total Commander
https://www.ghisler.com
gdpr deleted 6
Power Member
Power Member
Posts: 872
Joined: 2013-09-04, 14:07 UTC

Re: (Solved) [9.51] RAR/7Z archive operations are not logged

Post by *gdpr deleted 6 »

ghisler(Author) wrote: 2021-03-19, 16:40 UTC Great, thanks! I also fixed a bug where it didn't log errors when unpacking, just which files it unpacked (successfully or without success).
Ah, okay. I just tested this as well, and it looks good.
There is still room for improvement, in case you want to take a look at it. If you don't, i am fine with the current behavior, too. :-)
Currently, the log message only indicates at which file it encountered an error, but it does not indicate that unpacking/testing has been completely aborted with regard to 7z archives.

(During these tests i found TC's 7z routine differ from the official 7-zip utility. If 7-zip can't keep unpacking a solid block due to an error, it still tries to unpack the files in subsequent solid blocks. In contrast, if TC encounters a corrupted solid block, it completely aborts and does not try unpacking any subsequent blocks. Thus, given a 7-zip archive that has more than one solid blocks where one/some of the first solid blocks are corrupted, 7-zip is able to unpack more files than TC from such a corrupted archive. I guess i will put this in a suggestion topic, in case you want to take a shot at it in the future...)
Post Reply