[UX] Compare by content: current line is not marked, when focus in 2-lines area

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Flint »

If you work primarily from keyboard, you may find yourself in the following situation:
1. Open Compare by content.
2. Press Down several times to put focus on some line.
3. Press Ctrl+Tab to set focus into the 2-lines area.
4. Now you cannot see which pair of lines is chosen for comparison, because only selection is visible in the main panels, and it's still set on the first line. The compared lines are defined by the focus, but the focus border is not displayed.

Maybe TC should use the InactiveFocus-like feature here?
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

Support++
When you switch from a panel to another one, there are two lines identically marked as selection. You have to guess which line is active in comparison area.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *ghisler(Author) »

You can see the line numbers in all 3 windows (as long as you don't scroll). It would be strange if the line suddenly got selected in edit mode.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

2ghisler(Author)
But we do scroll. And the position of the comparison area stay unchanged when I click another line so I can't see new line numbers.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Flint »

Besides, having to read the numbers and search for the same numbers in the panel is much more tedious, than just seeing any visual marking directly on the line.It could be a different background, or a light-grey border (so that it was different from the black focus border)…
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *ghisler(Author) »

I'm moving this to fixed bugs because I have added the function in the meantime.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

There are still problems.
Steps to reproduce:
1. Click panels with displayed files to select lines for comparison. Both lines will be highglighted in the same way.
2. Click 2-lines area and observe changes. It will be highlighted a line number from the last active panel there. The same number in that panel now may be invisible - displayed in white-on-white. The 2-lines area is scrolled together with line numbers so now only one number stays visible. In some cases you can guess the missing number, but it's annoying. See this picture: https://1drv.ms/u/s!Aqm4ZaWdL2tfgkuiz_MyxpwW2rgY?e=Nhm7UU
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *ghisler(Author) »

Sorry, I do not understand your report. What exactly should be invisible in your screenshot?
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

2ghisler(Author)
All line numbers should be VISIBLE. They aren't, see the areas in red rectangles on the new screenshot:
https://1drv.ms/u/s!AKm4ZaWdL2tfgkw
https://1drv.ms/u/s!Aqm4ZaWdL2tfgkxGsq7SOHHg6O05?e=LCQJB1

1. Line selected in the top panel. You can see its number: 2871.
2. Line selected in the bottom panel. You can't see its number. In this case you have to guess that it's 548.
3. Both lines in 2-line area - there are NO visible line numbers when scrolling. You have to look for them in other places.
Last edited by Usher on 2021-04-17, 01:24 UTC, edited 1 time in total.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Hacker »

Usher,
Your screenshot link gives me an error.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

2Hacker
You have to wait a moment while your browser executes megabytes of javascript code. I can see the picture in Firefox 52.9 and I don't think you are using any older browser. Maybe you should change adblock settings?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Hacker »

Usher,
This is what I am getting both in Firefox and in Vivaldi - https://postimg.cc/mhgWgBfB
¯\_(ツ)_/¯

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Usher »

Something seems to be blocked by your internet security suite or your internet provider. Try another link.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Hacker
Moderator
Moderator
Posts: 13052
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *Hacker »

Usher,
Your second link works fine, thanks :wink:

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [UX] Compare by content: current line is not marked, when focus in 2-lines area

Post by *petermad »

All line numbers should be VISIBLE. They aren't, see the areas in red rectangles on the new screenshot:
That is the same problem I describe here: viewtopic.php?p=399688#p399688
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply