Solved [TC 10b3,4] New player - speed change doesn't work properly

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

The second problem isn't fixed yet: viewtopic.php?p=399899#p399383
Nothing changed.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *petermad »

I can now change the speed of the sample file https://1drv.ms/u/s!AKm4ZaWdL2tfgko in TC 10 b5 32bit under Windows XP sp3 32bit :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

2petermad
Nice to hear that!

2Usher
I have tried it now - I do not get a crash when I change audio stream in your test file, neither on Windows XP nor Windows 10. I'm using the LAV filters version 0.70.2.0. What are you using?
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b6] New player - audio stream change doesn't work properly

Post by *Usher »

2ghisler(Author)
The TV stream is NOT crashing. I can't switch audio stream properly from mp2 to eac3 even without any speed change. Once again:
When I right click the video and change audio to eac3, the playback freezes with black screen. When I click play button, the video playback is horribly slow and without deinterlacing. The eac3 sound isn't played.
However, now I can go back to mp2 stream with no problems, and file doesn't stay locked on Lister close.

I'm using LAV filters version 0.70.2.1-git provided with MPC-HC 1.7.13.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b6] New player - speed change doesn't work properly

Post by *Usher »

Well, it seems that I've found the solution. It's a problem with LAV Splitter settings. When you have problems with audio stream switching or unloading, make sure you have checked "Remove Audio Decoder on Audio Stream Switch" option in LAV Splitter settings. I will do some more tests with different settings…
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

Strange, this option wasn't checked here and it still works...
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

2ghisler(Author)
There may be other options which give similar results, I cannot find them so far.

Some options may work only when you reload TC (or even the whole system) to fully restart filters. However, it's only half of success. When I check that option, I can switch audio streams, but AutoPitch.dll is also unloaded on stream switch and I lose pitch control on speed change.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

I don't know what's wrong on your system that it doesn't work, but I will try to add some extra checks to AutoPitch.dll to detect an audio format change. Normally Windows would disconnect the filter and reconnect it with the new format in such a case.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

Confirm fixed it TC10 beta7
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Solved [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

Indeed I'm detecting an audio format change now! It wasn't documented anywhere I looked, and the Microsoft samples didn't implement it either, but I found it more or less by chance by looking at the various fields passed to the audio filter.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Solved [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

2ghisler(Author)
Thanks for the explanation. Now the player switches audio streams immediately with no delay.

@all
As a side note: LAV Audio Filter in version 0.70.x may not detect AC3 stream sound properly (note - it's AC3, not EAC3). In this case users need to uncheck AC3 on the list of supported audio formats in LAV Audio filter settings (not in LAV splitter).
Player should use MPC Audio decoder in this case, so users should ensure that AC3 support is turned on for this decoder.

I haven't tested newer LAV filters yet.
Andrzej P. Wozniak
Polish subforum moderator
Post Reply