Solved [TC 10b3,4] New player - speed change doesn't work properly

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Solved [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

Open any mp4 video file and try to change playback speed pressing any of -,1x,+ buttons. The speed remains unchanged whatever you are trying to set - just 1x changes to 1.0. Now close the player and you will see that LAVfilters stay loaded. You may have to press Esc a few times, depending on the count of clicks when trying to change playback speed. You may even hear the sound still playing. The simplest way way to close filters is to close TC.
Tested in Windows XP.
Last edited by Usher on 2021-04-22, 17:54 UTC, edited 2 times in total.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10b3] New player - speed change doesn't work properly

Post by *petermad »

It works fine here in TC 10 b3 32bit and 64bit testet under Windows 7, Windows 10 AND Windows XP (32bit).

Don't you get a little horizontal list of preset speeds when you click on "1x" ?

Haow much did you try to chnage the speed? - I don't really notice it until I increase it to 1.5 or more.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3] New player - speed change doesn't work properly

Post by *Usher »

It seems to be more complicated.

I have numbers from 0.5 to 1.5 visible on speed list.

1. Player plays OK for system default filters, but nothing works for playback speed - it always switches from 1x to 1.0. Context menu disappears. Filters don't unload on Player close.
2. When I change filters from "System default" to "Recommended", the playback speed switches to selected speed and that's all. Nothing plays, the playback just freezes. Context menu still works. Filters unload on Player close.

What filters do you use in XP?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10b3] New player - speed change doesn't work properly

Post by *petermad »

2Usher
What filters do you use in XP?
I use the LAV filters that came with the last version of MPC-HC player from 2017 - that is version 0.70.2

It doesn't work for me under Windows XP with the the 0.75 filters from https://github.com/Nevcairiel/LAVFilters/releases/tag/0.75

The older 0.70.2 filters can be downloaded here: https://github.com/Nevcairiel/LAVFilters/releases/tag/0.70.2
Last edited by petermad on 2021-04-01, 19:49 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3] New player - speed change doesn't work properly

Post by *ghisler(Author) »

Apparently not all filters support different playback speeds.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3] New player - speed change doesn't work properly

Post by *Usher »

2petermad
I use the same filters, but my filters come from MPC-HC. I didn't install the Nevcairiel build.

2ghisler(Author)
But why do the same filters behave in other way depending on internal player config?
Why does the player go so strange? It either doesn't unload filters or freezes playback.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

In TC 10b4 speed change seems to work better, but still not as good as it should. For some files it works OK, for other ones it may even crash TC. I will do more tests and report them later.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *petermad »

I use the same filters, but my filters come from MPC-HC. I didn't install the Nevcairiel build.
I have tried both builds - they both work for me on Windows XP sp3 32bit. My Windows XP installation is very "clean", I didn't have any 3'rd party filters installed, before i installed the LAV filters from MPC-HC.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

The internal player running with recommended filters now freezes for mp4 and mkv when audio stream in eac3 is played.
I haven't searched for other files with eac3 audio stream yet.
And I haven't tested unloading filters for internal player running with default system filters.
Last edited by Usher on 2021-04-02, 15:33 UTC, edited 1 time in total.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

About the playback speed issue: It could be related to my pitch correction filter. It can handle both floating point audio (mostly from aac, ac3 etc) and integer audio (e.g. from mp2, mp3), both with multiple channels. But it's possible that your file contains a track which it can't handle.

Please try this:
1. Rename AutoPitch.dll to AutoPitch.org (in directory filter64 for 64-bit, filter32 for 32-bit)
2. Close and re-open Total Commander
3. Try changing the speed now.

If it works but changes in pitch, then it's a problem with this filter. I will need a short sample (a few seconds) of your file to test this.
If it doesn't work, then it's a problem with one of the used DirectShow filters.
Author of Total Commander
https://www.ghisler.com
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

ghisler(Author) wrote: 2021-04-02, 06:24 UTCIf it works but changes in pitch, then it's a problem with this filter. I will need a short sample (a few seconds) of your file to test this.
It seems to be that case.
I suspect that you have such video files on your disk. One of them seems to be provided with Windows 10:

Code: Select all

"c:\Program Files\WindowsApps\DolbyLaboratories.DolbyAccess_3.0.1116.0_x64__rz1tebttyb220\Assets\OfflineContent\Videos\master-1080p-signaled12.mp4"
I uploaded it here: https://1drv.ms/f/s!AKm4ZaWdL2tfgkg
It's 32 MB in size, other files in my case are 10-100x larger (recording from DVB-T tuner, hand-made mkv files with subtitles added, etc.)

You can find such files with the help of some mediainfo wdx, audio format is "E-AC-3". Files may have many extensions: *.mkv *.mp4 *.ts *.mpg *.mpeg *.mpe or similar.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *Usher »

Player works OK without AutoPitch.dll also when configured to use system default filters. Filters unload on close, changing speed works (with pitch changed as expected).

However, in both cases there is another problem for files which have more audio streams.
I uploaded another sample here: https://1drv.ms/u/s!AKm4ZaWdL2tfgko
It's also 32 MB file, this time simply splitted from DVB-T stream. It has two audio streams - default in mp2 and aux in eac3. You can start playback and change speed now, but when you right click the video and change audio to eac3, the playback freezes with black screen. When you click play button, the video playback is horribly slow and without deinterlacing. The same file plays OK in MPC-HC which uses the same filters.

EDIT: I was too fast and sent unfinished message. After changing audio stream to eac3 the sound doesn't play, and Lister doesn't unlock video file on close. I had to restart TC to delete the file.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *petermad »

I can confirm that TC cannot change the speed of the sample file https://1drv.ms/f/s!AKm4ZaWdL2tfgkg under Windows XP 32bit. The playback simply stops when I change the speed and can only be started again by reloading the mp4 file.

I have no such problems with the file under Windows 7, 8.1 and 10
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

Thanks for the sample files, this will help me a lot to find the problem. If I can't fix it, I will disable the pitch change for these audio types.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10b3,4] New player - speed change doesn't work properly

Post by *ghisler(Author) »

This should be fixed in beta 5, please test it! The problem happens on Windows XP only, because it passes the data as 24-bit integer values to my filter, which it could not handle. I have added that now to beta 5.
Author of Total Commander
https://www.ghisler.com
Post Reply