Solved [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *petermad »

history.txt wrote:15.03.21 Added: Support parameters 0=toggle, 1=set, 2(or -1)=reset also for: cm_SrcQuickview, cm_LeftQuickview, cm_RightQuickview, cm_SrcQuickInternalOnly, cm_LeftQuickInternalOnly, cm_RightQuickInternalOnly, cm_SeparateQuickview, cm_SeparateQuickInternalOnly (32/64)

21.10.20 Added: Support parameters 0=toggle, 1=set, 2(or -1)=reset for: cm_*Comments, cm_*DirBranch, cm_*DirBranchSel, cm_ToggleAutoViewModeSwitch, cm_SyncChangeDir, cm_SwitchLongNames, cm_SwitchHidSys, cm_SwitchHid, cm_SwitchSys, cm_Switch83Names, cm_FtpHiddenFiles, cm_SwitchDirSort, cm_SwitchOverlayIcons, cm_SwitchWatchDirs, cm_SwitchIgnoreList, cm_SwitchX64Redirection, cm_Vis* (32/64)
I just tried some of the cm_*Quickview* commands (cm_SrcQuickview, cm_LeftQuickview, cm_RightQuickview, cm_SrcQuickInternalOnly and cm_SeparateQuickview) with parameters 1 or 2 - they work fine if I use the command as the only command, but if I use the QuickView commands in combination with other cm_ or em_commands I get the error message "Function not implemented!" and the command toggles QuickView as if no parameter was used.

The same applies to cm_FtpHiddenFiles and all the cm_Vis* (cm_VisButtonbar, cm_VisDriveButtons, cm_VisFlatDriveButtons etc.) commands - they also doesn't work correctly with parameters if combined with other commands. For parameter 1 and 2 I get a "Function not implemented!" message and for parameter 0 I get a "File not found!" message and the command toggles as if no parameter was used.

Examples:
This button works fine:

Code: Select all

TOTALCMD#BAR#DATA
cm_GoToFirstFile,cm_SrcQuickview

WCMICONS.DLL,22
Test


-1

Wheras this button:

Code: Select all

TOTALCMD#BAR#DATA
cm_GoToFirstFile,cm_SrcQuickview 1

WCMICONS.DLL,22
Test


-1
gives the error: "Function not implemented!" and just toggles QuickView as the first button does.


This button

Code: Select all

TOTALCMD#BAR#DATA
cm_SrcQuickview 1

WCMICONS.DLL,22
Test


-1
correctly only turns QuickView ON as it should.

It doesn't matter whether the affected commands with parameter is used first or last when combined with other commands.
Last edited by petermad on 2021-04-15, 22:24 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *petermad »

Partly fixed in TC 10 b5.

It still doesn't work with combined commands and cm_SrcQuickInternalOnly, cm_LeftQuickInternalOnly, cm_RightQuickInternalOnly and cm_SeparateQuickInternalOnly :(

It also still doesn't work for combined commands and cm_VisButtonbar2, cm_VisDirTabs, cm_VisBreadCrumbs, cm_VisHistHotButtons and cm_VisXPThemeBackground :(
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *ghisler(Author) »

Thanks, looks like I missed some. Here is the entire list now AFTER your corrections:

Code: Select all

  'CM_LIST ','CM_WAIT ','CM_SELECT ','CM_UNSELECT ','CM_REVERSE ','CM_GOTOFIRSTENTRY ',
   'CM_GOTOFIRSTFILE ','CM_LEFTSWITCHTOTHISCUSTOMVIEW ','CM_SEARCHFORINCURDIR ',
   'CM_RIGHTSWITCHTOTHISCUSTOMVIEW ',
   'CM_VERTICALPANELS ',
   'CM_LEFTOPENDRIVES ','CM_RIGHTOPENDRIVES ','CM_SRCOPENDRIVES ',
   'CM_LEFTTHUMBS ','CM_RIGHTTHUMBS ','CM_SRCTHUMBS ',
   'CM_LEFTBYNAME ','CM_RIGHTBYNAME ','CM_SRCBYNAME ',
   'CM_LEFTBYEXT ','CM_RIGHTBYEXT ','CM_SRCBYEXT ',
   'CM_LEFTBYSIZE ','CM_RIGHTBYSIZE ','CM_SRCBYSIZE ',
   'CM_LEFTBYDATETIME ','CM_RIGHTBYDATETIME ','CM_SRCBYDATETIME ',
   'CM_LEFTNEGORDER ','CM_RIGHTNEGORDER ','CM_SRCNEGORDER ',
   'CM_100PERCENT ',
   'CM_SRCVIEWMODELIST ','CM_LEFTVIEWMODELIST ','CM_RIGHTVIEWMODELIST ',
   'CM_REREADSOURCE ',
   'CM_LEFTCOMMENTS ','CM_RIGHTCOMMENTS ','CM_SRCCOMMENTS ',
   'CM_DIRBRANCH ','CM_LEFTDIRBRANCH ','CM_RIGHTDIRBRANCH ',
   'CM_DIRBRANCHSEL ','CM_LEFTDIRBRANCHSEL ','CM_RIGHTDIRBRANCHSEL ',
   'CM_TOGGLEAUTOVIEWMODESWITCH ','CM_SYNCCHANGEDIR ','CM_SWITCHLONGNAMES ',
   'CM_SWITCHHIDSYS ','CM_SWITCHHID ','CM_SWITCHSYS ',
   'CM_SWITCH83NAMES ','CM_SWITCHDIRSORT ','CM_SWITCHOVERLAYICONS ',
   'CM_SWITCHWATCHDIRS ','CM_SWITCHIGNORELIST ','CM_SWITCHX64REDIRECTION ',
   'CM_SRCQUICKVIEW ','CM_LEFTQUICKVIEW ','CM_RIGHTQUICKVIEW ',
   'CM_SRCQUICKINTERNALONLY ','CM_LEFTQUICKINTERNALONLY ','CM_RIGHTQUICKINTERNALONLY ',
   'CM_SEPARATEQUICKVIEW ','CM_SEPARATEQUICKINTERNALONLY ',
   'CM_SRCCOMMENTS ','CM_LEFTCOMMENTS ','CM_RIGHTCOMMENTS ',
   'CM_SRCDIRBRANCH ','CM_LEFTDIRBRANCH ','CM_RIGHTDIRBRANCH ',
   'CM_SRCDIRBRANCHSEL ','CM_LEFTDIRBRANCHSEL ','CM_RIGHTDIRBRANCHSEL ',
   'CM_TOGGLEAUTOVIEWMODESWITCH ', 'CM_SYNCCHANGEDIR ', 'CM_SWITCHLONGNAMES ',
   'CM_SWITCHHIDSYS ', 'CM_SWITCHHID ', 'CM_SWITCHSYS ', 'CM_SWITCH83NAMES ', 'CM_FTPHIDDENFILES ', 'CM_SWITCHDIRSORT ',
   'CM_SWITCHOVERLAYICONS ', 'CM_SWITCHWATCHDIRS ', 'CM_SWITCHIGNORELIST ', 'CM_SWITCHX64REDIRECTION ',
   'CM_VISBUTTONBAR ','CM_VISDRIVEBUTTONS ','CM_VISTWODRIVEBUTTONS ','CM_VISFLATDRIVEBUTTONS ','CM_VISFLATINTERFACE ','CM_VISDRIVECOMBO ',
   'CM_VISCURDIR ','CM_VISTABHEADER ','CM_VISSTATUSBAR ','CM_VISCMDLINE ','CM_VISKEYBUTTONS ',
   'CM_VISBUTTONBAR2 ','CM_VISDIRTABS ','CM_VISBREADCRUMBS ','CM_VISHISTHOTBUTTONS ','CM_VISXPTHEMEBACKGROUND  '
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *petermad »

I never thought of CM_100PERCENT.

You have several commands twice in your list here above, but better safe than sorry :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *ghisler(Author) »

Which ones are twice?
Author of Total Commander
https://www.ghisler.com
User avatar
tuska
Power Member
Power Member
Posts: 3740
Joined: 2007-05-21, 12:17 UTC

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *tuska »

ghisler(Author) wrote: 2021-04-12, 13:12 UTC Which ones are twice?
If one lists the commands in an Excel file,
then the following commands are duplicated in the list:

Code: Select all

CM_LEFTCOMMENTS
CM_LEFTDIRBRANCH
CM_LEFTDIRBRANCHSEL
CM_RIGHTCOMMENTS
CM_RIGHTDIRBRANCH
CM_RIGHTDIRBRANCHSEL
CM_SRCCOMMENTS
CM_SWITCH83NAMES
CM_SWITCHDIRSORT
CM_SWITCHHID
CM_SWITCHHIDSYS
CM_SWITCHIGNORELIST
CM_SWITCHLONGNAMES
CM_SWITCHOVERLAYICONS
CM_SWITCHSYS
CM_SWITCHWATCHDIRS
CM_SWITCHX64REDIRECTION
CM_SYNCCHANGEDIR
CM_TOGGLEAUTOVIEWMODESWITCH
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b4] Some internal commands doesn't work with parameters when combined with other commands

Post by *petermad »

history.txt wrote:09.04.21 Fixed: Some more parameters for internal commands like cm_SrcQuickInternalOnly still could only be used separately, not together with other commands (32/64)
Confirmed that all the em_commands listed here viewtopic.php?p=399674#p399674 now also works in TC 10 b6 when combined with other commands :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply