Solved [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *petermad »

For example does these 3 commands all work:

Code: Select all

[em_my_loadselection1
cmd=LOADSELECTION c:\total commander\SAVEDSELECTION.txt

[em_my_loadselection2]
cmd=LOADSELECTION
param=c:\total commander\SAVEDSELECTION.txt

[em_my_loadselection3]
cmd=LOADSELECTION
param="c:\total commander\SAVEDSELECTION.txt"
But this one does NOT work:

Code: Select all

[em_my_loadselection4]
cmd=LOADSELECTION "c:\total commander\SAVEDSELECTION.txt"
These commands all does NOT work with quotation marks around the file name in the Command field:
SAVETABS*, SAVETABS2*, OPENLANGUAGEFILE, LOADSELECTION

These commands DOES work with quotaion marks:
LOADLIST, OPENTABS*, APPENDTABS*, OPENBAR*, SAVESELECTION*, SAVEDETAILS*

For consistency it would be nice if all these commands worked with quotation marks.

Notice that ALL these commands work with quotation marks if the filename is placed in the Parameters field.
Last edited by petermad on 2021-05-13, 19:45 UTC, edited 3 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *ghisler(Author) »

Confirmed, I will add it to beta 9.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *petermad »

petermad wrote:These commands all does NOT work with quotation marks around the file name in the Command field:
SAVETABS*, SAVETABS2*, OPENLANGUAGEFILE, LOADSELECTION
I can confirm that these command now also works with quotation marks around the file name in the Command field in TC 10 b9 :-)

history.txt wrote:06.05.01 Fixed: The following commands didn't support double quotes in the path directly in the command field: OPENTABS, OPENTABSL, OPENTABSR, APPENDTABS, APPENDTABSL, APPENDTABSR, SAVETABS, SAVETABSL, SAVETABSR, SAVETABS2, SAVETABS2L, SAVETABS2R, SELECTFILES, SAVESELECTION (32/64)
OPENLANGUAGEFILE and LOADSELECTION is not mentioned in this list, even though it is fixed for those commands in beta9.

According to my previous test it already worked in beta8 for: LOADLIST, OPENTABS*, APPENDTABS*, OPENBAR*, SAVESELECTION*, SAVEDETAILS* - I hadn't testet SELECTFILES, but have now and that also worked in beta8.

So the history.txt line should be changed to:
history.txt wrote:06.05.01 Fixed: The following commands didn't support double quotes in the path directly in the command field: SAVETABS, SAVETABSL, SAVETABSR, SAVETABS2, SAVETABS2L, SAVETABS2R, LOADSELECTION and OPENLANGUAGEFILE (32/64)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *ghisler(Author) »

You are right, it should be LOADSELECTION instead of SAVESELECTION, that already worked.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *petermad »

Yes, and OPENTABS, OPENTABSL, OPENTABSR, APPENDTABS, APPENDTABSL, APPENDTABSR also already worked
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *ghisler(Author) »

Strange, I have added code when calling these functions too. They probably handled it already internally.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 10 b8] Some "commands with parameters" does not accept quotation marks in command field

Post by *petermad »

history.txt wrote:06.05.01 Fixed: The following commands didn't support double quotes in the path directly in the command field: SAVETABS, SAVETABSL, SAVETABSR, SAVETABS2, SAVETABS2L, SAVETABS2R, SELECTFILES, LOADSELECTION and OPENLANGUAGEFILE (32/64)
History.txt confirmed corrected in TC 10 b10 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply