Extra window when comparing files

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Extra window when comparing files

Post by *Sektor »

When I try to compare files (F5 -> More Options -> Compare), I get this weird dialog box: Image: https://1drv.ms/u/s!AvqfUD6Rp0UCoTafPIrYmYoM2x-2?e=oFoeh2
License #299429
There is no knowledge that is not power
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Extra window when comparing files

Post by *ghisler(Author) »

Not confirmed, I need more information.
Author of Total Commander
https://www.ghisler.com
User avatar
Dalai
Power Member
Power Member
Posts: 9364
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Re: Extra window when comparing files

Post by *Dalai »

Just a guess: You have some other modal dialog open in the background, e.g. Lister search window. If it's true what this dialog says, it should point you to the right dialog when confirming it with OK.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

@ghisler Which information do you need?
@Dalai No. No dialogs or other TC instances were opened at that moment.
License #299429
There is no knowledge that is not power
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

@ghisler If you need, I can share my screen.
License #299429
There is no knowledge that is not power
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Extra window when comparing files

Post by *ghisler(Author) »

2Sektor
This error should only happen when you have other modal dialogs open, e.g. in a Lister or compare by content window.

Which tool do you use for sharing your screen?

Edit: I can only provoke this by creating an extra window, e.g. like this:
1. Take two large >500MB files a and b
2. Copy b from left to right
3. Select a and b so a will be copied before b
4. Press F5 to start copying
5. While a is copying, press "background"
6. When the overwrite dialog comes up, switch back to TC
7. Open any modal dialog, e.g. main settings or F5 copy or similar
8. Now go back to the overwrite confirmation dialog and choose More Options - Compare
So when I click on OK now, it will switch to the dialog I opened in step 7

What happens when you click OK in that dialog, where does the focus go to?
Author of Total Commander
https://www.ghisler.com
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

@ghisler
What I do:
1) Make sure any instance of TC is closed (for instance, in Process Expolorer)
2) Open TC as regular user
3) Copy file of any size from left to right
4) Then copy that file from right to left (or again from left to right - it doesn't matter)
5) In dialog window I choose More Options -> Compare
6) Boom! First "Compare contents" appears and above it - "WARNING!" dialog window (it appears modeless)
License #299429
There is no knowledge that is not power
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

@ghisler I want to add that these "WARNING!" dialog windows remain for the TC's lifetime if they're not closed. So I can "generate" as many these windows as I want. )))) Same happens in admin mode.
License #299429
There is no knowledge that is not power
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Extra window when comparing files

Post by *petermad »

If I do:
1) Make sure any instance of TC is closed (for instance, in Process Expolorer)
2) Open TC as regular user
3) Copy file of any size from left to right
4) Then copy that file from right to left (or again from left to right - it doesn't matter)
5) In dialog window I choose More Options -> Compare
Then I just get a dialog box telling me: "The two files have the same content!" as expected.

Does this also happen if you use a fresh ini file?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Extra window when comparing files

Post by *ghisler(Author) »

2Sektor
Edit:
I was able to reproduce it now, it only happens in dark mode. It was happening because choosing "Compare" set a modal result for the dialog, so it looked to TC as if the overwrite dialog should be closed before the "The files are equal" dialog. I will fix it.
Author of Total Commander
https://www.ghisler.com
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

@ghisler Thanks! 😎 P.S. Yes, I have dark mode.
License #299429
There is no knowledge that is not power
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Extra window when comparing files

Post by *petermad »

When switching to Dark mode, I can now also confirm the bug.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Extra window when comparing files

Post by *petermad »

history.txt wrote:27.05.21 Fixed: Warning about modal dialog was shown in dark mode, F5 copy, click on "More options" -> "Compare" in overwrite dialog (32/64)
Confirmed fixed in TC 10 rc2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Sektor
Member
Member
Posts: 157
Joined: 2007-04-04, 10:11 UTC
Location: Russia

Re: Extra window when comparing files

Post by *Sektor »

Fix is confirmed for TC 10 RC2 😎
License #299429
There is no knowledge that is not power
Post Reply