Unusual behavior in Change Attributes dialog

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, seems like the file system itself is rounding it up - TC just uses SetFileTimes with the indicated date and 23:59:59 for the time.
Author of Total Commander
https://www.ghisler.com
User avatar
sqa_wizard
Power Member
Power Member
Posts: 3854
Joined: 2003-02-06, 11:41 UTC
Location: Germany

Post by *sqa_wizard »

If it is a Windows call that does the up-rounding
AFAIK you can set the seconds to even values only on FAT drives.
Wikipedia wrote: https://en.wikipedia.org/wiki/File_Allocation_Table
Date resolution
2 seconds for last modified time,
10 ms for creation time,
1 day for access date,
2 seconds for deletion time
#5767 Personal license
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2sqa_wizard
drives
AFAIK you can set the seconds to even values only on FAT drives.
That's why I wrote
Then comes the question about the time 23:59:59 on FAT drives...
in my previous post
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Post by *Usher »

Three notes
1. Time 23:59:60 may be valid when a leap second is added, see: https://en.wikipedia.org/wiki/Leap_second

2. Older TC versions allowed to change date only when there was a placeholder (template) hh:mm:ss for time kept, f.e. change date to 2018-05-11 hh:mm:ss. Current beta doesn't allow such usage.
It would be good to keep the old behaviour and it would be even better to enhance it for date placeholder or even for partial placeholders. For example (iso format):
- Change time only to version number:
yyyy-mm-dd 09:20:04
- Change month and day to version number:
yyyy-09-20 hh:mm:ss
- Change only hour to 18:
yyyy-mm-dd 18:mm:ss
etc.

3. Multi-Rename Tool allows to use counter in a file name or extension. What about counter in date/time stamp?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Usher wrote:1. Time 23:59:60 may be valid when a leap second is added, see: https://en.wikipedia.org/wiki/Leap_second
Clever notice :) However, I just found that Windows does not support leap second: https://support.microsoft.com/en-us/help/2722715/support-for-the-leap-second

Usher wrote:2. Older TC versions allowed to change date only when there was a placeholder (template) hh:mm:ss for time kept, f.e. change date to 2018-05-11 hh:mm:ss. Current beta doesn't allow such usage.
But currently you can leave empty Date or Time field, so it won't be changed. As for me - it's even better.[/quote]


Regards
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Date/time ranges are verified correctly now, according to my tests.


One small issue left: some space characters are allowed after the date/time string, but are not allowed before these strings.

Could you please trim these strings also from the right side?

Regards
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

It would be good to keep the old behaviour and it would be even better to enhance it for date placeholder or even for partial placeholders.
Support+++
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

But currently you can leave empty Date or Time field, so it won't be changed
Yes, but now you have to actively delete dd-MM-yyyy or hh.mm.ss to keep date or time untouched, before you could just leave the full placeholders - it really breaks routines from earlier :-(
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2. Older TC versions allowed to change date only when there was a placeholder (template) hh:mm:ss for time kept, f.e. change date to 2018-05-11 hh:mm:ss. Current beta doesn't allow such usage.
OK, I will add that - when the user leaves the placeholders unchanged, TC will not complain and ignore the value.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, in beta 5, the unchanged placeholders should be ignored now!
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

There is a problem with placeholders.

TC 32-bit: select any two files and/or directories, launch Change Attributes dialog -> placeholders are displayed in Date and Time fields

TC 64-bit: select any two files and/or directories, launch Change Attributes dialog -> placeholders are NOT displayed in Date and Time fields - these fields are empty
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2MarcinW
Try and restart your 64bit TC, then the placeholders are shown - but once the fields has been blanked (for example after faulty input) it stays blank until TC restarts.

I can confirn that unchanged placeholders in both date and time files are ignored (and kept) in TC 9.20b5 both 32bit and 64 bit :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Post by *Usher »

ghisler(Author) wrote:OK, in beta 5, the unchanged placeholders should be ignored now!
It should work also when date/time stamp is changed back to placeholder, because TC caches the last input for selected files/dirs.
Andrzej P. Wozniak
Polish subforum moderator
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

It should work also when date/time stamp is changed back to placeholder,
I agree, and it doesn't in TC 9.20b5, if I manually reinsert the placeholder.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The input is remembered only when it is valid. Empty fields are also considered as valid.
Author of Total Commander
https://www.ghisler.com
Post Reply