can't send usercmd with param in button and directory menu

[dindog]

TC will prompt error when try to input a usercmd with param:

Code: Select all

; internal CD can have param like "c:"
CD c:\ 
; while usercmd can't
; [em_cd]
; cmd=cd
; param=%A
em_cd c:\
;prompt "File not found. \n em_cd c:\"

em_cd c:\ works fine in TC's commandline and also tcfs2 by

Code: Select all

tcfs2 /ef "tem(`em_cd c:\`)"

[ghisler(Author)]

User commands with parameters are NOT supported when coming from outside of TC, for security reasons.

[dindog]

User commands with parameters are NOT supported when coming from outside of TC, for security reasons.

What do you mean outside? TC's own button and directory menu command is outside?

And the current situation is, an outside tools tcfs2 can send em_usercmd to TC properly just the same as I input in the TC's own commandline, but not working in TC's own command line of button and hotlist... I don't see the logic

[petermad]

I don't see the logic

Neither do I.

[ghisler(Author)]

The problem in the button bar is that you can have multiple commands separated by comma, and the parameter behind em_cd could also contain a comma (they are allowed in paths).

[petermad]

So, it is not really a security problem, but a syntax problem.

[Stefan2]

How about to separate multiple commands as alternative by pipe | too additionally to by comma separator?
So people who have a comma in paths can use a pipe instead, and all others too, and comma is only there for backward compatibility.




 

[dindog]

How about to separate multiple commands as alternative by pipe | too additionally to by comma separator?
So people who have a comma in paths can use a pipe instead, and all others too, and comma is only there for backward compatibility.

pipe can be a parameter for some command too, I think a solution to solve it for long is multi-commnad input box for mulit-commnad,
it can be a button at the current command input "add sequence command", then you can input the second line command for the 2nd command, and one more click will add 3rd commnad, and so on.

Or a check-box for "multi-command", when it's checked, the commandline input can be expand as a mulit-line textbox which can seperate different commands by different line.

Any solution above will allow both mulit command sequence and command parameters at the same time... I think this will greatly enhance the TC inside functionality

[petermad]

I think a solution to solve it for long is multi-commnad input box for mulit-commnad,
it can be a button at the current command input "add sequence command", then you can input the second line command for the 2nd command, and one more click will add 3rd commnad, and so on.

Or a check-box for "multi-command", when it's checked, the commandline input can be expand as a mulit-line textbox which can seperate different commands by different line.

Multicommands are not just used in Buttons, they are for exampel also allowed in View Modes as autorun commands, wgere there is no space for such an elaborate approach.

Maybe just make it so that parameter behind em_command should be quoted if they contain a comma (em_cd "c:\my,file.ext") - TC should accept double quotes in case the parameter is already quoted.

[dindog]

I find one more place can not send em_command param...The autorun-command in View Mode. If I access one of the view mode and want it come with filter, I can user

Code: Select all

[em_cdDWG]
cmd=cd
param=*.*|*.bak *.dwl *.dwl2

but not

Code: Select all

[em_cd]
cmd=cd
param=%A

em_cd *.*|*.bak *.dwl2

[ghisler(Author)]

This is indeed not supported, sorry.