Retry delete folder fails if running exe in it skipped but then closed

[DrShark]

To reproduce:
1. Put executable in empty folder and launch it.
2. Try to delete the folder with Shift+Del:
a warning that directory is not empty will appear.
3. Press "Delete" in that "not empty!" warning:
"Please remove the write protection!" dialog will appear.
4. Press "Skip" in "Please remove the write protection!" dialog:
"The following files/folders could not be deleted" will appear.
5. Close application started in step 1.
6. Press "Retry" button in "The following files/folders could not be deleted" dialog:
folder will not be deleted, instead "The following files/folders could not be deleted" will be re-opened again.
User will have to press Cancel there which will skip deleting that folder to continue operation.

Expected behavior: in step 6 TC on "Retry" should again show "not empty!" warning dialog from step 2.
If in step 3 user pressed "All" in not empty warning instead of "Delete", in step 6 on pressing "Retry" it should try to delete folder without warnings.

[petermad]

I can confirm the behaviour.

[ghisler(Author)]

Sorry but this is by design: Once a file has been skipped, and TC tries to delete the folder containing that file, it will not return to delete files inside that folder. The user has skipped it, and it would be dangerous to return to it.

[DrShark]

The user has skipped it, and it would be dangerous to return to it.

Sometimes it may be dangerous, but not in cases like one described in start post. To make it possible to continue delete in such cases, I suggest to add additional Yes/No or Yes/No/Cancel (or maybe one with custom choice buttons) warning using CAPSed keywords for attention which will appear after pressing "Retry" in "The following files/folders could not be deleted" dialog:

Code: Select all

---------------------------
[Permanently] delete
---------------------------
You're going to DELETE folder which contains files/folders SKIPPED before.
CONTINUE ANYWAY?
---------------------------
Yes   No   Cancel   
---------------------------

with "No" or "Cancel" set as default button. This solution will probably require additional translations, so may be it worth considering as a fix for for later TC version.

[petermad]

Sorry but this is by design

Then it is counterintuitive to have "Retry" as an option - since TC does NOT retry.

[ghisler(Author)]

It retries to delete the folder, not its contents. This can be useful when the folder was locked because it was the current directory of a running progra, and the user closed that program in the meantime. The user skipped deleting the running program, so why would he suddenly want to delete it now?

[DrShark]

The user skipped deleting the running program, so why would he suddenly want to delete it now?

Because at the moment of skipping user may be still unaware of reason why TC showed access denied dialog with skip button (it may appear not only because the exe we're deleting is running, but because of missing NTFS rights etc.).

BTW, my above suggestion about warning dialog with caps isn't helpful if TC uses some Asian languages, so maybe important words should be also bold or underlined.