Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *DrShark »

To reproduce:
1. Try to replace some file, so Overwrite dialog will appear.
2. In Overwrite dialog, press Left key:
focus will go to "+" button.
3. Press Right or Down keys: focus will stay on [+] button.
It's expected that focus will go to Overwrite dialog, because if after step 2 Overwrite dialog will get focus lost and then get it back again (e.g. after pressing Win+M, then Alt+Esc), pressing Right or Down key will focus the Overwrite button.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *petermad »

I can confirm this but ONLY in the 32bit version of TC.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Usher
Power Member
Power Member
Posts: 1675
Joined: 2011-03-11, 10:11 UTC

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *Usher »

It's even more strange. Add the following steps:
4. Press CursorLeft once or twice again and then repeat pressing CursorRight or CursorDown. In both cases it will stop on [+] button.
5. Press CursorLeft 3 times (to go to "More Options" button) and feel free to repeat pressing CursorRight or CursorDown. Amazing, isn't it?
Andrzej P. Wozniak
Polish subforum moderator
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *ghisler(Author) »

I couldn't find a reason for this behaviour. Switching between controls is handled internally by Delphi. However, I found a solution: I just moved the two checkboxes and the + button to the start of the list of controls (the first main button was there before).
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *petermad »

Almost fixed in TC 9.51rc4 64bit, but if I press right-arrow until I reach the "More Options >>" and then press another time on right-arrow both the box "Thumbnails" AND the button "Overwrite" gets selected.

In the 32bit version there is also a peculiarity: If I press left-arrow then the selection cycles between [+] -> "Custom fields" -> "Thumbnails" -> "Overwrite".

In the 64bit version the sequence for left-arrow is: [+] -> "Custom fields" -> "Thumbnails" -> "More Options >>" -> and the back through the buttons - which is what I would expect.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *DrShark »

history951.txt wrote:02.03.20 Fixed: Tab order in overwrite confirmation dialog incorrect (32)
I can confirm in RC4 after focusing "+" button with left/up keys focusing the "Overwrite" button works fine in TC 9.51 RC4 32-bit.

However, I can confirm it changed keys behavior on other controls:
previously left/up keys changed focus from "Thumbnails" checkbox to "More Options" button, and right/down keys changed focus from "More Options" button to "Thumbnails" checkbox. In TC 9.51 RC4 32-bit:
* left/up keys on "Thumbnails" checkbox change the focus to "+" button (unless a switch to inactive Overwrite dialog with Alt+Tab happens - then left/up keys change focus to "Overwrite" button).
* right/down key on "More Options" button always changes focus to "Overwrite" button.

I currently cannot test on 64-bit TC, so cannot tell how it is different there.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *petermad »

I didn't test up-arrow and down-arrow previously, but can confirm that in both 64bit and 32bit TC the movements are peculiar - and not the same in 64 and 32bit versions.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *ghisler(Author) »

Sorry, that's the best I could do.
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *DrShark »

ghisler(Author) wrote: 2020-03-05, 09:53 UTC Sorry, that's the best I could do.
OK. Do you have an idea what in previous TC version (before the fix) made it possible to switch to Overwrite button from + button after re-activating Overwrite dialog window (see the note about Win+M, then Alt+Esc in start post)?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *ghisler(Author) »

No, I didn't change anyting before RC4 in this dialog. :(
Author of Total Commander
https://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1872
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *DrShark »

ghisler(Author) wrote: 2020-03-06, 16:39 UTC No, I didn't change anyting before RC4 in this dialog. :(
I didn't say you changed something there. You wrote that the switching between controls is handled internally by Delphi. But still to me it's strange that in RC3 a switch from just focused "+" button to "Overwrite" one with Right or Down keys dosen't work before re-activating the Overwrite dialog window (Win+M, Alt+Esc) - after the window is active again, the focus is still on "+", but changing focus to "Overwrite" with Right or Down keys suddenly starts working. So I wonder what is happening if window becomes inactive and then active again: some kind internal window controls re-order or what?
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Ovewright dialog: with focused [+] button, Right and Down keys don't focus Overwrite button

Post by *ghisler(Author) »

It's a complete mystery to me too why it doesn't work in RC3. All I did in RC4 was move the two checkboxes and the + button to the start of the tab order. Before, they were at the end.
Author of Total Commander
https://www.ghisler.com
Post Reply