New SFTP plugin available now

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
Mikefield
Power Member
Power Member
Posts: 625
Joined: 2006-02-26, 19:13 UTC
Location: Oberursel, Germany HE

Post by *Mikefield »

Hello Christian, thanks for beta04!
Good work to add the template. Also for the pluginst.inf.
The plugin works now correct if a connection fails.
Another point should to be fixed, when more than one connection is opened.
Following procedure:
1. open plugin with button on button bar and connect to Server A
2. open plugin again (over button bar, same panel)
3. connect to server B
4. press disconnect to close connection to server B
problem: Panel shows the Plugin with list of servers, not the connection to Server A
5. press diconnect to close connection to server A
problem: panel shows the dir before the plugin starts, not to the plugin with list of servers,
the connection isn't closed
6. press disconnect again, connection to server B is closed now

There is no way to switch between the opened connections. Is it possible to do the same way
as ftp, to give the connections drive letters from 0 til 9?

Question: Is it possible to start the plugin always on the right panel over the button bar,
or have I to add a new tab on the right panel to start it?

mf
Bankster - Word of the Year 2009
Sob
Power Member
Power Member
Posts: 908
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

http://web.hisoftware.cz/sob/download/sftpplug_src04beta-fix.patch

First part adds support for Windows 2000 (tested) and possibly NT4 (not tested) with IPv6 preview installed, where the required functions are in wship6.dll instead of ws2_32.dll.

The second part fixes an error in IPv4-only code.
CoolWater
Power Member
Power Member
Posts: 681
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

Some cosmetical "bug":

http://img206.imageshack.us/my.php?image=sftpfilepropsee7.png

The filename starts and ends with some "special" chars..

Moreover, the file properties dialog is not translated (as the connection dialog) and uses different font as connection dialog.

In connection dialog, the ">>" buttons for the certificate are too close to the text field (in german dialog version).

WBR,
CoolWater
User avatar
franck8244
Power Member
Power Member
Posts: 702
Joined: 2003-03-06, 17:37 UTC
Location: Geneva...

Post by *franck8244 »

2Ghisler
The v0.4 doesn't work on Windows 2k ...Can you include Sob code ?
TC#88260 -
User avatar
Horst.Epp
Power Member
Power Member
Posts: 3854
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Quick Connect doesn't work with beta 0.4

Post by *Horst.Epp »

Hello Christian,
Quick connect no longer works with beta 0.4.
It tries to connect without asking any parameters.
Using beta 0.3 it works fine.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39935
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

1. open plugin with button on button bar and connect to Server A
2. open plugin again (over button bar, same panel)
3. connect to server B
4. press disconnect to close connection to server B
problem: Panel shows the Plugin with list of servers, not the connection to Server A
Why should it show server A? It disconnects, so TC returns to the list of servers!
5. press diconnect to close connection to server A
problem: panel shows the dir before the plugin starts, not to the plugin with list of servers,
the connection isn't closed
Total Commander cannot know that you want to disconnect server A! You have to be somewhere on server A and then press Disconnect.

In version 0.5 beta, you will be able to see which connections are connected: they will have a green lock icon.
First part adds support for Windows 2000 (tested) and possibly NT4 (not tested) with IPv6 preview installed, where the required functions are in wship6.dll instead of ws2_32.dll.
The second part fixes an error in IPv4-only code.
Thanks, added and successfully tested under Windows 2000 (not the IPv6 part).
The filename starts and ends with some "special" chars..
Seems to be UTF-8. Please try the next beta.
Quick connect no longer works with beta 0.4.
I noticed that too - should be fixed in beta 0.5!


See the first message of this thread for 0.5 beta. What's new?

- Properties (Alt+Enter) didn't handle UTF-8 encoding properly
- Show lock icons for connections, show them in green when connected
- Plugin stopped working on systems without ipv6 support (pre-XP)
- Quick connection stopped working
Author of Total Commander
http://www.ghisler.com
CoolWater
Power Member
Power Member
Posts: 681
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater »

ghisler(Author) wrote:
The filename starts and ends with some "special" chars..
Seems to be UTF-8. Please try the next beta.
Well, the new beta behaves the same as long as the option "server uses utf-8 encoding for filenames" is NOT checked. When checking, the file properties now look like:

http://img530.imageshack.us/img530/9503/sftpfilepropsvk2.png

Better but not best ;)

Regards,
CoolWater
User avatar
Mikefield
Power Member
Power Member
Posts: 625
Joined: 2006-02-26, 19:13 UTC
Location: Oberursel, Germany HE

Post by *Mikefield »

Why should it show server A? It disconnects, so TC returns to the list of servers!

This was a misunderstanding how the plugin works.
I thought, when the last connection will be closed, then it will switch to the last active connection.
Now, with the green lock icon it's OK and I know what is to do.

mf
Bankster - Word of the Year 2009
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39935
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Well, the new beta behaves the same as long as the option "server uses utf-8 encoding for filenames" is NOT checked. When checking, the file properties now look like
Apparently your server DOES use UTF-8 then! The quote characters are shown correctly now in the raw STAT box at the bottom. They just don't appear above because the used font doesn't contain them. I will try to use a different font.
This was a misunderstanding how the plugin works.
I thought, when the last connection will be closed, then it will switch to the last active connection.
Now, with the green lock icon it's OK and I know what is to do.
I see - but TC cannot know to which connection it should switch if there were multiple open connections, so it leaves it to the user. I think that the colored icons are an acceptable solution.
Author of Total Commander
http://www.ghisler.com
User avatar
Mikefield
Power Member
Power Member
Posts: 625
Joined: 2006-02-26, 19:13 UTC
Location: Oberursel, Germany HE

Post by *Mikefield »

When the SSH Library could not load, there is no entry in the tcftp.log, but it should be.

mf
Bankster - Word of the Year 2009
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39935
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Well, you get an error message dialog, which should be more than enough notification...
Author of Total Commander
http://www.ghisler.com
gerhard.weinberger
Junior Member
Junior Member
Posts: 21
Joined: 2006-11-02, 15:45 UTC

Post by *gerhard.weinberger »

Thank you! Thank you! Thank you!

After using the old SFTP Plugin for a long time I have to thank you that you have created this plugin! It works very well.

It is also amazing at what speed you have created this plugin. Well done!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 39935
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks! :)

If you look at the sources, you can see why I could write it in such a short time: I re-used a lot of the front-end code of my WebDAV plugin, and had to replace only the calls to the DAV functions by the calls to the SSH libraries...
Author of Total Commander
http://www.ghisler.com
gerhard.weinberger
Junior Member
Junior Member
Posts: 21
Joined: 2006-11-02, 15:45 UTC

Post by *gerhard.weinberger »

ghisler(Author) wrote:Thanks! :)

If you look at the sources, you can see why I could write it in such a short time: I re-used a lot of the front-end code of my WebDAV plugin, and had to replace only the calls to the DAV functions by the calls to the SSH libraries...
That's reuse of code :)
User avatar
Nigurrath
Senior Member
Senior Member
Posts: 224
Joined: 2003-02-05, 12:41 UTC

Post by *Nigurrath »

Hi,
just tested on a server where the previous sftp plugin was not working. This one works flawlessly.

1st
The green lock icon remains green even when the connection is closed, using the Disconnect button. Becomes again gray only after a closing and reopening TC.

2nd
if you use a starting path (in the configuration dialog), it's impossible to go into the parent folders, even if you have rights. When you press enter in the .. returns to the plugin's root.

3nd
A minor comment, to disconnect you have to press twice the Disconnect button.
Post Reply