ts4242 wrote:Sorry, I cannot reproduce. There must be something wrong with all these nested toolbars.
Please ignore my writings on the nested toolbars, as that works the way I like it.
I originally tried on my main PC, which is running Win8.1 and a very bloated Total Commander setup. So to test this properly I have now reproduced the error on my download PC running Vista, my work PC running Win7, and again with my Win8.1, but now with a clean TC installation, a untouched TC installation except for a couple of wincmd.ini settings under [Configuration] section to make it portable:
with the default toolbar that comes with Total Commander with no linked toolbar in it, the button editor crashes giving the same message.
However, I should have been more accurate in my description on how to reproduce the error, as the error only occurs if you insert a " into a blank command field
or if you replace the text in a command field with a "
then instant crash here.
To test further I tried to copy & paste a double quote into a empty command field as such: ""
that went fine.
If I then press backspace, deleting one of the "'s the crash occurs again.
I think there is some form of internal check in your program, checking for if the command path exists while the user types, which fails when it tries to do something like this: If fileexists(""")
It's even possible to reproduce for me with a main toolbar consisting of only one button (just to show that linked toolbars has nothing to do with this):
Code: Select all
button1=%COMMANDER_PATH%\Tools\Ultra_TC_editors\Button Bar Editor.exe
cmd1=""%COMMANDER_PATH%\Tools\Ultra_TC_editors\Button Bar Editor.exe""
menu1=Button Bar Editor
This quote talk makes me think of a feature I'd like.
Because with a ini setup as described above Total Commander will automatically add %COMMANDER_PATH% as the TC path if I drag a executable to the toolbar, which I like, but the path will only be "surrounded" with quotes if there is a file or folder with a space in it, like with Button Bar Editor.exe
I wish however that Total Commander would always add the quotes, as then the links would work even when placed within a path with spaces later. (it's not in one now, I just want the option).
So it would be very handy for me if the Button Bar Editor would indicate which command paths that hasn't been given the quotes.
Another thing it would be cool if it would check is if I remembered quotes around "%T" and such, which I sometimes forget.
I should probably make a script for this myself, if I'm the only one in need of it, but to me these would be handy features. Especially a fix all non quoted commands feature, that's what I really want I guess. Actually I need a similar thing to go through my usercmd.ini
I attempted to make a script for doing the feature I requested above myself:
So never mind my feature request.
I hope the bug which makes the Button Editor crash when entering a quote sign into a blank command box gets fixed in a later version though, as I know I will forget that after making lots of changes. It is very weird that I am the only person getting those crashes, on 3 different computers.