Comments not refreshed after "Change attributes"
Moderators: white, Hacker, petermad, Stefan2
- fenix_productions
- Power Member
- Posts: 1979
- Joined: 2005-08-07, 13:23 UTC
- Location: Poland
- Contact:
Comments not refreshed after "Change attributes"
Steps to reproduce:
1. change view mode to "Comments",
2. use Ctrl+Z and add some comment (i.e. $work),
3. save it (F2),
4. hit Ctrl+Z once again and change comment to something else (i.e. $job),
5. save it,
6. load "Change attributes" dialogue (cm_SetAttrib),
7. check "Change plugin attributes" and choose tc -> comment -> $test
8. hit OK,
9. refresh view using (Ctrl+R),
10. go into another folder and come back.
As we can see, comments changed using "Change attributes" are not refreshed: neither automatically (like for standard method) nor using refresh on demand.
TC should do that right away IMHO.
Notes:
WatchDirs=59
"Configuration" -> "Display" -> "Show hidden/system files (for experts only!)" must be turned off to reproduce it!
1. change view mode to "Comments",
2. use Ctrl+Z and add some comment (i.e. $work),
3. save it (F2),
4. hit Ctrl+Z once again and change comment to something else (i.e. $job),
5. save it,
6. load "Change attributes" dialogue (cm_SetAttrib),
7. check "Change plugin attributes" and choose tc -> comment -> $test
8. hit OK,
9. refresh view using (Ctrl+R),
10. go into another folder and come back.
As we can see, comments changed using "Change attributes" are not refreshed: neither automatically (like for standard method) nor using refresh on demand.
TC should do that right away IMHO.
Notes:
WatchDirs=59
"Configuration" -> "Display" -> "Show hidden/system files (for experts only!)" must be turned off to reproduce it!
Last edited by fenix_productions on 2009-08-29, 13:51 UTC, edited 1 time in total.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...
#128099
#128099
I cannot confirm this.
In step 8 my TC immediately changes the comment in the file panel to $test - and it stays that way doing step 9 and 10.
Testet both with Watchdirs=51 and Watchdirs=59.
Tested with only one comment in the dir and with several comments.
Tested both with Comments view (Ctrl+Shift+F2), and wit a Custom view including a [=tc.Comments] field.
In step 8 my TC immediately changes the comment in the file panel to $test - and it stays that way doing step 9 and 10.
Testet both with Watchdirs=51 and Watchdirs=59.
Tested with only one comment in the dir and with several comments.
Tested both with Comments view (Ctrl+Shift+F2), and wit a Custom view including a [=tc.Comments] field.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
- fenix_productions
- Power Member
- Posts: 1979
- Joined: 2005-08-07, 13:23 UTC
- Location: Poland
- Contact:
2petermad
I've just tested on two different machines and can reproduce each time I try.
Are you sure you have some comment already before loading "Change attributes" dialogue? Without - it works OK. First comment is always refreshed, no matter which way I follow.
I've just tested on two different machines and can reproduce each time I try.
Are you sure you have some comment already before loading "Change attributes" dialogue? Without - it works OK. First comment is always refreshed, no matter which way I follow.
"When we created the poke, we thought it would be cool to have a feature without any specific purpose." Facebook...
#128099
#128099
Yes - as i wrote: "Tested with only one comment in the dir and with several comments."Are you sure you have some comment already before loading
But if I turn off "Configuration" -> "Display" -> "Show hidden/system files (for experts only!)" I can reproduce your observation!
So you better consider yourself an expert to make it work.
IIRC there has been reports of other situations where comments hasn't been opdated if hidden/system files are not shown.
IMHO it is still a bug, or at least an inconvenience. It should be changed, so that TC updates its file list properly when using "Change plugin attributes" - TC shouldn't rely on "seeing" the descript.ion file being changed.
Last edited by petermad on 2009-08-29, 15:16 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
- fenix_productions
- Power Member
- Posts: 1979
- Joined: 2005-08-07, 13:23 UTC
- Location: Poland
- Contact:
- ghisler(Author)
- Site Admin
- Posts: 48088
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
I can comfirm the problem, thanks. The comments are cached internally in the file lists, so when there is no change to the files, the comments aren't re-read either. I will clear the comment cache whenever the user uses content plugins in the attributes dialog.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- fenix_productions
- Power Member
- Posts: 1979
- Joined: 2005-08-07, 13:23 UTC
- Location: Poland
- Contact:
Fixed in TC 7.50 final
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
- ghisler(Author)
- Site Admin
- Posts: 48088
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Thanks! Can anyone else (or the thread starter) confirm it too?
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- fenix_productions
- Power Member
- Posts: 1979
- Joined: 2005-08-07, 13:23 UTC
- Location: Poland
- Contact:
- ghisler(Author)
- Site Admin
- Posts: 48088
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact: