ScriptWFX plugin crashes TC , stack trace included

[billiebub]

The ScriptWFX plugin crashes in certain conditions and causes TC to also crash. It would be great if TC could manage to stay alive and swallow the crash. Here is a link to the stack trace Image: http://img855.imageshack.us/img855/8897/clipboard01xq.png

[Hacker]

Hello billiebub,
Copying and pasting the stack trace here would save a lot of typing.

Roman

[billiebub]

---------------------------
Total Commander 7.56a
---------------------------
Exception in ScriptWFX.wfx:FsFindFirst!
External exception EEDFADE
Windows XP SP3 5.1 (Build 2600)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: 0EEDFADE
Stack trace:
08A76B7D
6C1DF0 >646D9C 5F4133 5F8A55 444491 422CC0
444F62 422CC0 444523 422CC0 6BBEF5 444491
422CC0 444491 422CC0 446B2C 444F62 422CC0
444491 45875F 443011 442F4F 445316 444F62
422CC0 444523 422CC0 444491 422CC0 444F62
422CC0 444523 422CC0 42838C 428424 6C53C9

Raw:
643C81 676D08 676D60 5C0056 6C1DF0 64649F
6C1DF0 690064 690064 5C0057 6760FF 6C1DF0
645310 6763FC 680071 4E18E0 40208E 402212
402235 4162A8 415F35 416308 646D9C 422CC0
445231 42499C 6C2368 6BB900 67006C 680071
610074 4452DB 443011 445231 443011 433098
4445E5 444F62 444F85 43FFFE 422CC0 444523
422CC0 444491 422CC0 6C2174 5384B7 5384DE
444F62 444F85 422CC0 444523 422CC0 6C2ED7
40208E 4023B3 4023DB 4026A4 4036AD 403796

Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Yes No
---------------------------

[ricobautsch]

What are "certain conditions"?
Can you try to describe what you are doing, when the plugin crashes?
What is your script doing? Is the problem reproducable with other scripts?
Are you using the latest version of ScriptWFX (1.2)?
Download at: ribanet(dot)de(slash)tcplugins(slash)ScriptWFX.zip

[billiebub]

The version that I'm using is whatever is on totalcmd.net which seems to be 1.1.

The conditions are simple. If the script throws an error, the VBScript error box will show up which is the normal behavior then after that, the TC stack trace window will pop up then crash.

In my case to describe what I'm doing I make an HTTP GET to retrieve a page. I can only retrieve the pages over VPN. Sometimes if I forget that I'm connected over VPN and I execute the script which then I can not access the page and throw the error.

The problem is reproducable with other scripts that don't catch errors usually through On Error Resume Next which I try to avoid to determine the source of the problem.

I downloaded the latest version from the link you posted. Could you please post it to totalcmd.net? That's where people usually look for plugins.

[ricobautsch]

In case of a exception, TC ask's to continue execution. If i select "Yes" then i can go on to use TC.

If there's an unhandled exception, nobody can say if all is in an consistent state. I assume that's why ghisler optional aks's to stop execution.

If there are potential exceptions in script, then you should handle it, analyze and display a message.

I think it's not a good idea to suppress unhandled exceptions.

It seems totalcmd.net has changed access for authors of plugins. I contacted the webmaster via mail.

[billiebub]

I do handle exception when necessary but on initial testing of the script I noticed the behavior and thought that the plugin should have handled it more elegantly.

In normal circumstances when using the VBScript engine, when I get an error, the engine simply handles it by displaying an error box and terminates the script. The actual engine itself does not crash but simply returns an error code of 1 or whatever. Can ScriptWFX work in this manner by simply swallowing the exception rather than pass it to TC?

In some situations if you decide to click "yes" and continue execution in TC, you will not get back the normal behavior and some functions seize to function and so I simply click NO because an exception of that size is rather very very deep and TC was nice enough to display it.

[billiebub]

More information here from another popup in non english:

Anwendungsfehler

Exception EAcessViolation in Modul ScriptWFX.wfx bei 000066A4
Zugriffsverletzung bei Adresse 024366A4 in Modul 'ScriptWFX.wfx'. Lesen von Adresse 585A1460.

[billiebub]

I happened to search for the word "Script" in totalcmd.net to see what other scripting plugins out there and saw ScriptWFX 1.3. I thought totalcmd.net will show new added plugins. When did you submit the new version? How come it does not show in totalcmd.net list of new plugins?

There is got to be better coordination for this kind of stuff.

[billiebub]

If a script takes long to execute, Windows will display a message to either "End" or "Continue" the running script. If you click "End", TC crashes.

[petermad]

There is got to be better coordination for this kind of stuff.

totalcmd.net is totally independent from ghisler.com/ch. totalcmd.net - you should complain at totalcmd.net - not here.

[billiebub]

When a script takes too long to execute and you get prompted to End or Continue the script. If you decide to end it, TC will crash. Do you have a way around this kind of behavior?

[ricobautsch]

I cannot reproduce the behavior you describe.
In my case, if a script takes to long to execute (the timeout is configurable in the ScriptWFX.ini), and i decide to not continue, then TotalCommander gets the exception and asks wheter to continue execution of TC or not.
This is a very good desired behavior in my opinion.

[billiebub]

@ricobautsch, if you continue execution, does TC behave correctly after that? In my case, many functions stop working after continuing execution.

[ricobautsch]

the timeout is set to 30 seconds here.
I don't have any scripts running longer than that time, so i have no real experience in the behavior. I have testet only with a simulatet "delay", and then all is going on correctly.
Do you have a reproducable sample script, where the functionality is broken after a timeout?