Improvements for button to confirm the inplace rename

[ts4242]

1- Show the button the left side, this is has some advantages
a. It will be in fixed place regardless of column width or view mode.
b. In most cases it will be near to the mouse pointer.
c. It will be more recognizable.

2- Use the icon shown in the button to assign hotkey, it is more beautiful than the current.

See sample

[ts4242]

Make it optional to let the user choose what he like

Code: Select all

InplaceOkButton=0 ; Disabled
InplaceOkButton=1 ; Show on the right side
InplaceOkButton=2 ; Show on the left side

[ghisler(Author)]

I will consider it.

[MVV]

The only problem that it looks too ugly in the left. Maybe it will look better if button will be shown above file icon so edit window will have traditional position...
Anyway I think mouse users won't see any problem in clicking button on the right.

[ts4242]

I will consider it.

Thank you.

I think mouse users won't see any problem in clicking button on the right.

Usually the user start inplace rename by clicking twice on the file icon or near of it then use the rename box's context menu to edit the name, so, the button on left will be already near to the mouse pointer and no need to move too far to click the button.

Beside when it is on the right side, it become above files details and some eyes could miss it.

[MVV]

Usually the user start inplace rename by clicking twice on the file icon or near of it then use the rename box's context menu to edit the name, so, the button on left will be already near to the mouse pointer and no need to move too far to click the button.

BTW you must do long double click onto file name and not file icon (Explorer and TC). So it is more logical to expect click at the middle of end of file name (or even at file details if using full view mode) and not at the beginning.

Beside when it is on the right side, it become above files details and some eyes could miss it.

Maybe it would be better to show button just below rename field aligned to its left side?

[ts4242]

30.11.2011 Added: InplaceOkButton=2 shows confirm button to the left of the edit box, where the icon is normally shown (32/64)

Wonderful, thanks a lot.

[ghisler(Author)]

The question is now which should be the default, 1 or 2. I like both...

[ts4242]

For me, of course 2 should be the default for the reasons i said above.

[Sir_SiLvA]

I prefer it on the right side so its visable and not mixed with the fileicons....

[Samuel]

I prefer right too.

[Flint]

Count my vote for right.

[MVV]

I think right is better and more traditional.

Christian, people from Russian board suggest to remove one black pixel in button's checkmark icon (reality, suggestion).

[ghisler(Author)]

OK, I will keep it on the right for now, and change the icon as suggested.