New SFTP plugin available now

Discuss and announce Total Commander plugins, addons and other useful tools here, both their usage and their development.

Moderators: sheep, Hacker, Stefan2, white

Post Reply
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-27, 09:09 UTC

I have received it and will integrate it soon. Thanks very much!
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-27, 19:55 UTC

The code has been integrated in SFTP plugin 2.10, see first post for download links of plugin and sources. I had to make minor changes for 64-bit.

Thanks very much, CoolWater, for the contribution!
Author of Total Commander
http://www.ghisler.com

CoolWater
Power Member
Power Member
Posts: 675
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater » 2018-06-27, 20:15 UTC

2ghisler(Author)

You are Welcome :) the first post still shows version 2.0.

I will also add Support for files > 2GB in SCP Mode. There is still a fallback to sftp implemented at the Moment..

Regards
Coolwater

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-27, 20:22 UTC

Does this need updated OpenSSH DLLs?
Author of Total Commander
http://www.ghisler.com

CoolWater
Power Member
Power Member
Posts: 675
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater » 2018-06-27, 20:37 UTC

2ghisler(Author)

Yes, Version 1.2.6 is needed therefore. Keep-Alive needs 1.2.5

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-06-27, 20:50 UTC

How about the server side?
Author of Total Commander
http://www.ghisler.com

CoolWater
Power Member
Power Member
Posts: 675
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater » 2018-06-27, 21:05 UTC

2ghisler(Author)

Well, i cannot find anything about server-side requirements. Only libssh2 needs to be Version >= 1.2.6. See https://www.libssh2.org/libssh2_scp_send64.html

Bozzy
Junior Member
Junior Member
Posts: 13
Joined: 2013-09-10, 15:06 UTC

Post by *Bozzy » 2018-06-28, 15:53 UTC

Tested the keep alive feature right now with my SFTP server and it's working great! Thanks again CoolWater and Christian.

CoolWater
Power Member
Power Member
Posts: 675
Joined: 2003-03-27, 16:33 UTC

Post by *CoolWater » 2018-06-28, 16:04 UTC

2Bozzy

That's nice to hear! What interval (seconds) do you use currently?

Regards,
CoolWater

Bozzy
Junior Member
Junior Member
Posts: 13
Joined: 2013-09-10, 15:06 UTC

Post by *Bozzy » 2018-06-28, 22:07 UTC

CoolWater wrote: That's nice to hear! What interval (seconds) do you use currently?
I've set it to 30s. My server is closing connections after something like 2 or 3 mins, so also 60s should work... tomorrow I'll raise it.

andy22
Junior Member
Junior Member
Posts: 3
Joined: 2018-07-24, 08:42 UTC

Re: New SFTP plugin available now

Post by *andy22 » 2018-07-24, 13:05 UTC

Hi, while creating some .patch files on linux, i traced a problem back to TC/sftp plugin. Basically the
convert text files to/from Unix format during transfers
breaks my cross-platform workflow. Mainly because i often copy/edit on my windows host, while also using github-desktop for mixed work. I tested other sftp implementations winscp/sshfs-win and there no EoL conversion happens on transfers/opens.

So is there a way to disable this automatic conversion in TC/sftp plugin, so my files always keep the org. line endings and i get a hash perfect copy?

PS: My org. issue here (last 2 posts): https://forum.lede-project.org/t/solved-need-help-with-eol-mismatch-on-patch/17505/6

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: New SFTP plugin available now

Post by *ghisler(Author) » 2018-07-24, 14:21 UTC

My plugin doesn't do any conversions. You can verify that by looking at the sources. Maybe your server does when it somehow detects a Windows client?
Author of Total Commander
http://www.ghisler.com

andy22
Junior Member
Junior Member
Posts: 3
Joined: 2018-07-24, 08:42 UTC

Re: New SFTP plugin available now

Post by *andy22 » 2018-07-24, 14:51 UTC

ghisler(Author) wrote:
2018-07-24, 14:21 UTC
My plugin doesn't do any conversions. You can verify that by looking at the sources. Maybe your server does when it somehow detects a Windows client?
I'm confused since the changelog states:

Code: Select all

20081231 Added: CR <-> CRLF conversion for transfers from/to Unix servers. Do not convert files containing 0 bytes (binaries, utf-16), do not convert CRLF to CRCRLF
There is also a setting under properties "system:" which has Auto/Windows/Unix. If i set it to Auto and connect to a linux machine it detects LF endings and any LF formatted textfile i than copy via F5 from the sftp filesystem is changed to CRLF endings?

PS: I checked my 'sshd_config' and can't find any setting regarding line ending conversions, i have 'OpenSSH_7.5p1, OpenSSL 1.0.2o' running on the server. Do you know any setting i can check that might be involved in this?

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38438
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: New SFTP plugin available now

Post by *ghisler(Author) » 2018-07-24, 20:53 UTC

Sorry, you are indeed right, there is such a conversion for text files. Just set the System type to Windows (CR/LF) to turn off line break conversions. It doesn't have any other effect, so it's not a problem to set this for a Unix based system.
Author of Total Commander
http://www.ghisler.com

andy22
Junior Member
Junior Member
Posts: 3
Joined: 2018-07-24, 08:42 UTC

Re: New SFTP plugin available now

Post by *andy22 » 2018-07-24, 22:59 UTC

ghisler(Author) wrote:
2018-07-24, 20:53 UTC
Sorry, you are indeed right, there is such a conversion for text files. Just set the System type to Windows (CR/LF) to turn off line break conversions. It doesn't have any other effect, so it's not a problem to set this for a Unix based system.
Thanks for the clarification.

So under what conditions does the Windows setting convert? I would prefer a "none" option, that never touches anything.

Post Reply