Plugin install by pluginst.inf doesn't work on opening with unpacker from Internal Associations

[DrShark]

If to define in internal associations unpackers (internal, external for opening archive, TC won't offer to install the plugin if archive is opened by such internal context menu item, or by Enter if WCX or internal unpacker assigned to default Open action, as in example below:

Code: Select all

[Associations]
Filter1=*.7z
Filter1_open=**internal_7z
Filter1_7z plugin=**7z
Filter1_7-Zip plugin=**7zip
[PackerPlugins]
7z=207,c:\backup_c\Program Files\7-Zip\7z_upx.wcx
7zip=71,c:\totalcmd\Plugins\wcx\7zip\7zip.wcx

----------------------------------------------------------------

A note about **internal_7z. It works as described in history.txt:

19.03.19 Fixed: Internal associations: **ext only worked for packer plugins, not for internal unpackers like **zip. Now also supports **internal_zip to override external packers (32/64)

As Christian Ghisler explained in email:

The following are recognized: **xyz or **internal_xyz with xyz any of these:
zip, arj, lha, lzh, rar, uc2, gz, tar, tgz, ace, cab, 7z, t7z.
...
If you use for example **zip, Total Commander will use any (external) packer plugin if there is one defined for the zip extension, otherwise the internal zip. Therefore **internal_zip is only needed when there IS a packer plugin defined for zip AND an internal unpacker for zip.

[ghisler(Author)]

Currently TC treats this like pressing Ctrl+PageDown, where plugins are ignored. I will change it.

[DrShark]

02.12.19 Fixed: Auto-installing plugins via pluginst.inf didn't work when archive was opened via internal association (32/64)

This fix doesn't seem to work for my example settings from first post - TC 9.50 beta 8 still doesn't show auto-install offer message if to open .7z archive with Enter or using any internal context menu item.

[ghisler(Author)]

It works for me. Maybe you had opened the file before? It only works on the first open of the file after starting TC.

[DrShark]

It works for me. Maybe you had opened the file before? It only works on the first open of the file after starting TC.

I tried it on almost default ini, like this one:

Code: Select all

[Configuration]
UseNewDefFont=1
SetEncoding=дц.do.not.remove
firstmnu=2682
FirstTime=0
FirstTimeIconLib=0
DarkMode=2
SeparateTree=0
PanelsVertical=0
FirstTimeUnpack=0
QuickSearchAutoFilter=1
[left]
path=c:\downloads\
ViewMode=10001
activepanelcolor=-1
activepanelcolor2=-1
activepanelcolordark=-1
activepanelcolordark2=-1
ShowAllDetails=1
SpecialView=0
show=1
sortorder=3
negative Sortorder=1
[right]
path=c:\
ViewMode=10001
activepanelcolor=-1
activepanelcolor2=-1
activepanelcolordark=-1
activepanelcolordark2=-1
ShowAllDetails=1
SpecialView=0
show=1
sortorder=0
negative Sortorder=0
[Associations]
Filter1=*.7z
Filter1_open=**internal_7z
Filter1_7z plugin=**7z
Filter1_7-Zip plugin=**7zip
[PackerPlugins]
7z=207,c:\backup_c\Program Files\7-Zip\7z_upx.wcx
7zip=71,c:\totalcmd\Plugins\wcx\7zip\7zip.wcx
[RightHistory]
[LeftHistory]

So if I open a file http://progman13.wincmd.ru/downloads/wlx_HexViewer_1.1_Beta.7z using any of 3 internal association menus (Open, 7z, 7zip) or Enter key, no matter whether after TC restart or after opening another archive with Enter, TC just opens wlx_HexViewer_1.1_Beta.7z and doesn't ask to install a plugin. With removed internal associations (but leaving association for 7z in [PackerPlugin] section) or if to start TC with really clean ini, it asks to install this plugin after archive opening.

[ghisler(Author)]

I'm sorry but I cannot reproduce it. I used your sample ini (with just the directories of the plugins adjusted), with 7z pointing to the 7zip plugin, and 7zip pointing to Total7zip. All 3 methods (Enter and the two context menu entries) open the plugin install dialog.

[DrShark]

It seems the reason is 7z plugin, or its upx version, CRC32:
7z.wcx B7C94996
7z_upx.wcx DF757A7F

If this plugin is installed, auto-install doesn't work for it on 7z opening.
Edit: Then, other internal menus that use other plugins or internal unpacker don't offer auto-install dialog too!

So with configuration:

Code: Select all

[Associations]
Filter1=*.7z
Filter1_open=**internal_7z
Filter1_7-Zip plugin=**7zip
[PackerPlugins]
7z=207,c:\backup_c\Program Files\7-Zip\7z_upx.wcx
7zip=71,c:\totalcmd\Plugins\wcx\7zip\7zip.wcx

with 7zip and 7z plugins installed, with 7z one associated with 7z extension, internal menus for internal unpacker and 7zip plugin won't offer auto-install!


Today I sent to support email this problem 7z plugin with 7zip program which it uses.

[ghisler(Author)]

I have tried your 7zip plugin with your ini and autoinstall works just fine.

[DrShark]

In email I sent a video which shows that there is no auto-install offers for menu items when to open an archive with .7z extension, even though the 7z plugin is only installed, but not used for menus at all.
For the same file with .7zip extension, auto-install works fine.
Test settings:

Code: Select all

[Associations]
Filter1=*.7z
Filter1_open=**internal_7z
Filter1_7-Zip plugin=**7zip
Filter2=*.7zip
Filter2_open=**internal_7z
Filter2_7-Zip plugin=**7zip
[PackerPlugins]
7z=207,c:\backup_c\Program Files\7-Zip\7z_upx.wcx
7zip=71,c:\totalcmd\Plugins\wcx\7zip\7zip.wcx

7z plugin is this one.
7zip plugin is from here.

[ghisler(Author)]

Yes, I have seen the video, but I still can't reproduce it. Can you try opening the .7z file before the .7zip file?

[DrShark]

Yes, I have seen the video, but I still can't reproduce it. Can you try opening the .7z file before the .7zip file?

Yes, also tried that after TC restart and even cm_UnloadPlugins, but still no auto-install for menus used for files with .7z extension...

[DrShark]

2ghisler(Author)
The post:
viewtopic.php?p=364823#p364823
explains why Auto-install dialog doesn't appear when using 7z plugin to open .7z archive.

It doesn't explain, however, why Auto-install dialog then doesn't appear for all context menu unpackers set for .7z extension, as in configuration from the post viewtopic.php?p=364765#p364765

Please try to reproduce the issue with full 7-zip program I attached to my first email on this issue from Dec 11, 2019.

[ghisler(Author)]

I will check it, but it makes sense that it's due to the missing compression method.

[DrShark]

13.12.19 Fixed: User choice of unpacker (e.g. via context menu from internal association) was ignored in plugin auto-installer, using the default unpacker for that extension (32/64)

With this fix now in TC 9.50 beta 10 auto-install appears and works fine for menus where it supposed to, so the issue is fixed. Checked on Vista 32-bit.

[ghisler(Author)]

Great, thanks for all your help - this was a tough one to figure out.