[TC10.52rc1] Wrong virtual folder selection in separate tree

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

I have checked this now - it seems to be unrelated to the main bug report here (tree not being updated correctly).
What happens is that a click on the ".." button in these folders doesn't do anything at all.
I have checked the code, and there is an explicit block to NOT go to the desktop folder:

Code: Select all

if (parentidlist<>nil) and (parentidlist^.mkid.cb>0) then
  gotofolder(parentidlist);
The length indicator "cb" is 0 only for the desktop item.
I don't know any more why this block is here, but it looks intentional.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

Perhaps at one time you considered these virtual folders roots. Note that there is no .. entry in the This PC folder or Network folder, but there is in the other "root" virtual folders. Also note that in the breadcrumb bar, all virtual folders are considered root folders.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

Probably yes, so you don't go up to the (relatively useless) desktop folder when clicking ".." repreatedly. I will leave it as it is for now.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

white wrote: 2022-10-10, 23:17 UTC Enter or double-click on the .. entry work correctly, but using the .. button or pressing Ctrl+PgUp do not.
ghisler(Author) wrote: 2022-10-11, 07:10 UTC Thanks, that still seems to call an older function.
Forgot about this one? Where the [..] button works, the tree is not updated when it is clicked.
white wrote: 2022-10-11, 07:48 UTC BTW, go to root in a virtual folder brings you to the network virtual folder. Is it possible to change that to the root Desktop folder?
Is this hard coded?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

Forgot about this one? Where the [..] button works, the tree is not updated when it is clicked.
NOT confirmed, clicking [..] updates the tree, unless you go to a virtual folder - that isn't supported.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

Do the same as described in first post. Do the first 3 steps but instead of step 3:
white wrote: 2022-10-06, 12:24 UTC 3. Press Enter (on "..") to return to the "This PC" folder
Return to the "This PC" folder by clicking the [..] button or pressing Cltr+PgUp.

The tree panel isn't refreshed, you have to press F2 for it to get updated.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

The path in the other panel isn't changed to "This PC" either. Currently I don't see a way to add this, sorry.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4577
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *white »

ghisler(Author) wrote: 2022-10-16, 13:19 UTC The path in the other panel isn't changed to "This PC" either.
What do you mean?
ghisler(Author) wrote: 2022-10-16, 13:19 UTC Currently I don't see a way to add this, sorry.
A refresh seems to be done always (even when no navigation takes place and the refresh doesn't make sense), except in this case where navigation actually does take place. Why is that?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48012
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC10.52rc1] Wrong virtual folder selection in separate tree

Post by *ghisler(Author) »

I think I found a good solution now. There are two cases:
1. One side is in the root of the drive, the other in a subfolder. Here I will beep when the user tries to go up, and on second try will disable cm_SyncChangeDir
2. Both sides are in the root of the drive. Here I will go up to "My PC" on both sides.
Author of Total Commander
https://www.ghisler.com
Post Reply