Button execution with combined commands denied

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
tuska
Power Member
Power Member
Posts: 3740
Joined: 2007-05-21, 12:17 UTC

Button execution with combined commands denied

Post by *tuska »

Code: Select all

TOTALCMD#BAR#DATA
cm_50Percent,cm_FocusLeft,cm_SrcViewMode0,cm_SrcAllFiles,cm_FocusRight,cm_SrcViewMode0,cm_SrcAllFiles,cm_SrcActivateTab1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,cm_Exchange,cm_RereadSource,cm_rereadsource 1

wcmicons.DLL,86
Strg+Y || em_D-Daten_I-Daten|cm_50Percent,cm_FocusLeft,cm_SrcViewMode0,cm_SrcAllFiles,cm_FocusRight,cm_SrcViewMode0,cm_SrcAllFiles,|cm_SrcActivateTab1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,cm_Exchange,cm_RereadSource,cm_rereadsource 1


-1
usercmd.ini

Code: Select all

[em_D-Daten]
button=
cmd=cd D:\Daten

[em_I-Daten]
button=
cmd=cd I:\Daten

Code: Select all

10.52RC1 x64, x86: Ctrl-Y -> OK

10.52RC2 x64, x86: Ctrl-Y -> Error message*
10.52RC3 x64, x86: Ctrl-Y -> Error message*

*File not found!
cm_50Percent,cm_FocusLeft,cm_SrcViewMode0,cm_SrcAllFiles,cm_FocusRight,cm_SrcViewMode0,cm_SrcAllFiles,cm_SrcActivateTab1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,cm_Exchange,cm_RereadSource,cm_rereadsource 1
"Das System kann die angegebene Datei nicht finden."  ... ("The system cannot find the specified file.")
If one enters the combined commands in the TC command line and presses ENTER, then these commands function properly.

Please check.
Thank you!
User avatar
white
Power Member
Power Member
Posts: 4593
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Button execution with combined commands denied

Post by *white »

Confirmed.

Easier test case that fails:

Code: Select all

TOTALCMD#BAR#DATA
cm_SrcActivateTab1,cm_ReReadSource 1

wcmicons.DLL,86



-1
sa16
Senior Member
Senior Member
Posts: 215
Joined: 2021-09-10, 07:15 UTC

Re: Button execution with combined commands denied

Post by *sa16 »

2tuska
2white
So without a failure:

Code: Select all

cm_SrcActivateTab1 1,cm_ReReadSource 1
Bug in processing cm_SrcActivateTab1.
User avatar
tuska
Power Member
Power Member
Posts: 3740
Joined: 2007-05-21, 12:17 UTC

Re: Button execution with combined commands denied

Post by *tuska »

sa16 wrote: 2022-10-14, 12:44 UTC 2tuska
So without a failure:

Code: Select all

cm_SrcActivateTab1 1,cm_ReReadSource 1
Bug in processing cm_SrcActivateTab1.
Thanks for the hint, I can use that temporarily - just for the button(-click):
...,cm_SrcAllFiles,cm_SrcActivateTab1 1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,...
sa16
Senior Member
Senior Member
Posts: 215
Joined: 2021-09-10, 07:15 UTC

Re: Button execution with combined commands denied

Post by *sa16 »

tuska wrote: 2022-10-14, 14:01 UTC just for the button
Create a em_SrcActivateTab1_1 = cm_SrcActivateTab1 1.
User avatar
tuska
Power Member
Power Member
Posts: 3740
Joined: 2007-05-21, 12:17 UTC

Re: Button execution with combined commands denied

Post by *tuska »

sa16 wrote: 2022-10-14, 14:37 UTC
tuska wrote: 2022-10-14, 14:01 UTC just for the button
Create a em_SrcActivateTab1_1 = cm_SrcActivateTab1 1.
Thank you, but I don't think that's necessary for me, because a correction will surely come. :)
sa16
Senior Member
Senior Member
Posts: 215
Joined: 2021-09-10, 07:15 UTC

Re: Button execution with combined commands denied

Post by *sa16 »

tuska wrote: 2022-10-14, 14:56 UTC a correction will surely come.
Of course!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Button execution with combined commands denied

Post by *ghisler(Author) »

Confirmed, thanks. It looks like in
cm_SrcActivateTab1,cm_ReReadSource 1
it is trying to use the parameter of the second command in the first.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Button execution with combined commands denied

Post by *ghisler(Author) »

This should be fixed in RC4, please test it!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4593
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Button execution with combined commands denied

Post by *white »

Tested OK using TC 10.52rc4.
sa16
Senior Member
Senior Member
Posts: 215
Joined: 2021-09-10, 07:15 UTC

Re: Button execution with combined commands denied

Post by *sa16 »

User avatar
tuska
Power Member
Power Member
Posts: 3740
Joined: 2007-05-21, 12:17 UTC

Re: Button execution with combined commands denied

Post by *tuska »

HISTORY.TXT wrote: 18.10.22 Release Total Commander 10.52 release candidate 4 (RC4)
16.10.22 Fixed: Button bar: Some combinations of commands didn't work, like cm_SrcActivateTab1,cm_ReReadSource 1 (32/64)
For the options mentioned, I can confirm the fix in TC 10.52RC4 x64/x86.
Thanks!

Tested with buttons that execute the following command combinations:

Code: Select all

a) cm_50Percent,cm_FocusLeft,cm_SrcViewMode0,cm_SrcAllFiles,cm_FocusRight,cm_SrcViewMode0,cm_SrcAllFiles,cm_SrcActivateTab1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,cm_Exchange,cm_RereadSource,cm_rereadsource 1
b) cm_50Percent,cm_FocusLeft,cm_SrcActivateTab1,em_D-Daten,cm_TrgActivateTab1,em_I-Daten,cm_FocusLeft,cm_RereadSource,cm_rereadsource 1
User avatar
white
Power Member
Power Member
Posts: 4593
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Button execution with combined commands denied

Post by *white »

Does the same problem exist with other commands? It seems the same problem exist for cm_wait, for example: cm_wait,cm_ReReadSource 1
(I know this combined command is not very useful, but it shouldn't give the errror)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Button execution with combined commands denied

Post by *ghisler(Author) »

That's only because cm_wait requires a parameter. Try a button with just
cm_wait
on it and you will also get an error.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4593
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Button execution with combined commands denied

Post by *white »

2ghisler(Author)
Confirmed. I thought I tested it though, must be going crazy ;)
Post Reply