[TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

[TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

When using cm_CopyPathOfFilesToClip in A Search result Fed to listbox and folders are marked - those foldernames as copied as the parent folder followed by two backslashes - Expected result is to copy the full path of the marked folders.

See https://tcmd.madsenworld.dk/CopyPathOfFilesToClip.png
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *ghisler(Author) »

I agree that the 2 backslashes are wrong. But are you sure about including the last directory name? When you use the function on a directory in normal view, it doesn't copy the directory name itself.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

When you use the function on a directory in normal view
There is no reason to use this function in normal view - it will just consist of lines with the same directory. The function is handy for Bracch view and Search results though ,and therefore I think it should save the whole path of marked directories.

Imagine if I had searched for only directories and want a list of the search result, then I would be interested in the full paths.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *Flint »

But for full results you can use cm_CopyFullNamesToClip. Why have the new command if it just duplicates an existing one?
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

Why have the new command if it just duplicates an existing one?
If I in a Search result mark both some folders and some files, then the cm_CopyPathOfFilesToClip should give me the folders only for all entries, whereas cm_CopyFullNamesToClip will include the file name for the files.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *Flint »

2petermad
Exactly. It does what its description says: copies a path to the directory where the found item is located (be this item a file, or a subdirectory).
That's why I don't see how you propose to change its behavior. If you want it to copy full path including the item itself, then it will be the same as cm_CopyFullNamesToClip, why do you need a new cm_CopyPathOfFilesToClip for that?

Or do you want the command to copy only parent paths for files, but full paths for subdirs? I expect that would be really confusing.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

Or do you want the command to copy only parent paths for files, but full paths for subdirs? I expect that would be really confusing.
Actuall that is what i do, but even if it doesn't at least the double backslashes for dir entries should be fixed.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
TychoBarfy
Senior Member
Senior Member
Posts: 347
Joined: 2005-08-13, 15:13 UTC
Location: Berlin, Germany
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *TychoBarfy »

BTW, if I searched for files with certain extensions (e.g. *.mp3) in an unlimited depth of sub directories, I possibly get a huge amount of results.
If i select all - to make it quick - and use this command, it should eliminate duplicates of paths before creating the clipboard contents.
Fla$her
Power Member
Power Member
Posts: 2299
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *Fla$her »

2TychoBarfy >>>
Fla$her wrote: 2023-05-02, 16:04 UTC
Will it copy both paths to the clipboard? And if yes, will it copy the same path just once, or as many times as there are selected files in that path?
All paths will be copied. But it will be great, of course, if you also make an option without matches.
2petermad
You want to distort the results of the requested DC analog. This is not good.
To avoid discrepancies, it was worth changing the name to cm_CopyParentPathOfItemsToClip.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

history.txt wrote:05.05.23 Fixed: cm_CopyPathOfFilesToClip appended 2 backslashes to parent directories of folders in search results (32/64)
Confirmed fixed in TC 11.00b2 :-)

I still think the whole path should be copied when used for a directory in the Search result panel.
Last edited by petermad on 2023-05-10, 16:42 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6482
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *Horst.Epp »

petermad wrote: 2023-05-10, 15:40 UTC I still think the whole path should be copied when used for a directory in the Search result panel.
I fully agree.
With the full path for dirs only it would be more usefull.
Why is there a difference in the result compared to a list with files.
Only the name may be a little bit misleading.
Windows 11 Home x64 Version 23H2 (OS Build 22631.3447)
TC 11.03 x64 / x86
Everything 1.5.0.1372a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48079
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *ghisler(Author) »

Well, the command name cm_CopyPathOfFilesToClip is ambiguous, it does not say anything about the path of folders.
Maybe I should really rename it to cm_CopyParentPathOfItemsToClip as suggested above? Or add another command where one copies the full path of folders, and the other the folders themselves?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14796
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *petermad »

How about calling the command cm_CopyPathsToClip and then let it copy the full path of folders as Horst.Epp and I suggest.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2299
Joined: 2020-01-18, 04:03 UTC

Re: [TC 11.00b1] Unexpected result using cm_CopyPathOfFilesToClip

Post by *Fla$her »

ghisler(Author) wrote: 2023-05-11, 08:08 UTC Maybe I should really rename it to cm_CopyParentPathOfItemsToClip as suggested above? Or add another command where one copies the full path of folders, and the other the folders themselves?
We already have cm_CopyFullNamesToClip, which copies the paths to the selected folders and files. Why do we need another command that does the same with folders? Rename will be the right decision.
Overquoting is evil! 👎
Post Reply