Dark mode: separators and buttons

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

Dark mode: separators and buttons

Post by *Paul Mountit »

1. in tc there are 3 horizontal lines/separators (indicated with the red circles in the image) that are painted with the border color.
to me they look ok in normal theme and not so ok in dark theme, I'd really like to have a separate color option for these 3 lines, giving the possibility to make them disappear completely, like in the rightmost image, keeping at the same time the border color for the other items that use it.

2. in normal theme, the buttons on the bar and the buttons for the drives are painted the same way (framed) when selected (first image), in dark theme the selected buttons are sunken and the selected drive is framed. I'd like to be the same, and I'd prefer to be like in normal theme, framed and not sunken.

Image: https://s20.directupload.net/images/220521/dnbni7gr.png
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark mode: separators and buttons

Post by *ghisler(Author) »

1. Sorry, too late for 10.50, it would need a new translation. Each new translation delays the release by about 1-2 months.

2. Not planned.
Author of Total Commander
https://www.ghisler.com
Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

Re: Dark mode: separators and buttons

Post by *Paul Mountit »

1. I'm not sure why this needs a new translation, but ok. maybe for the next update?

2. I don't understand why. it's very strange that buttons looks different depending on the theme.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark mode: separators and buttons

Post by *ghisler(Author) »

1. It's for configuring the color in the user interface: Configuration - Options - Color - Others.

2. They are not 100% the same - the button bar buttons are more like checkboxes (multiple can be down), while the drive buttons are more like radio buttons (only one can be down).
Author of Total Commander
https://www.ghisler.com
Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

Re: Dark mode: separators and buttons

Post by *Paul Mountit »

2. ok, but in "normal" theme the selected buttons/dirve look the same, in dark theme the sunken selection seems not consistent to me. but it's just a minor thing, of course

https://www.directupload.net/file/d/6559/vserwbs9_png.htm
Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

Re: Dark mode: separators and buttons

Post by *Paul Mountit »

tc11 time, I'd like to ask again for nr. 1 in the first post. thanks
Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

beta 11 dark mode: separators

Post by *Paul Mountit »

I've been using dark mode only since 10.50, I still miss an option to configure the color of the dividers between menu/icons/drive list/drive details.
they are painted with the border color, to me they look ok in normal theme and not so ok in dark theme, I'd really like to have a separate color option for these 3 lines, giving the possibility to make them disappear completely, like in the rightmost image, keeping at the same time the border color for the other items that use it.

Image: https://s20.directupload.net/images/220521/dnbni7gr.png
User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Dark mode: separators and buttons

Post by *white »

Moderator message from: white » 2023-05-27, 09:28 UTC

Topic "beta 11 dark mode: separators"' merged. This topic seems to be created to get more attention.

I don't think there is much confusion because this thread is about 2 things. If this changes in the future then a new thread can be created.
Paul Mountit
Junior Member
Junior Member
Posts: 66
Joined: 2020-04-18, 21:04 UTC

Re: Dark mode: separators and buttons

Post by *Paul Mountit »

sorry, I wanted to shift the focus on one thing only, since the button part is not going to be changed according to previous reply from mr. Ghisler.
feel free to remove if not appropriate
User avatar
white
Power Member
Power Member
Posts: 4595
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: Dark mode: separators and buttons

Post by *white »

2Paul Mountit
Don't worry about it. I made a judgement call that it is better to keep one thread for now.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark mode: separators and buttons

Post by *ghisler(Author) »

It's a good moment now to add this, but how would you name them in the user interface?
Currently all borders are configured via menu
Configuration - Options - Color - Others - Dark mode - Border.
Maybe "Horizontal separators"?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Dark mode: separators and buttons

Post by *petermad »

2ghisler(Author)

I would like to be able to also get rid of those horizontal separators at the button bar ALSO for Normal mode.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: Dark mode: separators and buttons

Post by *petermad »

history.txt wrote:31.05.23 Added: wincmd.ini [ColorsDark] HorizontalLines=RGB sets color of horizontal lines between menu bar, button bar, and drive bar (32/64)
Confirmed added in TC 11.00b5 - but could it please be implemented for Normal mode too - if feasible
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Fla$her
Power Member
Power Member
Posts: 2244
Joined: 2020-01-18, 04:03 UTC

Re: Dark mode: separators and buttons

Post by *Fla$her »

petermad wrote: 2023-05-29, 13:52 UTC I would like to be able to also get rid of those horizontal separators at the button bar ALSO for Normal mode.
Support! And even better, to return 3D for the XP/7 classics.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Dark mode: separators and buttons

Post by *ghisler(Author) »

2petermad
It is partially implemented for normal mode too, you just have to enter it manually in the [Colors] section. Why manually?
1. It doesn't fit anywhere in the configuration
2. Currently it doesn't work properly in the 32-bit version: The line below the menu gets overdrawn all the time by the Windows theme. It works fine in 64-bit, though. So far I couldn't find a reason for the 32-bit problem, it works properly there in dark mode...
Author of Total Commander
https://www.ghisler.com
Post Reply