[11.02RC1/2] Invalid pointer operation after LOADSEARCH ...

[hi5]

This happened with TC11.02RC1 and TC11.02RC2, Windows 10 & 11, 32bit

I was testing LOADSEARCH=MyTest to load a saved search via the Start menu.

Search details:

General tab:
Search for: ed:
[x] Everything

Plugins tab:
tc comments contains keyword

The search loaded fine, but when I started playing around with the search results and I removed the plugin via "fewer rules" or unchecked "search in plugins" and hit enter/search button I got the "Invalid pointer operation" error message copied below.

The first time it happened (RC1) and I continued the execution, the search results gui couldn't be closed with ESC any longer, and later become unresponsive.
When I closed it with X in the Gui TC just crashed silently.
This didn't happen later with TC11.02RC2.

I can't replicate it (yet) on Windows 10 too (edit few minutes later)

---------------------------
Total Commander 11.02RC2
---------------------------
Invalid pointer operation.
Invalid pointer operation
Windows 11 Enterprise 10.0 (Build 22621), base: 00400000
Please report this error to the Author, with a description
of what you were doing when this error occurred!
Delphi exception: EInvalidPointer
Stack trace:
775489F2
0044E0D8 0043D943 0044DFA1 0044DED7 00451502 0044F60E
0044FFA6 >0042B83E 0044F544 0042B83E 00430F50 00431114
0044F49A 0042B83E 0047604E 0044F60E 0044FFA6 0042B83E
0044F544 0042B83E 005B569C 0054517B 0043562A 0044DFA1
0044FFA6 0042B83E 0042B83E 0044F544 0042B83E 00431079
00431114
Raw:
004306DC 00402D9A 00402D9A 00402D9A 004026AC 00402D5C
00402D9A 00402D9A 00402D9A 00402732 00402FE3 0044E0D8
0043D396 0043D943 0044DFA1 00450275 0045031F 0043D309
0044F20B 00451163 0042F1F9 0044DFA1 00450275 0043EC8E
0042D839 0044F60E 0044DED7 00451502 0044DFA1 00450275
0043EC8E 0044F596 0044F60E 0044FFA6 0042B83E 0044F544
0042B83E 00430F50 0043104C 00431114 00402E7B 004E12CE
00430063 0044F49A 0042B83E 0045031F 0044DFA1 00450275
0043CDBF 0047604E 0044F60E 0044FFA6 0044FFC9 0042B83E
0044F544 0042B83E 005B569C 005C0038 004023FB 0044F49A
Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Yes No
---------------------------

Edit: now on windows 10 too

---------------------------
Total Commander 11.02RC2
---------------------------
Access violation at address 0A1A7C69. Read of address 00000002.
Access violation at address 0A1A7C69. Read of address 00000002
Windows 10 Professional 10.0 (Build 19045), base: 00400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
0A1A7C69
0044E0D8 0043D943 0044DFA1 0044DED7 00451502 0044F60E
0044FFA6 >0042B83E 0044F544 0042B83E 00430F50 00431114
0044F49A 0042B83E 0047604E 0044F60E 0044FFA6 0042B83E
0044F544 0042B83E 005B569C 0054517B 0043562A 0044DFA1
0044FFA6 0042B83E 0044F544 0044F544 0042B83E 00431079
00431114
Raw:
004023FB 004023FB 0044E0D8 0043D396 0043D943 0044DFA1
00450275 0045031F 0043D309 0044F20B 00451163 0042F1F9
0044DFA1 00450275 0043EC8E 0042D839 0044F60E 0044DED7
00451502 0044DFA1 00450275 0043EC8E 0044F596 0044F60E
0044FFA6 0042B83E 0044F544 0042B83E 00430F50 0043104C
00431114 00402E7B 005C0043 005005D2 0044F49A 0042B83E
0045031F 0044DFA1 00450275 0043CDBF 0047604E 0044F60E
0044FFA6 0044FFC9 0042B83E 0044F544 0042B83E 005B569C
00401DCC 00401E6D 004023FB 0044F49A 0042B83E 0045031F
0044DFA1 00450275 0043EC8E 0044F596 0044F60E 0044FFA6

Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Yes No
---------------------------

[ghisler(Author)]

I will check it, thanks.

[ghisler(Author)]

This should be fixed in RC3, please test it:

16.10.23 Fixed: Find files: when invoked via LOADSEARCH=Saved_search, start the search only after the search window is fully visible to avoid crash after additional searches (32/64)

[tuska]

2ghisler(Author)
I have performed the following tests:

Code: Select all

Saved search: MyTest
Search for:   ed:
Search in:    blank
✅ 'Everything'

Tab "Plugins"
✅ Search in plugins:   ◉  AND (all match)
Plugin: Property: OP:	    Value:
tc	comment   contains  hash

Starting directory: c:\totalcmd\

TC_clean.ini

Code: Select all

...
[searches]
MyTest_SearchFor=ed:
MyTest_SearchIn=
MyTest_SearchText=
MyTest_SearchFlags=0|002002000020|||||||||0000|||
MyTest_plugin=tc.comment contains hash
[SearchName]
0=ed:
[SearchIn]
0=c:\totalcmd
1=c:\
[user]
menu1=LOADSEARCH=MyTest
cmd1=LOADSEARCH
param1==MyTest
menu2=LOADSEARCH==MyTest
cmd2=LOADSEARCH
param2===MyTest

1. Button - LOADSEARCH = MyTest

Code: Select all

TOTALCMD#BAR#DATA
LOADSEARCH
=MyTest
wciconex.dll,22
LOADSEARCH=MyTest || ed:|Plugins tab: tc comments contains keyword|https://ghisler.ch/board/viewtopic.php?t=80278


-1

2. Button - LOADSEARCH == MyTest

Code: Select all

TOTALCMD#BAR#DATA
LOADSEARCH
==MyTest
wciconex.dll,22
LOADSEARCH==MyTest || ed:|Plugins tab: tc comments contains keyword|https://ghisler.ch/board/viewtopic.php?t=80278


-1

Tests

1. Test with: TC_clean_x64.ini ...
2. Change to the directory c:\totalcmd\
3. Click on 1st button - LOADSEARCH=MyTest
4. Search was successfully in the window with title "Find Files".
5. Click on tab "Plugins" -> WITHOUT having started a new search
6. Unchecked "Search in plugins:" and pressed ENTER -> NO crash! Search is carried out!
7. Added a new rule WITHOUT starting a new search:
   tc | fullname | contains | hash ... ◉ OR (any match) -> ENTER pressed -> NO crash! Search is performed!
8. WITHOUT starting a new search the last added rule is removed -> "Fewer rules > "Start search" works and there is no crash!
9. Tab "Load/Save": Click on "MyTest" > Load > "Start search" works!
10. "Find Files" Cancel
11. Click on 2nd button - LOADSEARCH==MyTest
12. Search result: with "Feed to listbox" -> OK!

TC_clean_x86.ini
The test was carried out analogous to TC 11.02RC3 x64 - see the list above.

Tests with TC_clean_x64.ini and TC_clean_x86.ini were carried out both with the buttons and via the starter menu(!).
For me I consider TC 11.02RC3 x64 & x86 to be OK.

---

Windows 11 Pro (x64) Version 22H2 (OS build Build 22621.2428)
TC 11.02RC3 x64/x86 | 'Everything' 1.5.0.1358a (x64)

[ghisler(Author)]

Thanks for the extensive tests! If anyone wonders, this was caused by the history of search results which you can reach with the <- -> buttons. It happens when the search starts before the search window has been displayed.

[hi5]

I can no longer replicate the error so looks like its fixed, thanks!

[ghisler(Author)]

Great, thanks!

Moderator message

Moved to fixed bugs